In-Portal Issue Tracker - In-Portal CMS
|
Viewing Issue Advanced Details |
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
1374 |
[In-Portal CMS] Admin Interfaces |
bug report |
always |
2012-08-15 08:07 |
2012-11-07 14:33 |
|
Reporter:
|
alex |
Platform:
|
|
|
Assigned To:
|
Dmitry |
OS:
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
Status:
|
resolved |
Product Version:
|
5.1.0 |
|
Product Build:
|
|
Resolution:
|
fixed |
|
|
ETA:
|
none |
Fixed in Version:
|
5.2.1-B1 |
|
Reference:
|
https://groups.google.com/d/topic/in-portal-bugs/0JOTWLsl6B4/discussion |
Change Log Message:
|
Fixes JavaScript error in "Change Log" section |
Estimate Points:
|
1 |
|
Summary:
|
0001374: JavaScript error in Change Logs section |
Description:
|
With "Change Log" section enabled try putting Google Analytics tracking code into corresponding system setting.
As a result new "updated" record would be created in "Change Log" section that would cause major error in JavaScript and a broken grid.
Also detailed information about record isn't revealed on double-click. |
Steps To Reproduce:
|
|
Additional Information:
|
|
Relationships | |
Attached Files:
|
change_log_js_error_fix.patch (977) 2012-08-15 08:07 http://tracker.in-portal.org/file_download.php?file_id=1778&type=bug |
|
Issue History |
Date Modified |
Username |
Field |
Change |
2012-11-07 14:33 |
Dmitry |
Status |
reviewed and tested => resolved |
2012-11-07 14:33 |
Dmitry |
Resolution |
reopened => fixed |
2012-11-07 14:33 |
Dmitry |
Assigned To |
=> Dmitry |
2012-11-07 13:02 |
erik |
Note Added: 0005290 |
|
2012-11-07 13:02 |
erik |
Assigned To |
erik => |
2012-11-07 13:02 |
erik |
Status |
needs testing => reviewed and tested |
2012-11-07 12:20 |
alex |
Assigned To |
alex => erik |
2012-11-07 12:20 |
alex |
Status |
needs feedback => needs testing |
2012-11-07 12:19 |
alex |
Note Added: 0005289 |
|
2012-11-07 12:17 |
erik |
Resolution |
fixed => reopened |
2012-11-07 12:16 |
erik |
Note Added: 0005288 |
|
2012-11-07 12:16 |
erik |
Status |
resolved => needs feedback |
2012-08-15 08:17 |
alex |
Note Added: 0005136 |
|
2012-08-15 08:17 |
alex |
Status |
reviewed and tested => resolved |
2012-08-15 08:17 |
alex |
Fixed in Version |
=> 5.2.1-B1 |
2012-08-15 08:17 |
alex |
Resolution |
open => fixed |
2012-08-15 08:17 |
alex |
Assigned To |
!COMMUNITY => alex |
2012-08-15 08:17 |
alex |
Changeset attached |
5.2.x r15515 |
2012-08-15 08:13 |
alex |
Note Added: 0005135 |
|
2012-08-15 08:13 |
alex |
Status |
needs testing => reviewed and tested |
2012-08-15 08:13 |
alex |
Assigned To |
=> !COMMUNITY |
2012-08-15 08:13 |
alex |
Developer |
=> alex |
2012-08-15 08:13 |
alex |
Status |
active => needs testing |
2012-08-15 08:12 |
alex |
Reference |
=> https://groups.google.com/d/topic/in-portal-bugs/0JOTWLsl6B4/discussion |
2012-08-15 08:07 |
alex |
New Issue |
|
2012-08-15 08:07 |
alex |
File Added: change_log_js_error_fix.patch |
|
2012-08-15 08:07 |
alex |
Change Log Message |
=> Fixes JavaScript error in "Change Log" section |
2012-08-15 08:07 |
alex |
Estimate Points |
=> 1 |
Notes |
|
(0005135)
|
alex
|
2012-08-15 08:13
|
|
Will test all together later. |
|
|
(0005136)
|
alex
|
2012-08-15 08:17
|
|
Fix committed to 5.2.x branch. Commit Message:
Fixes 0001374: JavaScript error in Change Logs section |
|
|
(0005288)
|
erik
|
2012-11-07 12:16
|
|
Not working. Nothing is written to change log.
// save changes to database
$sesion_log_id = $this->Application->RecallVar('_SessionLogId_');
if (!$save || !$sesion_log_id) {
// saving changes to database disabled OR related session log missing
return ;
}
In this place $sesion_log_id = false, and method returns before writing data to DB. |
|
|
(0005289)
|
alex
|
2012-11-07 12:19
|
|
That's because:
1. changes logging needs to be enabled first in configuration
2. re-login required to enable logging for currently logged-in user |
|
|
(0005290)
|
erik
|
2012-11-07 13:02
|
|
Ok, relogin was missed. Works fine. |
|