|
In-Portal Issue Tracker - In-Portal CMS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
1340 |
[In-Portal CMS] Data Management |
bug report |
always |
2012-07-09 11:02 |
2012-07-25 05:29 |
|
|
Reporter:
|
alex |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
closed |
Product Version:
|
5.0.0 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.2.0 |
|
|
Reference:
|
https://groups.google.com/d/topic/in-portal-dev/LKCfRhutepY/discussion |
|
Change Log Message:
|
Fixes session usage from scheduled tasks |
|
Estimate Points:
|
1 |
|
|
Summary:
|
0001340: Don't use session in scheduled tasks |
|
Description:
|
Prevent scheduled tasks to work with session. By their nature scheduled tasks take data from external data source (database, disk) and operate on it. They can't store anything into session and expect that they will get that data back next time scheduled task is executed.
Maybe they don't use session right now, but session is saved (again) after scheduled task execution finishes. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
| Relationships | | related to | 0001339 | closed (5.2.0) | alex | Long running scheduled task delays page loading | | related to | 0000981 | closed (5.2.0) | Dmitry | Rename Agents section to "Scheduled Tasks" | | related to | 0001191 | closed (5.2.0) | alex | Remove RunMode from Scheduled Tasks | | related to | 0001341 | closed (5.2.0) | alex | Create cron-like interface for scheduled tasks | | related to | 0001375 | resolved (5.2.1) | alex | Session cookies are sent out from PHP CLI |
|
|
Attached Files:
|
 prevent_scheduled_tasks_from_using_session.patch (2,948) 2012-07-17 07:56
http://tracker.in-portal.org/file_download.php?file_id=1756&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2012-08-17 09:21 |
alex |
Relationship added |
related to 0001375 |
|
2012-07-25 05:29 |
alex |
Note Added: 0004833 |
|
|
2012-07-25 05:29 |
alex |
Status |
resolved => closed |
|
2012-07-17 08:01 |
alex |
Changeset attached |
5.2.x r15456 |
|
2012-07-17 08:01 |
alex |
Note Added: 0004793 |
|
|
2012-07-17 08:01 |
alex |
Status |
reviewed and tested => resolved |
|
2012-07-17 08:01 |
alex |
Fixed in Version |
=> 5.2.0 |
|
2012-07-17 08:01 |
alex |
Resolution |
open => fixed |
|
2012-07-17 08:01 |
alex |
Assigned To |
!COMMUNITY => alex |
|
2012-07-17 07:58 |
alex |
Note Added: 0004792 |
|
|
2012-07-17 07:58 |
alex |
Status |
needs testing => reviewed and tested |
|
2012-07-17 07:58 |
alex |
Note Added: 0004791 |
|
|
2012-07-17 07:58 |
alex |
Assigned To |
=> !COMMUNITY |
|
2012-07-17 07:58 |
alex |
Developer |
=> alex |
|
2012-07-17 07:58 |
alex |
Status |
active => needs testing |
|
2012-07-17 07:56 |
alex |
File Added: prevent_scheduled_tasks_from_using_session.patch |
|
|
2012-07-09 11:09 |
alex |
Relationship added |
related to 0001341 |
|
2012-07-09 11:06 |
alex |
Relationship added |
related to 0001191 |
|
2012-07-09 11:03 |
alex |
Relationship added |
related to 0000981 |
|
2012-07-09 11:03 |
alex |
Relationship added |
related to 0001339 |
|
2012-07-09 11:02 |
alex |
New Issue |
|
|
2012-07-09 11:02 |
alex |
Reference |
=> https://groups.google.com/d/topic/in-portal-dev/LKCfRhutepY/discussion |
|
2012-07-09 11:02 |
alex |
Change Log Message |
=> Fixes session usage from scheduled tasks |
|
2012-07-09 11:02 |
alex |
Estimate Points |
=> 1 |
|
Notes |
|
|
(0004791)
|
|
alex
|
|
2012-07-17 07:58
|
|
Done.
Additionally I've added protection for cases, when user have set scheduled tasks to executed after page load (not from cron), but still added /tools/cron.php script to Cron. |
|
|
|
(0004792)
|
|
alex
|
|
2012-07-17 07:58
|
|
|
Will test all together later. |
|
|
|
(0004793)
|
|
alex
|
|
2012-07-17 08:01
|
|
Fix committed to 5.2.x branch. Commit Message:
Fixes 0001340: Don't use session in scheduled tasks |
|
|
|
(0004833)
|
|
alex
|
|
2012-07-25 05:29
|
|
|
Since 5.2.0 version was released. |
|