In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1326 [In-Portal CMS] Data Management bug report always 2012-06-16 11:34 2012-07-25 05:29
alex  
alex  
normal  
closed 5.2.0-B1  
fixed  
 
none 5.2.0  
https://groups.google.com/d/topic/in-portal-bugs/Hv9rG64UDfE/discussion
Fixes protected member access from PHP 5.2.x and below
2
0001326: Fatal error when trying to use parser tag caching in 5.2.0 on PHP version below 5.3.1
In PHP 5.3.1+ some OOP internals code was changed (see http://php.net/manual/en/language.oop5.visibility.php) resulting in ability for 2 classes sharing same parent class being able to access protected parent class properties.

This seemed a bug to me and some other PHP community members (see https://bugs.php.net/bug.php?id=50892 and http://youtrack.jetbrains.com/issue/WI-11713?projectKey=WI) at first, but it's how it works and nobody seem to disagree with it, since it's works in exactly same way as it works in Java, which is famous with it's OOP implementation.


I'm talking about this here, because in In-Portal 5.2.x we've made some changes that create 1 line of code, where exactly this change is exploited resulting a fatal error (only in code that uses tag caching), when somebody installs In-Portal 5.2.0+ on his webserver, which has PHP version below 5.3.1.
I'm attaching a patch for users, who want to use In-Portal 5.2.0+ installation (+tag caching) on PHP 5.2.x and above.
related to 0000107closed  (5.1.0)alex Implement "MemCached" functionality 
patch fatal_error_on_home_page_with_tag_caching_enabled_520.patch (686) 2012-06-16 11:34
http://tracker.in-portal.org/file_download.php?file_id=1710&type=bug
Issue History
2012-08-11 12:20 Dmitry Relationship added related to 0000107
2012-07-25 05:29 alex Note Added: 0004860
2012-07-25 05:29 alex Status resolved => closed
2012-06-16 11:36 alex Changeset attached 5.2.x r15412
2012-06-16 11:35 alex Note Added: 0004730
2012-06-16 11:35 alex Status reviewed and tested => resolved
2012-06-16 11:35 alex Fixed in Version => 5.2.0
2012-06-16 11:35 alex Resolution open => fixed
2012-06-16 11:35 alex Assigned To !COMMUNITY => alex
2012-06-16 11:35 alex Note Added: 0004729
2012-06-16 11:35 alex Status needs testing => reviewed and tested
2012-06-16 11:35 alex Assigned To => !COMMUNITY
2012-06-16 11:35 alex Developer => alex
2012-06-16 11:35 alex Status active => needs testing
2012-06-16 11:35 alex Reference => https://groups.google.com/d/topic/in-portal-bugs/Hv9rG64UDfE/discussion
2012-06-16 11:34 alex New Issue
2012-06-16 11:34 alex File Added: fatal_error_on_home_page_with_tag_caching_enabled_520.patch
2012-06-16 11:34 alex Change Log Message => Fixes protected member access from PHP 5.2.x and below
2012-06-16 11:34 alex Estimate Points => 2

Notes
(0004729)
alex   
2012-06-16 11:35   
Will test all together later.
(0004730)
alex   
2012-06-16 11:35   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001326: Fatal error when trying to use parser tag caching in 5.2.0 on PHP version below 5.3.1
(0004860)
alex   
2012-07-25 05:29   
Since 5.2.0 version was released.