In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1309 [In-Portal CMS] Data Management bug report always 2012-06-03 00:23 2012-07-25 05:29
Dmitry  
alex  
normal  
closed 5.0.0  
fixed  
 
none 5.2.0-RC1  
https://groups.google.com/d/topic/in-portal-bugs/A0l7Fa03mlg/discussion
Fixed oncorrect behavior of "has_sub_menu" param in CachedMenu
1
0001309: Incorrect behavior of "has_sub_menu" param in CachedMenu
Bug in our CachedMenu tag (prints cached version of the menu) related to detection of active sub-menus on 2+ level of the menu.

There is a special param called "has_sub_menu" which allows you to check if current menu level (when printed using CachedMenu tag) has any Active + Visible sections inside of it which helps you to decide if sub-menu with these sections will be printed/shown.

This param worked well for 1st level of the menu, but didn't check for Section Menu Visibility on 2+ levels of the Menu.

See attached screenshot.
png In-Portal_--_Empty_Sub-menu.png (74,365) 2012-06-03 00:23
http://tracker.in-portal.org/file_download.php?file_id=1697&type=bug
png

patch issue_with_empty_sub-menu.patch (800) 2012-06-03 00:23
http://tracker.in-portal.org/file_download.php?file_id=1698&type=bug
Issue History
2012-07-25 05:29 alex Note Added: 0004869
2012-07-25 05:29 alex Status resolved => closed
2012-06-05 12:44 alex Changeset attached 5.2.x r15384
2012-06-05 12:44 alex Note Added: 0004711
2012-06-05 12:44 alex Status reviewed and tested => resolved
2012-06-05 12:44 alex Fixed in Version => 5.2.0-RC1
2012-06-05 12:44 alex Resolution open => fixed
2012-06-05 12:44 alex Assigned To !COMMUNITY => alex
2012-06-05 12:44 alex Note Added: 0004710
2012-06-05 12:44 alex Status needs testing => reviewed and tested
2012-06-05 12:43 alex Estimate Points 0 => 1
2012-06-03 00:26 Dmitry Reference [/url] => [url]https://groups.google.com/d/topic/in-portal-bugs/A0l7Fa03mlg/discussion
2012-06-03 00:26 Dmitry Developer Dmitry => alex
2012-06-03 00:24 Dmitry Note Added: 0004702
2012-06-03 00:24 Dmitry Assigned To => !COMMUNITY
2012-06-03 00:24 Dmitry Developer => Dmitry
2012-06-03 00:24 Dmitry Status active => needs testing
2012-06-03 00:23 Dmitry File Added: issue_with_empty_sub-menu.patch
2012-06-03 00:23 Dmitry New Issue
2012-06-03 00:23 Dmitry File Added: In-Portal_--_Empty_Sub-menu.png
2012-06-03 00:23 Dmitry Reference => [url][/url]
2012-06-03 00:23 Dmitry Change Log Message => Fixed oncorrect behavior of "has_sub_menu" param in CachedMenu
2012-06-03 00:23 Dmitry Estimate Points => 0

Notes
(0004702)
Dmitry   
2012-06-03 00:24   
Patch attached - please test and review
(0004710)
alex   
2012-06-05 12:44   
Will test all together later.
(0004711)
alex   
2012-06-05 12:44   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001309: Incorrect behavior of "has_sub_menu" param in CachedMenu
(0004869)
alex   
2012-07-25 05:29   
Since 5.2.0 version was released.