In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1299 [In-Portal CMS] Front End bug report always 2012-05-29 03:59 2012-07-25 05:30
alex  
alex  
normal  
closed 5.1.3  
fixed  
 
none 5.2.0-RC1  
https://groups.google.com/d/topic/in-portal-bugs/sNT6T-WXL-k/discussion
Fixes missing "index.html" in links into non-primary theme/language
1
0001299: Return "/index.html" back to homepage url in non-default theme/language
In 0001075 (5.1.3) we've made, that homepage url doesn't include "/index.html" at the end.

This might seem good decision when website have only 1 theme or language.

But in case if website can have multiple themes/languages, then following links are created now:
* http://www.website.tld/sub-folder/another_theme.html (instead of http://www.website.tld/sub-folder/another_theme/index.html)
* http://www.website.tld/sub-folder/another_language.html (instead of http://www.website.tld/sub-folder/another_language/index.html)
* http://www.website.tld/sub-folder/another_language/another_theme.html (instead of http://www.website.tld/sub-folder/another_language/another_theme/index.html)

Since we're trying to replicate actual folders on disk with these mod-rewrite urls, then removing /index.html from urls in different language/theme really breaks this concept.
Here are semantics behind each of these urls:
* bad: http://www.website.tld/sub-folder/another_theme.html - show me "another_theme.html" document content
* good: http://www.website.tld/sub-folder/another_theme/index.html - show me "index.html" document of inside "another_theme" folder (which is theme, but this folder meaning is irrelevant in this example)
* bad: http://www.website.tld/sub-folder/another_language.html - show me "another_language.html" document content
* good: http://www.website.tld/sub-folder/another_language/index.html - show me "index.html" document of inside "another_language" folder (which is language, but this folder meaning is irrelevant in this example)

Main goal is to let user (or crawler) know what actual page he/it will get based on the url.
child of 0001075closed  (5.1.3)alex Homepage URL should be a Domain name 
patch index_html_missing_from_theme_language_links.patch (1,392) 2012-05-29 03:59
http://tracker.in-portal.org/file_download.php?file_id=1675&type=bug
Issue History
2012-07-25 05:30 alex Note Added: 0004889
2012-07-25 05:30 alex Status resolved => closed
2012-05-29 04:04 alex Note Added: 0004667
2012-05-29 04:04 alex Status reviewed and tested => resolved
2012-05-29 04:04 alex Fixed in Version => 5.2.0-RC1
2012-05-29 04:04 alex Resolution open => fixed
2012-05-29 04:04 alex Assigned To !COMMUNITY => alex
2012-05-29 04:04 alex Changeset attached 5.2.x r15361
2012-05-29 04:02 alex Relationship added child of 0001075
2012-05-29 04:01 alex Note Added: 0004666
2012-05-29 04:01 alex Status needs testing => reviewed and tested
2012-05-29 04:01 alex Assigned To => !COMMUNITY
2012-05-29 04:01 alex Developer => alex
2012-05-29 04:01 alex Status active => needs testing
2012-05-29 03:59 alex New Issue
2012-05-29 03:59 alex File Added: index_html_missing_from_theme_language_links.patch
2012-05-29 03:59 alex Reference => https://groups.google.com/d/topic/in-portal-bugs/sNT6T-WXL-k/discussion
2012-05-29 03:59 alex Change Log Message => Fixes missing "index.html" in links into non-primary theme/language
2012-05-29 03:59 alex Estimate Points => 1

Notes
(0004666)
alex   
2012-05-29 04:01   
Will test all together later.
(0004667)
alex   
2012-05-29 04:04   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001299: Return "/index.html" back to homepage url in non-default theme/language
(0004889)
alex   
2012-07-25 05:30   
Since 5.2.0/1.2.0 versions was released.