In-Portal Issue Tracker - In-Portal CMS
|
|||||
Viewing Issue Advanced Details | |||||
|
|||||
ID: | Category: | Type: | Reproducibility: | Date Submitted: | Last Update: |
1295 | [In-Portal CMS] Front End | refactoring | N/A | 2012-05-18 05:54 | 2012-07-25 05:30 |
|
|||||
Reporter: | alex | Platform: | |||
Assigned To: | alex | OS: | |||
Priority: | normal | OS Version: | |||
Status: | closed | Product Version: | 5.2.0-B1 | ||
Product Build: | Resolution: | fixed | |||
ETA: | none | Fixed in Version: | 5.2.0-RC1 | ||
Reference: | https://groups.google.com/d/topic/in-portal-dev/IHK2c-QayMk/discussion | ||||
Change Log Message: | Adds improvements to FormManager class | ||||
Estimate Points: | 1 | ||||
|
|||||
Summary: | 0001295: Improvements to FormManager JavaScript class | ||||
Description: |
In In-Portal we've developed FormManager class, that is used to manage forms that are submitted and validated through ajax. I wanted to share several improvements we've made to original version we've used quite a lot over last years: * set error into a field before form is registered * set form-specific template to be used in all ajax calls * perform immediate validation for inputs on blur event, but for other controls (like radio buttons) in click event * if event, called through AjaxFormHelper::transitEvent method requested a redirect to another page (e.g. by setting $event->redirect property), then automatically perform redirect * watermarks were not removed when using immediate field validation * watermark removal code (that was called before form submit) first removed watermarks and then restored them, but should be restoring original values in these fields * error were not removed from form after it was closed by user (without submitting) |
||||
Steps To Reproduce: | |||||
Additional Information: | |||||
Relationships | |||||
Attached Files: |
form_manager_improvements_core.patch (1,023) 2012-05-18 05:54 http://tracker.in-portal.org/file_download.php?file_id=1671&type=bug |
||||
|
|||||
Issue History | |||||
Date Modified | Username | Field | Change | ||
2012-07-25 05:30 | alex | Note Added: 0004893 | |||
2012-07-25 05:30 | alex | Status | resolved => closed | ||
2012-05-18 05:57 | alex | Note Added: 0004661 | |||
2012-05-18 05:57 | alex | Status | reviewed and tested => resolved | ||
2012-05-18 05:57 | alex | Fixed in Version | => 5.2.0-RC1 | ||
2012-05-18 05:57 | alex | Resolution | open => fixed | ||
2012-05-18 05:57 | alex | Assigned To | !COMMUNITY => alex | ||
2012-05-18 05:57 | alex | Changeset attached | 5.2.x r15357 | ||
2012-05-18 05:56 | alex | Changeset attached | 1.0.x r15356 | ||
2012-05-18 05:56 | alex | Note Added: 0004660 | |||
2012-05-18 05:56 | alex | Status | needs testing => reviewed and tested | ||
2012-05-18 05:55 | alex | Assigned To | => !COMMUNITY | ||
2012-05-18 05:55 | alex | Developer | => alex | ||
2012-05-18 05:55 | alex | Status | active => needs testing | ||
2012-05-18 05:55 | alex | Reference | => https://groups.google.com/d/topic/in-portal-dev/IHK2c-QayMk/discussion | ||
2012-05-18 05:54 | alex | New Issue | |||
2012-05-18 05:54 | alex | File Added: form_manager_improvements_core.patch | |||
2012-05-18 05:54 | alex | Change Log Message | => Adds improvements to FormManager class | ||
2012-05-18 05:54 | alex | Estimate Points | => 1 |
Notes | |||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|