In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1288 [In-Portal CMS] Optimization feature request N/A 2012-05-17 04:44 2012-07-25 05:30
alex  
alex  
normal  
closed 5.2.0-B1  
fixed  
 
none 5.2.0-RC1  
https://groups.google.com/d/topic/in-portal-dev/wN8rU0rqTT0/discussion
Simplifies working with urls
1
0001288: Improvements to rewrite listeners
Since rewrite listeners were first introduced in 0000098 I we've used them on several projects. And I wanted to share some improvements we've done with the community.

That includes following changes to widget rewrite listener (in Development Kit module):
1. reduced SQL count when building url because of actual url part passed to rewrite builder right from $object (see WidgetTagProcessor::ItemLink tag)
2. always use physical template when building url when deciding whatever to include it in url or not (when it's default item detail template)
3. allow for rewrite parser to intellectually search for url part it require ignoring changes made to other parts of url:
* worked before: "/widgets/widget-filename.html"
* works now: "/text-before/widgets/widget-filename/text-after"
4. easily check if there are unparsed url parts and there are none then set rewrite parser default item detail template
child of 0000098closed  (5.0.1)alex Redo Mod-Rewrite for Better Flexibility 
patch rewrite_listener_improvements_core.patch (513) 2012-05-17 04:44
http://tracker.in-portal.org/file_download.php?file_id=1661&type=bug
patch rewrite_listener_improvements_modules.patch (20,228) 2012-05-17 04:44
http://tracker.in-portal.org/file_download.php?file_id=1662&type=bug
Issue History
2012-07-25 05:30 alex Note Added: 0004900
2012-07-25 05:30 alex Status resolved => closed
2012-05-17 04:47 alex Note Added: 0004648
2012-05-17 04:47 alex Status reviewed and tested => resolved
2012-05-17 04:47 alex Fixed in Version => 5.2.0-RC1
2012-05-17 04:47 alex Resolution open => fixed
2012-05-17 04:47 alex Assigned To !COMMUNITY => alex
2012-05-17 04:47 alex Changeset attached 5.2.x r15343
2012-05-17 04:47 alex Changeset attached 1.2.x r15342
2012-05-17 04:46 alex Note Added: 0004647
2012-05-17 04:46 alex Status needs testing => reviewed and tested
2012-05-17 04:46 alex Assigned To => !COMMUNITY
2012-05-17 04:46 alex Developer => alex
2012-05-17 04:46 alex Status active => needs testing
2012-05-17 04:46 alex Reference => https://groups.google.com/d/topic/in-portal-dev/wN8rU0rqTT0/discussion
2012-05-17 04:44 alex Relationship added child of 0000098
2012-05-17 04:44 alex File Added: rewrite_listener_improvements_modules.patch
2012-05-17 04:44 alex New Issue
2012-05-17 04:44 alex File Added: rewrite_listener_improvements_core.patch
2012-05-17 04:44 alex Change Log Message => Simplifies working with urls
2012-05-17 04:44 alex Estimate Points => 1

Notes
(0004647)
alex   
2012-05-17 04:46   
Will test all together later.
(0004648)
alex   
2012-05-17 04:47   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001288: Improvements to rewrite listeners
(0004900)
alex   
2012-07-25 05:30   
Since 5.2.0/1.2.0 versions was released.