In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1279 [In-Portal CMS] Front End feature request always 2012-05-16 22:44 2012-07-25 05:30
Dmitry  
alex  
normal  
closed 5.2.0-B3  
fixed  
 
none 5.2.0-RC1  
https://groups.google.com/d/topic/in-portal-dev/h5uksZXNLsI/discussion
Improved Mod-Rewrite URL Parser to support GET params
2
0001279: Improve Mod-Rewrite URL Parser to Support GET params
Currently mod-rewrite parser is semi-intelligent, since it only parses url part between / and .html, e.g. "my/custom/url".

I'm proposing for him to be able to parse whole url in format http://www.website.tld/sub-folder/my/custom/url.html?param1=value1&param2=value2.

This could be done pretty easy using parse_str (query string parsing) and parse_url (to separate query string from main url) functions.

With this improvements mod-rewrite class can parse any url and not only it's part.
parent of 0001324closed  (5.2.0)alex Performing login on category item detail page results in redirect to /error_notfound.html page 
parent of 0001405resolved  (5.2.1)alex Urls with "&" are incorrectly parsed 
patch complete_url_parse_support_520.patch (7,407) 2012-05-30 10:23
http://tracker.in-portal.org/file_download.php?file_id=1688&type=bug
patch complete_url_parse_support_513.patch (6,666) 2012-05-30 10:24
http://tracker.in-portal.org/file_download.php?file_id=1689&type=bug
Issue History
2012-09-26 05:30 alex Relationship added parent of 0001405
2012-07-25 05:30 alex Note Added: 0004877
2012-07-25 05:30 alex Status resolved => closed
2012-06-15 07:39 alex Relationship added parent of 0001324
2012-05-30 10:54 Dmitry Target Version Icebox => 5.2.0
2012-05-30 10:27 alex Note Added: 0004691
2012-05-30 10:27 alex Status reviewed and tested => resolved
2012-05-30 10:27 alex Fixed in Version => 5.2.0-RC1
2012-05-30 10:27 alex Resolution open => fixed
2012-05-30 10:27 alex Assigned To !COMMUNITY => alex
2012-05-30 10:27 alex Changeset attached 5.2.x r15374
2012-05-30 10:26 alex Note Added: 0004690
2012-05-30 10:26 alex Status needs testing => reviewed and tested
2012-05-30 10:26 alex Note Added: 0004689
2012-05-30 10:24 alex Assigned To => !COMMUNITY
2012-05-30 10:24 alex Developer => alex
2012-05-30 10:24 alex Status active => needs testing
2012-05-30 10:24 alex Estimate Points 0 => 2
2012-05-30 10:24 alex File Added: complete_url_parse_support_513.patch
2012-05-30 10:23 alex File Added: complete_url_parse_support_520.patch
2012-05-16 22:44 Dmitry New Issue
2012-05-16 22:44 Dmitry Reference => https://groups.google.com/d/topic/in-portal-dev/h5uksZXNLsI/discussion
2012-05-16 22:44 Dmitry Change Log Message => Improved Mod-Rewrite URL Parser to support GET params
2012-05-16 22:44 Dmitry Estimate Points => 0

Notes
(0004689)
alex   
2012-05-30 10:26   
I've used improved improved kRewriteUrlParser::parse method right after user login in mod-rewrite to inject user language into page, that will be shown after login.
(0004690)
alex   
2012-05-30 10:26   
Will test all together later.
(0004691)
alex   
2012-05-30 10:27   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001279: Improve Mod-Rewrite URL Parser to Support GET params
(0004877)
alex   
2012-07-25 05:30   
Since 5.2.0/1.2.0 versions was released.