0001226: Storing function "crc32" results in database problem

1226

[In-Portal CMS] Database

bug report

always

2012-03-14 12:31

2012-07-25 05:31

Reporter:

alex

Platform:

Assigned To:

alex

OS:

Priority:

normal

OS Version:

Status:

closed

Product Version:

5.2.0-B2

Product Build:

Resolution:

fixed

ETA:

none

Fixed in Version:

5.2.0-B3

Reference:

https://groups.google.com/d/topic/in-portal-bugs/stMGddx3KJk/discussion

Change Log Message:

Fixes problems with crc32 function usage on 64bit web servers

Estimate Points:

1

Summary:

0001226: Storing function "crc32" results in database problem

Description:

When web server OS is 32bit, then results of crc32 functions are positive and negative numbers in range, that fits nicely in "signed int" column in MySQL database.

However, when web server OS is 64bit, then same crc32 function produces only positive numbers (internally converts negative results to positive, not by removing sign from them) producing number is no longer fits into "signed it" range and will fit only in:
* unsigned int
* signed/unsigned bigint

Since we can't guess what architecture of web server, that will run In-Portal, would be then we need to:
convert all negative results of crc32 function to positive using $positive_crc = printf('%u', $crc) code
make all db columns, that can store such numbers either "int unsigned" or "bigint"

In 5.2.0-B2 this was noticed after tag <inp2:st_ContentBlock name="logos"/> was executed and produced content block number was stored incorrectly resulting inability to save content block changes.

Steps To Reproduce:

Additional Information:

We have 54 places, where crc32 function is used (across all modules) and each place needs to be inspected.

How to perform conversion in MySQL:
-----------------------------------

ALTER TABLE TableName CHANGE FieldName FieldName BIGINT(11) NOT NULL DEFAULT '0';

UPDATE TableName
SET FieldName = CAST((FieldName & 0xFFFFFFFF) AS UNSIGNED INTEGER)
WHERE FieldName < 0;

Relationships

parent of

0001223

closed (5.2.0)

!COMMUNITY

Fatal on viewing page in Browse Mode via Catalog with MySQL in Strict mode

Attached Files:

crc32_signed_problem_core.patch (8,730) 2012-03-27 06:45
http://tracker.in-portal.org/file_download.php?file_id=1576&type=bug

crc32_signed_problem_modules.patch (7,639) 2012-03-27 06:46
http://tracker.in-portal.org/file_download.php?file_id=1577&type=bug

2012-07-25 05:31