In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
1224 [In-Portal CMS] Email Templates refactoring always 2012-03-14 12:06 2012-07-25 05:30
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.2.0-B2  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B3  
Reference: https://groups.google.com/d/topic/in-portal-dev/Iwcm_7syTa4/discussion
Change Log Message: Improves e-mail sending internals
Estimate Points: 2
Summary: 0001224: Email event usage refactoring
Description: Currently e-mail event sending process (internally) doesn't represent real world model, which makes it hard to improve this code with new features.

I'm proposing to:
1. create kEmail class with following public methods:
- findEvent($name, $type)
- setParams($params)
- send()
2. make $this->sender refer to kEmailSendingHelper class instance for easy access across all methods
3. move existing code from EmailEventsEventHandler into new kEmail class
4. replace OnEmailEvent event sending with new kEmail class usage

At the end interface of kApplication::EmailEventUser and kApplication::EmailEventAdmin will be almost the same (will return true/false instead of kEvent object), so no need to change code to make it working again.

Usually nobody relies on e-mail sent fact in their code anyway.
Steps To Reproduce:
Additional Information:
Relationships
parent of 0001307closed  (5.2.0)alex In-Portal Tags Stripped during HTML-to-Plain text Conversion 
related to 0000485closed  (5.2.0)alex Create more control over sent emails 
related to 0000268active  (5.2.1) Code Cleanup in 5.2.x branch 
related to 0001227closed  (5.2.0)alex Ability to specify both HTML and Plain Text version of e-mail event 
related to 0001196closed  (5.2.0)alex Improvements to Languages and Phrases Export capabilities 
related to 0001301closed  (5.2.0)alex Missing e-mail event type in E-mail Log 
Attached Files: patch email_internals_refactoring_core.patch (46,222) 2012-03-15 04:31
http://tracker.in-portal.org/file_download.php?file_id=1551&type=bug
patch email_internals_refactoring_modules.patch (11,125) 2012-03-15 04:32
http://tracker.in-portal.org/file_download.php?file_id=1552&type=bug
patch email_language_not_restored_back_513.patch (1,093) 2012-05-11 15:55
http://tracker.in-portal.org/file_download.php?file_id=1648&type=bug
Issue History
Date Modified Username Field Change
2012-07-25 05:30 alex Note Added: 0004910
2012-07-25 05:30 alex Status resolved => closed
2012-05-30 22:27 Dmitry Relationship added parent of 0001307
2012-05-29 04:54 alex Relationship added related to 0001301
2012-05-11 15:58 alex Note Added: 0004626
2012-05-11 15:55 alex File Added: email_language_not_restored_back_513.patch
2012-03-15 10:17 alex Relationship added related to 0001196
2012-03-15 04:43 alex Relationship added related to 0001227
2012-03-15 04:33 alex Note Added: 0004497
2012-03-15 04:33 alex Status reviewed and tested => resolved
2012-03-15 04:33 alex Fixed in Version => 5.2.0-B3
2012-03-15 04:33 alex Resolution open => fixed
2012-03-15 04:33 alex Assigned To !COMMUNITY => alex
2012-03-15 04:33 alex Changeset attached 5.2.x r15215
2012-03-15 04:32 alex Changeset attached 5.2.x r15214
2012-03-15 04:32 alex Changeset attached 5.2.x r15213
2012-03-15 04:32 alex Note Added: 0004496
2012-03-15 04:32 alex Status needs testing => reviewed and tested
2012-03-15 04:32 alex Assigned To => !COMMUNITY
2012-03-15 04:32 alex Developer => alex
2012-03-15 04:32 alex Status active => needs testing
2012-03-15 04:32 alex File Added: email_internals_refactoring_modules.patch
2012-03-15 04:31 alex File Added: email_internals_refactoring_core.patch
2012-03-14 12:12 alex Relationship added related to 0000268
2012-03-14 12:11 alex Relationship added related to 0000485
2012-03-14 12:10 alex Reference => https://groups.google.com/d/topic/in-portal-dev/Iwcm_7syTa4/discussion
2012-03-14 12:06 alex New Issue
2012-03-14 12:06 alex Change Log Message => Improves e-mail sending internals
2012-03-14 12:06 alex Estimate Points => 2

Notes
(0004496)
alex   
2012-03-15 04:32   
Will test all together later.
(0004497)
alex   
2012-03-15 04:33   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001224: Email event usage refactoring
(0004626)
alex   
2012-05-11 15:58   
Patch "email_language_not_restored_back_513.patch" fixes stuck language problem, when e-mail language is also set as website language after e-mail event is sent.

For example user is viewing website in English, but changes a link (in-link) and LINK.MODIFY e-mail is sent to Admin, who have set "German" as his communication (last admin console visit language). Then user will see "Thank you. Your changes awaiting administrator approval" page and message on German.
(0004910)
alex   
2012-07-25 05:30   
Since 5.2.0/1.2.0 versions was released.