In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1183 [In-Portal CMS] Mailing System feature request always 2011-12-23 15:25 2012-07-25 05:32
Dmitry  
alex  
normal  
closed  
fixed  
 
none 5.2.0-B1  
https://groups.google.com/d/topic/in-portal-dev/BCCyyR097iQ/discussion
Added separate setting for default email sender / recipient
2
0001183: Separate setting for default Email Sender / Recipients
In-Portal has single configuration variable "Messages from Site Admin are from" (Smtp_AdminMailFrom), that is used as default from e-mail for all outgoing e-mail that are sent from the site.

In fact the same configuration variable is used as default recipient for any e-mail, that is sent to administrator from the site (e.g. validate new link e-mail, contact us form was submitted e-mail).
This is inconvinient, since you can't specify multiple admin e-mails because same e-mail list would be used as "From" part of outgoing e-mails and will break them down.

Now you need to go though every e-mail event settings and manually assign admin users to each event and that's inconvenient.


Proposed Solution:

1. Add configuration variable called "DefaultEmailRecipients". Place a standard recipient entering control from "Settings" tab of e-mail event editing page (see attached image) that allows to specify to/cc/bcc. Place it after "Mailing List Send Per Step" variable under "Admin -> Configuration -> Website -> Advanced: Mailing Settings" section.

2. By default use default "from e-mail" that we already have to act as "to e-mail" (for admin email events) in case if to e-mails in a new form haven't been specified.

3. Add same variable to site domain record, since default from e-mail

4. Rename "Smtp_AdminMailFrom" to "DefaultEmailSender" - across the system
png email_recipient_control.png (10,609) 2011-12-23 15:25
http://tracker.in-portal.org/file_download.php?file_id=1409&type=bug
png

patch separate_default_email_recipients_core.patch (81,313) 2011-12-29 06:44
http://tracker.in-portal.org/file_download.php?file_id=1427&type=bug
patch separate_default_email_recipients_modules.patch (2,722) 2011-12-29 06:45
http://tracker.in-portal.org/file_download.php?file_id=1428&type=bug
patch separate_default_email_recipients_themes.patch (867) 2011-12-29 06:45
http://tracker.in-portal.org/file_download.php?file_id=1429&type=bug
Issue History
2012-07-25 05:32 alex Note Added: 0005014
2012-07-25 05:32 alex Status resolved => closed
2011-12-29 06:47 alex Changeset attached 5.2.x r14941
2011-12-29 06:47 alex Note Added: 0004345
2011-12-29 06:47 alex Status reviewed and tested => resolved
2011-12-29 06:47 alex Fixed in Version => 5.2.0-B1
2011-12-29 06:47 alex Resolution open => fixed
2011-12-29 06:47 alex Assigned To !COMMUNITY => alex
2011-12-29 06:46 alex Changeset attached 5.2.x r14940
2011-12-29 06:46 alex Changeset attached 5.2.x r14939
2011-12-29 06:45 alex Changeset attached 1.2.x r14938
2011-12-29 06:45 alex Note Added: 0004344
2011-12-29 06:45 alex Status needs testing => reviewed and tested
2011-12-29 06:45 alex Assigned To => !COMMUNITY
2011-12-29 06:45 alex Developer => alex
2011-12-29 06:45 alex Status active => needs testing
2011-12-29 06:45 alex File Added: separate_default_email_recipients_themes.patch
2011-12-29 06:45 alex File Added: separate_default_email_recipients_modules.patch
2011-12-29 06:44 alex File Added: separate_default_email_recipients_core.patch
2011-12-29 03:17 alex Estimate Points 0 => 2
2011-12-23 15:27 Dmitry Description Updated bug_revision_view_page.php?rev_id=939#r939
2011-12-23 15:25 Dmitry New Issue
2011-12-23 15:25 Dmitry File Added: email_recipient_control.png
2011-12-23 15:25 Dmitry Reference => https://groups.google.com/d/topic/in-portal-dev/BCCyyR097iQ/discussion
2011-12-23 15:25 Dmitry Change Log Message => Added separate setting for default email sender / recipient
2011-12-23 15:25 Dmitry Estimate Points => 0

Notes
(0004344)
alex   
2011-12-29 06:45   
Will test all together later.
(0004345)
alex   
2011-12-29 06:47   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001183: Separate setting for default Email Sender / Recipients
Done Additionally:
1. wrong constants were used on "Settings" tab (e-mail event editing page) resulting JS error
2. e-mail sending to a group, specified on "Settings" tab (e-mail event editing page) wasn't working
(0005014)
alex   
2012-07-25 05:32   
Since 5.2.0 version was released.