In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1146 [In-Portal CMS] Front End bug report always 2011-10-17 08:19 2012-07-25 05:32
alex  
alex  
normal  
closed 5.1.0  
fixed  
 
none 5.2.0-B1  
https://groups.google.com/d/topic/in-portal-bugs/jMXBiBoEH-0/discussion
Fixes parameter "template" value within element rendered in st_CachedMenu tag
0
0001146: Tag "st_CachedMenu" sets incorrect "template" parameter to menu elements (v 5.1.0)
Below is the code, that could be to display website menu top level:

<inp2:m_DefineElement name="menu_element">
    <a href="<inp2:m_Link template='$template' m_cat_id='$cat_id' use_section='$use_section'/>">
        <inp2:m_Param name="title"/>
    </a>
</inp2:m_DefineElement>

<inp2:st_CachedMenu render_as="menu_element" category_id="1"/>

This code works before and after In-Portal 5.1.0 version. Problem arises, when developer tries to use "template" parameter directly without passing it to m_Link tag.

For example here the result of <inp2:m_Param name="template"/> tag before & after In-Portal 5.1.0 release:
before 5.1.0 release: "path/to/template"
after 5.1.0 release: "id:434" (434 is ID of a section, that is displayed in menu)

Attached patch restored pre 5.1.0 behavior related to "template" parameter value.
patch cachedmenu_tag_pass_template_instead_of_its_id.patch (653) 2011-10-17 08:19
http://tracker.in-portal.org/file_download.php?file_id=1246&type=bug
patch cachedmenu_tag_pass_template_instead_of_its_id_520.patch (702) 2011-12-27 03:26
http://tracker.in-portal.org/file_download.php?file_id=1410&type=bug
Issue History
2012-07-25 05:32 alex Note Added: 0005017
2012-07-25 05:32 alex Status resolved => closed
2011-12-27 03:27 alex Note Added: 0004318
2011-12-27 03:27 alex Status reviewed and tested => resolved
2011-12-27 03:27 alex Fixed in Version => 5.2.0-B1
2011-12-27 03:27 alex Resolution open => fixed
2011-12-27 03:27 alex Changeset attached 5.2.x r14915
2011-12-27 03:26 alex File Added: cachedmenu_tag_pass_template_instead_of_its_id_520.patch
2011-12-23 14:56 Dmitry Note Added: 0004315
2011-12-23 14:56 Dmitry Assigned To !COMMUNITY => alex
2011-12-23 14:56 Dmitry Status needs testing => reviewed and tested
2011-12-23 10:43 Dmitry Estimate Points => 0
2011-12-23 10:43 Dmitry Target Version 5.1.4 => 5.2.0
2011-10-17 08:22 alex Assigned To => !COMMUNITY
2011-10-17 08:22 alex Developer => alex
2011-10-17 08:22 alex Status active => needs testing
2011-10-17 08:22 alex Reference => https://groups.google.com/d/topic/in-portal-bugs/jMXBiBoEH-0/discussion
2011-10-17 08:20 alex Description Updated bug_revision_view_page.php?rev_id=884#r884
2011-10-17 08:19 alex New Issue
2011-10-17 08:19 alex File Added: cachedmenu_tag_pass_template_instead_of_its_id.patch
2011-10-17 08:19 alex Change Log Message => Fixes parameter "template" value within element rendered in st_CachedMenu tag

Notes
(0004315)
Dmitry   
2011-12-23 14:56   
Reviewed and tested, please commit to 5.2.0
(0004318)
alex   
2011-12-27 03:27   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001146: Tag "st_CachedMenu" sets incorrect "template" parameter to menu elements
(0005017)
alex   
2012-07-25 05:32   
Since 5.2.0 version was released.