In-Portal Issue Tracker - In-Portal CMS
|
|||||||||||||||
Viewing Issue Advanced Details | |||||||||||||||
|
|||||||||||||||
ID: | Category: | Type: | Reproducibility: | Date Submitted: | Last Update: | ||||||||||
1142 | [In-Portal CMS] Data Management | bug report | always | 2011-10-17 05:05 | 2012-07-25 05:32 | ||||||||||
|
|||||||||||||||
Reporter: | phil | Platform: | |||||||||||||
Assigned To: | alex | OS: | |||||||||||||
Priority: | normal | OS Version: | |||||||||||||
Status: | closed | Product Version: | 5.1.0 | ||||||||||||
Product Build: | Resolution: | fixed | |||||||||||||
ETA: | none | Fixed in Version: | 5.2.0-B1 | ||||||||||||
Reference: | https://groups.google.com/d/topic/in-portal-bugs/yzlo09tGZ7k/discussion | ||||||||||||||
Change Log Message: | Fixed image delete on link approve (when LINK.OWNER.MODIFY.PENDING permission was used) | ||||||||||||||
Estimate Points: | 2 | ||||||||||||||
|
|||||||||||||||
Summary: | 0001142: Images are deleted during link approval process | ||||||||||||||
Description: |
There are 2 category permissions: * LINK.OWNER.MODIFY - changes, user makes to it's link are immediately seen on Front-End * LINK.OWNER.MODIFY.PENDING - changes, user makes to it's link are stored in another link record for admin to approve/decline When user has LINK.OWNER.MODIFY permission it works, like a charm. However, there are a problems in creating a link, that contains all changes made by user. All files are copied normally. Images are also copied on disk (e.g. image_one.jpg will be copied to image_one_1.jpg), but original image filename stays in link record. This way approving a link will delete all it's images from disk keeping broken records in Images table. Since images are copied at least, then I suppose it's working partially. Then we need to ensure, that copied image filenames are put back into Images table record associated with the link, that will hold all modifications. What to fix: ============ 1. Place approved link ResourceId into Listings db table (link enhancements) & Relationship db table (link relationships) instead of original link (link before change) ResourceId (remember ResourceId before deleting original link). 2. make sure, that copied image filenames are listed in "link to be approved" database record (instead of original link image filenames). 3. remove "_1" (or any "_[\d]+$") from approved link image filenames (when this way fixed filename won't match to any existing filename in same folder), once link was approved. |
||||||||||||||
Steps To Reproduce: | |||||||||||||||
Additional Information: | Another small problem here - such links (that needed to be approved) have broken icon in catalog. They should have Pending icon I suppose. | ||||||||||||||
Relationships |
| ||||||||||||||
Attached Files: |
link_approve_removes_wrong_images.patch (2,687) 2011-12-15 07:24 http://tracker.in-portal.org/file_download.php?file_id=1376&type=bug link_approval_core_1142.patch (1,988) 2011-12-20 11:11 http://tracker.in-portal.org/file_download.php?file_id=1392&type=bug link_approval_modules_1142.patch (2,337) 2011-12-20 11:11 http://tracker.in-portal.org/file_download.php?file_id=1393&type=bug advanced_unique_filename_check.patch (1,618) 2011-12-21 08:21 http://tracker.in-portal.org/file_download.php?file_id=1398&type=bug pending_link_approval_core_v2.patch (1,883) 2011-12-21 09:17 http://tracker.in-portal.org/file_download.php?file_id=1399&type=bug pending_link_approval_modules_v2.patch (8,765) 2011-12-21 09:17 http://tracker.in-portal.org/file_download.php?file_id=1400&type=bug |
||||||||||||||
|
|||||||||||||||
Issue History | |||||||||||||||
Date Modified | Username | Field | Change | ||||||||||||
2012-07-25 05:32 | alex | Note Added: 0005021 | |||||||||||||
2012-07-25 05:32 | alex | Status | resolved => closed | ||||||||||||
2012-07-23 08:48 | alex | Relationship added | parent of 0001369 | ||||||||||||
2011-12-21 09:21 | alex | Note Added: 0004293 | |||||||||||||
2011-12-21 09:21 | alex | Status | reviewed and tested => resolved | ||||||||||||
2011-12-21 09:21 | alex | Fixed in Version | => 5.2.0-B1 | ||||||||||||
2011-12-21 09:21 | alex | Resolution | open => fixed | ||||||||||||
2011-12-21 09:21 | alex | Assigned To | !COMMUNITY => alex | ||||||||||||
2011-12-21 09:21 | alex | Changeset attached | 5.2.x r14898 | ||||||||||||
2011-12-21 09:21 | alex | Changeset attached | 5.2.x r14897 | ||||||||||||
2011-12-21 09:20 | alex | Note Added: 0004292 | |||||||||||||
2011-12-21 09:20 | alex | Assigned To | alex => !COMMUNITY | ||||||||||||
2011-12-21 09:20 | alex | Status | needs testing => reviewed and tested | ||||||||||||
2011-12-21 09:17 | alex | File Added: pending_link_approval_modules_v2.patch | |||||||||||||
2011-12-21 09:17 | alex | File Added: pending_link_approval_core_v2.patch | |||||||||||||
2011-12-21 08:25 | alex | Changeset attached | 5.2.x r14896 | ||||||||||||
2011-12-21 08:21 | alex | File Added: advanced_unique_filename_check.patch | |||||||||||||
2011-12-20 11:12 | erik | Time Estimate Removed | 2 => | ||||||||||||
2011-12-20 11:12 | erik | Note Added: 0004285 | |||||||||||||
2011-12-20 11:12 | erik | Assigned To | erik => alex | ||||||||||||
2011-12-20 11:12 | erik | Developer | => erik | ||||||||||||
2011-12-20 11:12 | erik | Status | needs work => needs testing | ||||||||||||
2011-12-20 11:11 | erik | File Added: link_approval_modules_1142.patch | |||||||||||||
2011-12-20 11:11 | erik | File Added: link_approval_core_1142.patch | |||||||||||||
2011-12-20 02:34 | alex | Note Added: 0004279 | |||||||||||||
2011-12-18 23:33 | Dmitry | Assigned To | => erik | ||||||||||||
2011-12-18 23:33 | Dmitry | Status | active => needs work | ||||||||||||
2011-12-18 14:59 | alex | Time Estimate Added | 2 | ||||||||||||
2011-12-15 07:24 | alex | Note Added: 0004261 | |||||||||||||
2011-12-15 07:24 | alex | File Added: link_approve_removes_wrong_images.patch | |||||||||||||
2011-12-15 07:23 | alex | Estimate Points | => 2 | ||||||||||||
2011-12-15 07:23 | alex | Target Version | 5.1.4 => 5.2.0 | ||||||||||||
2011-10-17 05:05 | alex | Reporter | alex => phil | ||||||||||||
2011-10-17 05:05 | alex | New Issue | |||||||||||||
2011-10-17 05:05 | alex | Reference | => https://groups.google.com/d/topic/in-portal-bugs/yzlo09tGZ7k/discussion | ||||||||||||
2011-10-17 05:05 | alex | Change Log Message | => Fixed image delete on link approve (when LINK.OWNER.MODIFY.PENDING permission was used) |
Notes | |||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|