In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
1118 [In-Portal CMS] Admin Interfaces feature request always 2011-09-11 21:55 2012-07-25 05:33
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.3-RC2  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B1  
Reference: https://groups.google.com/d/topic/in-portal-dev/I2dPIyWzP3M/discussion
Change Log Message: Added "updated message" on saving configuration settings in Admin
Estimate Points: 1
Summary: 0001118: Show "saved message" on Saving Configuration Settings in Admin
Description: In-Portal has a set of pages, where it's configuration settings can be changed. But page simply refreshes when user hits Save button.

Proposes to show "Your changes were successfully saved!" somewhere at this page after Save button was pressed.


Same on "System Tools" section too.

Use "Last operation has been successfully completed!" for System Tools
Steps To Reproduce:
Additional Information:
Relationships
parent of 0001383resolved  (5.2.1)alex Incorrect setting page saving detection 
Attached Files: patch save_config_message_1118.patch (9,330) 2011-09-29 02:00
http://tracker.in-portal.org/file_download.php?file_id=1164&type=bug
patch save_config_message_1118.2.patch (45,978) 2011-10-04 09:20
http://tracker.in-portal.org/file_download.php?file_id=1201&type=bug
patch config_save_notice_v3.patch (46,888) 2011-10-05 08:21
http://tracker.in-portal.org/file_download.php?file_id=1212&type=bug
Issue History
Date Modified Username Field Change
2012-08-20 12:17 alex Relationship added parent of 0001383
2012-07-25 05:33 alex Note Added: 0005104
2012-07-25 05:33 alex Status resolved => closed
2011-10-22 05:31 alex Estimate Points => 1
2011-10-05 08:22 alex Note Added: 0004020
2011-10-05 08:22 alex Status reviewed and tested => resolved
2011-10-05 08:22 alex Fixed in Version => 5.2.0-B1
2011-10-05 08:22 alex Resolution open => fixed
2011-10-05 08:22 alex Assigned To !COMMUNITY => alex
2011-10-05 08:22 alex Changeset attached 5.2.x r14637
2011-10-05 08:22 alex Note Added: 0004019
2011-10-05 08:22 alex Assigned To alex => !COMMUNITY
2011-10-05 08:22 alex Status needs testing => reviewed and tested
2011-10-05 08:21 alex File Added: config_save_notice_v3.patch
2011-10-04 09:20 erik Note Added: 0004001
2011-10-04 09:20 erik Assigned To erik => alex
2011-10-04 09:20 erik Status needs work => needs testing
2011-10-04 09:20 erik File Added: save_config_message_1118.2.patch
2011-10-03 12:33 alex Note Added: 0003981
2011-10-03 12:33 alex Assigned To alex => erik
2011-10-03 12:33 alex Status needs testing => needs work
2011-09-29 02:00 erik File Added: save_config_message_1118.patch
2011-09-29 02:00 erik File Deleted: save_config_message_1118.patch
2011-09-28 10:40 erik Time Estimate Removed 1 =>
2011-09-28 10:40 erik Note Added: 0003934
2011-09-28 10:40 erik Assigned To erik => alex
2011-09-28 10:40 erik Developer => erik
2011-09-28 10:40 erik Status needs work => needs testing
2011-09-28 10:40 erik File Added: save_config_message_1118.patch
2011-09-28 09:53 Dmitry Description Updated bug_revision_view_page.php?rev_id=854#r854
2011-09-28 09:21 erik File Deleted: save_config_message_1118.patch
2011-09-28 09:21 erik File Added: save_config_message_1118.patch
2011-09-26 08:26 Dmitry Assigned To => erik
2011-09-26 08:26 Dmitry Status active => needs work
2011-09-26 05:00 alex Time Estimate Added 1
2011-09-12 12:34 alex Reporter Dmitry => alex
2011-09-11 21:55 Dmitry New Issue
2011-09-11 21:55 Dmitry Reference => https://groups.google.com/d/topic/in-portal-dev/I2dPIyWzP3M/discussion
2011-09-11 21:55 Dmitry Change Log Message => Added "updated message" on saving configuration settings in Admin

Notes
(0003934)
erik   
2011-09-28 10:40   
Patch attached - needs testing
(0003981)
alex   
2011-10-03 12:33   
1. It's not efficient solution to create small "config_updated_notice.tpl" file and include it in other files. For this task you should have created DefineElement into "config_blocks.tpl" file, that is included in needed places anyway and use RenderElement tag to show it.

2. In "config_updated_notice.tpl" file there is no need to use pass_params parameter, since there are no parameters passed to "config_updated_notice.tpl" template, that are needed to be passed into "form_message" design block.

3. Tag m_ParamEquals is deprecated. You should use "equals_to" parameter with check="m_Param" attribute instead. Actually you can simply check:
<inp2:m_if check="m_Param" name="is_warning"> ... </inp2:m_if>
This approach is widely used across "core" In-Portal code.

4. You've changed "style_template.css" but there is nor updated skin version in install_data.sql file neither patch in upgrades.css file.
Please:
- put "style_template.css" contents into your current skin (except top comment) - export record from Skins table into install_data.sql file (keep DEFAULT instead of skins id)
- use "Create Patch ..." command of TortoiseSVN to create patch from "style_template.css" file
- place content of the patch under proper version in "upgrades.css" file
- keep empty line at the end of the file
- test upgrade from previous In-Portal version and verify, that primary skin is really updated with your new CSS style

5. Why there is check for "system_tools" template name. If possible, then just add:
$event->SetRedirectParam('action_completed') or similar at the end of needed events and check it in template using <inp2:m_if check="m_Get" name="action_completed"> ... </inp2:m_if> construct.
(0004001)
erik   
2011-10-04 09:20   
save_config_message_1118.2.patch attached - needs testing
(0004019)
alex   
2011-10-05 08:22   
Tested, but few things that were fixed:
1. Patch added to "upgrades.css" should combine all skin css file changes aross 5.2.0-B1 version.
2. Session variable name changed from "conf_was_updated" to "config_was_updated".
3. Design "form_message" parameter is_warning="1/0" replaced to type="warning/notice".
4. Notice message color changed from black to green.

Also added fixes (not related to this task, but too small to create new one):
1. debugger reports were not deleted when "Clear Template Cache" button was clicked
2. there were several warning message during template cache delete, when folders without PHP files were processed
(0004020)
alex   
2011-10-05 08:22   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001118: Show "saved message" on Saving Configuration Settings in Admin
Commit on behalf of Erik
(0005104)
alex   
2012-07-25 05:33   
Since 5.2.0 version was released.