In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
1108 [In-Portal CMS] Admin Interfaces bug report always 2011-08-24 03:41 2012-07-25 05:32
Reporter: phil Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.3-RC2  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B1  
Reference: https://groups.google.com/d/topic/in-portal-bugs/U7tgCKfPEqI/discussion
Change Log Message: Fixed all data lost of symlink category selection on category adding form
Estimate Points: 1
Summary: 0001108: Selecting "Symlink Category" resets all category adding form fields
Description: When creating a new category, if you try to setup a symlink, page reloads with all fields emptied. If you create the page, save it, then edit it and setup a symlink, it works.

Way of fixing:
Add ability to submit category(-ies)/category item(-s) selected in item selector to parent window using ajax
Steps To Reproduce:
Additional Information:
Relationships
Attached Files: patch symlink_category_1108.patch (6,837) 2011-12-19 13:17
http://tracker.in-portal.org/file_download.php?file_id=1385&type=bug
patch symlink_category_1108.2.patch (3,703) 2011-12-21 06:44
http://tracker.in-portal.org/file_download.php?file_id=1397&type=bug
? category_path.tpl (342) 2011-12-23 11:42
http://tracker.in-portal.org/file_download.php?file_id=1407&type=bug
patch symlink_category_v3.patch (5,774) 2011-12-27 04:45
http://tracker.in-portal.org/file_download.php?file_id=1411&type=bug
png SymlinkJSError.png (232,487) 2011-12-27 10:03
http://tracker.in-portal.org/file_download.php?file_id=1417&type=bug
png

patch unit_prefix_bug_fix.patch (1,018) 2011-12-28 04:59
http://tracker.in-portal.org/file_download.php?file_id=1421&type=bug
Issue History
Date Modified Username Field Change
2012-07-25 05:32 alex Note Added: 0005016
2012-07-25 05:32 alex Status resolved => closed
2011-12-28 12:10 alex Note Added: 0004340
2011-12-28 12:10 alex Status reviewed and tested => resolved
2011-12-28 12:10 alex Resolution reopened => fixed
2011-12-28 12:10 alex Assigned To !COMMUNITY => alex
2011-12-28 12:10 alex Changeset attached 5.2.x r14936
2011-12-28 12:09 alex Assigned To alex => !COMMUNITY
2011-12-28 12:09 alex Status needs testing => reviewed and tested
2011-12-28 05:00 erik Note Added: 0004332
2011-12-28 05:00 erik Assigned To erik => alex
2011-12-28 05:00 erik Status needs work => needs testing
2011-12-28 04:59 erik File Added: unit_prefix_bug_fix.patch
2011-12-28 02:40 alex Note Added: 0004331
2011-12-27 10:03 Dmitry File Added: SymlinkJSError.png
2011-12-27 10:02 Dmitry Status needs feedback => needs work
2011-12-27 10:02 Dmitry Assigned To alex => erik
2011-12-27 10:02 Dmitry Note Added: 0004328
2011-12-27 10:02 Dmitry Status resolved => needs feedback
2011-12-27 10:02 Dmitry Resolution fixed => reopened
2011-12-27 04:47 alex Note Added: 0004320
2011-12-27 04:47 alex Status reviewed and tested => resolved
2011-12-27 04:47 alex Fixed in Version => 5.2.0-B1
2011-12-27 04:47 alex Resolution open => fixed
2011-12-27 04:47 alex Assigned To !COMMUNITY => alex
2011-12-27 04:47 alex Changeset attached 5.2.x r14916
2011-12-27 04:47 alex Note Edited: 0004319 bug_revision_view_page.php?bugnote_id=0004319#r942
2011-12-27 04:46 alex Note Added: 0004319
2011-12-27 04:46 alex Assigned To alex => !COMMUNITY
2011-12-27 04:46 alex Status needs testing => reviewed and tested
2011-12-27 04:45 alex File Added: symlink_category_v3.patch
2011-12-23 11:43 erik Note Added: 0004310
2011-12-23 11:43 erik Assigned To erik => alex
2011-12-23 11:43 erik Status needs work => needs testing
2011-12-23 11:42 erik File Added: category_path.tpl
2011-12-23 04:43 alex Note Added: 0004302
2011-12-23 04:43 alex Assigned To alex => erik
2011-12-23 04:43 alex Status needs testing => needs work
2011-12-21 06:45 erik Note Added: 0004291
2011-12-21 06:45 erik Assigned To erik => alex
2011-12-21 06:45 erik Status needs work => needs testing
2011-12-21 06:44 erik File Added: symlink_category_1108.2.patch
2011-12-20 03:33 alex Note Added: 0004280
2011-12-20 03:33 alex Assigned To alex => erik
2011-12-20 03:33 alex Status needs testing => needs work
2011-12-19 13:17 erik File Added: symlink_category_1108.patch
2011-12-19 13:17 erik File Deleted: symlink_category_1108.patch
2011-12-19 10:14 erik Note Added: 0004278
2011-12-19 10:14 erik Assigned To erik => alex
2011-12-19 10:14 erik Developer => erik
2011-12-19 10:14 erik Status needs work => needs testing
2011-12-19 10:13 erik File Added: symlink_category_1108.patch
2011-12-18 14:59 alex Estimate Points 0 => 1
2011-12-15 17:27 Dmitry Estimate Points => 0
2011-12-15 17:27 Dmitry Note Added: 0004265
2011-12-15 17:27 Dmitry Assigned To => erik
2011-12-15 17:27 Dmitry Status active => needs work
2011-12-15 17:27 Dmitry Target Version Icebox => 5.2.0
2011-08-24 03:41 alex Reporter alex => phil
2011-08-24 03:41 alex New Issue
2011-08-24 03:41 alex Reference => https://groups.google.com/d/topic/in-portal-bugs/U7tgCKfPEqI/discussion
2011-08-24 03:41 alex Change Log Message => Fixed all data lost of symlink category selection on category adding form

Notes
(0004265)
Dmitry   
2011-12-15 17:27   
Consult with Alex on the implementation of this task.
(0004278)
erik   
2011-12-19 10:14   
Patch attached - needs testing
(0004280)
alex   
2011-12-20 03:33   
Works, but implementation is wrong:

1. should be done, like with user selector:
- check if processItemSelector function exists in a parent window
- if so, then call it passing dst_field & selector window
- create processItemSelector function in "inp_edit_category" block, that will do ajax query (using jQuery) to a TPL that would return category path
- just include intermediate template in "inp_edit_category" block instead of making ajax query on first page load (bad style), since jumping effect is visible otherwise
- can use intermediate event (if needed) to transform "selected_ids" into a form, that is understandable by CategoryPath tag, you've used
(0004291)
erik   
2011-12-21 06:45   
Made changes in implementation. New patch symlink_category_1108.2.patch attached - needs testing.
(0004302)
alex   
2011-12-23 04:43   
File "category_path.tpl" is missing in 2nd patch and I don't if it was changed since first patch. Please add missing files.

Please verify that all needed changes are in the patch after creating it and before sending it to testing.
(0004310)
erik   
2011-12-23 11:43   
category_path.tpl was not changed. File attached - needs testing
(0004319)
alex   
2011-12-27 04:46   
(edited on: 2011-12-27 04:47)
Works, but technically method CategorySelector.getField could have been used to get desired $field_id instead of duplicating it's code in processItemSelector method.

Also passing parameter directly to "category_path" template is more preferable, then setting global variable.
(0004320)
alex   
2011-12-27 04:47   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001108: Selecting "Symlink Category" resets all category adding form fields
(0004328)
Dmitry   
2011-12-27 10:02   
There is a JS error when trying to select a Section in Show All mode (see attached file)
(0004331)
alex   
2011-12-28 02:40   
Before this patch event "c:OnProcessSelected" was called. Within it "selected_ids" represented IDs of category, that was selected.

If you look closed on the JS code, that called "c:OnProcessSelected" event (which you changed), then you'll notice, that actual IDs were retrieved using Grids[$Catalog.ActivePrefix].GetSelected() method.

This way instead of specifying "c" directly (as unit prefix) you will use $opener.$Catalog.ActivePrefix instead.
(0004332)
erik   
2011-12-28 05:00   
unit_prefix_bug_fix.patch attached - needs testing
(0004340)
alex   
2011-12-28 12:10   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001108: Selecting "Symlink Category" resets all category adding form fields
1. "Show All" mode generated JavaScript error
(0005016)
alex   
2012-07-25 05:32   
Since 5.2.0 version was released.