In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1098 [In-Portal CMS] Data Management bug report always 2011-08-17 03:54 2011-09-19 16:08
alex  
alex  
normal  
closed 5.1.3-RC2  
fixed  
 
none 5.1.3  
https://groups.google.com/d/topic/in-portal-bugs/_WQy9S6_5H8/discussion
Fixes useless parameter being passed to page editing page
0
0001098: Parameters "editing_mode" and "admin" are passed to page editing form by mistake
In-Portal uses two parameters in url to identify:

* currently used site browse mode (browse/content/design) - "editing_mode" parameter
* regular user or administrator is viewing the site - "admin" parameter

When administrator uses "Section Properties" button to edit currently viewed page in one of a browse modes, then these parameters are passed along to it.
As a result all link built on that "editing page" will have "editing_mode" and "admin" parameters present.

This has even more dramatic effect, when 0001050 (in 5.2.0) is applied, since they are added to generated direct link too and admin will see different link.
child of 0001050closed  (5.2.0)!COMMUNITY Ability to access Disabled Section with Direct Link 
patch keep_section_properties_link_clean.patch (576) 2011-08-17 03:54
http://tracker.in-portal.org/file_download.php?file_id=1102&type=bug
Issue History
2011-09-19 16:08 alex Note Added: 0003790
2011-09-19 16:08 alex Status resolved => closed
2011-08-24 02:55 alex Changeset attached 5.1.x r14511
2011-08-24 02:55 alex Note Added: 0003696
2011-08-24 02:55 alex Status reviewed and tested => resolved
2011-08-24 02:55 alex Fixed in Version => 5.1.3
2011-08-24 02:55 alex Resolution open => fixed
2011-08-24 02:55 alex Assigned To !COMMUNITY => alex
2011-08-20 15:54 Dmitry Note Added: 0003671
2011-08-20 15:54 Dmitry Status needs testing => reviewed and tested
2011-08-17 03:56 alex Assigned To => !COMMUNITY
2011-08-17 03:56 alex Developer => alex
2011-08-17 03:56 alex Status active => needs testing
2011-08-17 03:56 alex Reference => https://groups.google.com/d/topic/in-portal-bugs/_WQy9S6_5H8/discussion
2011-08-17 03:55 alex Relationship added child of 0001050
2011-08-17 03:54 alex New Issue
2011-08-17 03:54 alex File Added: keep_section_properties_link_clean.patch
2011-08-17 03:54 alex Change Log Message => Fixes useless parameter being passed to page editing page

Notes
(0003671)
Dmitry   
2011-08-20 15:54   
Reviewed and tested okay, please commit!
(0003696)
alex   
2011-08-24 02:55   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0001098: Parameters "editing_mode" and "admin" are passed to page editing form by mistake
(0003790)
alex   
2011-09-19 16:08   
Closing, since 5.1.3 release has been released.