In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1095 [In-Portal CMS] Front End bug report always 2011-08-10 05:03 2011-09-19 16:08
alex  
alex  
normal  
closed 5.1.2  
fixed  
 
none 5.1.3-RC2  
https://groups.google.com/d/topic/in-portal-dev/Zy0nJf-0Y44/discussion
Fixed error mixup from different forms in "advanced" theme
0
0001095: Error messages are displayed on unrelated forms
I've noticed, that these forms:
* login sidebox
* subscribe to mailing sidebox
* recommend site sidebox
* forgot password page

share same user object for data validation and processing.

Because of it if error happens on one of this forms, then it will be shown on other fields, e.g. error on "Forgot Password" form in Email field is displayed on "Recommend Site" sidebox.


I'm proposing to assign "special" to each of sideboxes so data don't get mixed, like <inp2:u.login .../> ; <inp2:u.subscriber .../> and <inp2:u.recommend .../>

After that error will be raised, that there is no ID in request for mentioned above Specials. Then we need to change UsersEventHandler::getPassedID method to return current GUEST user's ID for these specials.
Not obvious things, that were changed:

1. Unique field names were used on all forms, so instead of Email field being used everywhere now RecommendEmail, ForgotEmail, e.t.c. are used. This will help, when forms will be converted to AJAX approach using FormManager class.
related to 0000948closed  (5.2.0)alex Change in "Forgot Password" logic 
related to 0000271closed  (5.2.0)alex Redesign "Data Validation" Engine 
related to 0001031closed  (5.2.0)alex User management internals refactoring 
parent of 0001114closed  (5.1.3)alex Installation fails after "Select Modules" step 
parent of 0001237closed  (5.2.0)alex Cursor isn't focused on username field on admin login form 
patch sidebox_mix_errors_fix_core.patch (15,210) 2011-08-10 05:04
http://tracker.in-portal.org/file_download.php?file_id=1098&type=bug
patch sidebox_mix_errors_fix_themes.patch (7,462) 2011-08-10 05:04
http://tracker.in-portal.org/file_download.php?file_id=1099&type=bug
Issue History
2012-03-30 05:00 alex Relationship added parent of 0001237
2011-09-20 11:22 alex Relationship added related to 0001116
2011-09-19 16:08 alex Note Added: 0003797
2011-09-19 16:08 alex Status resolved => closed
2011-08-27 05:40 alex Relationship added parent of 0001114
2011-08-13 02:37 alex Changeset attached 5.2.x r14503
2011-08-13 02:12 alex Changeset attached 5.2.x r14502
2011-08-13 01:42 alex Changeset attached 1.2.x r14501
2011-08-13 00:49 alex Changeset attached 5.1.x r14489
2011-08-13 00:49 alex Note Added: 0003670
2011-08-13 00:49 alex Status reviewed and tested => resolved
2011-08-13 00:49 alex Fixed in Version => 5.1.3-RC2
2011-08-13 00:49 alex Resolution open => fixed
2011-08-13 00:49 alex Assigned To !COMMUNITY => alex
2011-08-13 00:46 alex Changeset attached 1.1.x r14488
2011-08-11 23:31 Dmitry Note Added: 0003653
2011-08-11 23:31 Dmitry Status needs testing => reviewed and tested
2011-08-10 05:14 alex Issue Monitored: alex
2011-08-10 05:14 alex Note Added: 0003652
2011-08-10 05:14 alex Assigned To => !COMMUNITY
2011-08-10 05:14 alex Developer => alex
2011-08-10 05:14 alex Status active => needs testing
2011-08-10 05:12 alex Note Edited: 0003651 bug_revision_view_page.php?bugnote_id=0003651#r796
2011-08-10 05:11 alex Relationship added related to 0001031
2011-08-10 05:09 alex Note Edited: 0003651 bug_revision_view_page.php?bugnote_id=0003651#r795
2011-08-10 05:08 alex Relationship added related to 0000271
2011-08-10 05:06 alex Additional Information Updated bug_revision_view_page.php?rev_id=793#r793
2011-08-10 05:04 alex File Added: sidebox_mix_errors_fix_themes.patch
2011-08-10 05:04 alex File Added: sidebox_mix_errors_fix_core.patch
2011-08-10 05:04 alex Note Added: 0003651
2011-08-10 05:03 alex Relationship added related to 0000948
2011-08-10 05:03 alex New Issue
2011-08-10 05:03 alex Reference => https://groups.google.com/d/topic/in-portal-dev/Zy0nJf-0Y44/discussion
2011-08-10 05:03 alex Change Log Message => Fixed error mixup from different forms in "advanced" theme

Notes
(0003651)
alex   
2011-08-10 05:04   
(edited on: 2011-08-10 05:12)
1. This and 0000948 task both changed u:OnForgotPassword event. Need to be careful, when merging to 5.2.x.
2. In 0000271 task user registration process is refactored a lot and because of it user registration form wasn't changed here.
3. Subscribe sidebox wasn't changed here, because it (and associated code) was heavily refactored in 0001031 task.

(0003652)
alex   
2011-08-10 05:14   
This task is needed on 5.1.3 release, since without it all mentioned in it forms won't be working with FormManager class.

TODO: need to merge with 5.2.x after testing.
(0003653)
Dmitry   
2011-08-11 23:31   
Tested okay.
(0003670)
alex   
2011-08-13 00:49   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0001095: Error messages are displayed on unrelated forms
(0003797)
alex   
2011-09-19 16:08   
Closing, since 5.1.3 release has been released.