In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
1024 [In-Portal CMS] Admin Interfaces feature request N/A 2011-03-13 11:31 2012-07-25 05:32
Reporter: alex Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.1.2-B2  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.2.0-B1  
Reference: https://groups.google.com/d/topic/in-portal-dev/weaGVIhGHvY/discussion
Change Log Message: Simplified phrase adding screen
Estimate Points: 2
Summary: 0001024: Phrase type detection based on it's name
Description: On phrase adding screen you need to enter:
* phrase label;
* phrase translation;
* phrase type.

However phrase type can be automatically guessed based on phrase label prefix:
* lu_ - Front-end;
* la_ - Administrative Console;
* lc_ (NEW) - Can be used on both Front-end and Administrative Console.
Steps To Reproduce:
Additional Information: Plan:

1. add new "lc_" phrase label prefix (to phrase name validate regex);
2. remove "Phrase Type" field from phrase form;
3. set phrase type automatically based on phrase label prefix;
4. change prefix (and type) for phrases, that can be used in both places (e.g. field option phrases for sure).
5. create fixed language pack + upgrade script that will rename Phrase & PhraseKey columns during an upgrade.
Relationships
related to 0001094closed  (5.1.3)alex Optimizing storage of help phrases 
related to 0000493closed  (5.2.0)alex Redirect template (kEvent::redirect attribute) has no effect, when popups are used 
Attached Files: patch phrase_type_1024.patch (2,739) 2011-10-31 11:42
http://tracker.in-portal.org/file_download.php?file_id=1276&type=bug
patch phrase_type_detection_core.patch (43,006) 2011-11-08 03:42
http://tracker.in-portal.org/file_download.php?file_id=1304&type=bug
patch phrase_type_detection_modules.patch (46,515) 2011-11-08 03:42
http://tracker.in-portal.org/file_download.php?file_id=1305&type=bug
patch phrase_type_detection_themes.patch (7,402) 2011-11-08 03:42
http://tracker.in-portal.org/file_download.php?file_id=1306&type=bug
patch wrong_phrase_name_fix.patch (982) 2011-11-11 04:59
http://tracker.in-portal.org/file_download.php?file_id=1316&type=bug
patch phrase_type_autodetect_missing_fix.patch (2,031) 2011-11-23 09:00
http://tracker.in-portal.org/file_download.php?file_id=1329&type=bug
Issue History
Date Modified Username Field Change
2012-07-25 05:32 alex Note Added: 0005049
2012-07-25 05:32 alex Status resolved => closed
2011-11-23 09:01 alex Changeset attached 5.2.x r14791
2011-11-23 09:01 alex Note Added: 0004170
2011-11-23 09:00 alex File Added: phrase_type_autodetect_missing_fix.patch
2011-11-11 05:01 alex Changeset attached 5.2.x r14761
2011-11-11 05:01 alex Note Added: 0004155
2011-11-11 04:59 alex File Added: wrong_phrase_name_fix.patch
2011-11-08 03:50 alex Changeset attached 5.2.x r14745
2011-11-08 03:50 alex Note Added: 0004143
2011-11-08 03:50 alex Status reviewed and tested => resolved
2011-11-08 03:50 alex Fixed in Version => 5.2.0-B1
2011-11-08 03:50 alex Resolution open => fixed
2011-11-08 03:50 alex Assigned To !COMMUNITY => alex
2011-11-08 03:49 alex Changeset attached 5.2.x r14744
2011-11-08 03:49 alex Changeset attached 5.2.x r14743
2011-11-08 03:45 alex Changeset attached 5.2.x r14742
2011-11-08 03:45 alex Changeset attached 5.2.x r14741
2011-11-08 03:44 alex Changeset attached 1.2.x r14740
2011-11-08 03:43 alex Note Added: 0004142
2011-11-08 03:43 alex Status needs testing => reviewed and tested
2011-11-08 03:43 alex Note Added: 0004141
2011-11-08 03:43 alex Assigned To alex => !COMMUNITY
2011-11-08 03:43 alex Developer erik => alex
2011-11-08 03:43 alex Status needs work => needs testing
2011-11-08 03:42 alex File Added: phrase_type_detection_themes.patch
2011-11-08 03:42 alex File Added: phrase_type_detection_modules.patch
2011-11-08 03:42 alex File Added: phrase_type_detection_core.patch
2011-11-04 13:06 alex Relationship added related to 0000493
2011-11-02 22:48 Dmitry Note Added: 0004123
2011-11-02 22:48 Dmitry Assigned To erik => alex
2011-11-01 08:34 alex Note Edited: 0004108 bug_revision_view_page.php?bugnote_id=0004108#r896
2011-11-01 08:26 Dmitry Assigned To alex => erik
2011-11-01 08:26 Dmitry Status needs testing => needs work
2011-11-01 05:43 alex Note Added: 0004108
2011-10-31 11:43 erik Time Estimate Removed 2 =>
2011-10-31 11:43 erik Note Added: 0004104
2011-10-31 11:43 erik Assigned To erik => alex
2011-10-31 11:43 erik Developer => erik
2011-10-31 11:43 erik Status needs work => needs testing
2011-10-31 11:42 erik File Added: phrase_type_1024.patch
2011-10-31 03:11 alex Description Updated bug_revision_view_page.php?rev_id=892#r892
2011-10-31 03:11 alex Additional Information Updated bug_revision_view_page.php?rev_id=894#r894
2011-10-22 05:24 alex Estimate Points => 2
2011-10-21 09:09 Dmitry Assigned To => erik
2011-10-21 09:09 Dmitry Status active => needs work
2011-09-26 04:54 alex Time Estimate Added 2
2011-09-23 20:40 Dmitry Target Version Icebox => 5.2.0
2011-09-02 03:11 alex Relationship added related to 0001094
2011-03-13 11:31 alex New Issue
2011-03-13 11:31 alex Reference => https://groups.google.com/d/topic/in-portal-dev/weaGVIhGHvY/discussion
2011-03-13 11:31 alex Change Log Message => Simplified phrase adding screen

Notes
(0004104)
erik   
2011-10-31 11:43   
Patch attached for 1,2,3 subtasks - needs testing
(0004108)
alex   
2011-11-01 05:43   
(edited on: 2011-11-01 08:34)
Upon applying changing phrase of "Both" type translation will result it's type change to "Admin".

That's why we need to rename all phrases of Both type to have "lc_" prefix instead "la_" or "lu_". We also need to rename all places, where affected phrases are used.
(0004123)
Dmitry   
2011-11-02 22:48   
Alex, would you please take it from here and finish this task?
(0004141)
alex   
2011-11-08 03:43   
Replacing phrases across the code took very long time, so keep this in mind before next phrase renaming attempt.
(0004142)
alex   
2011-11-08 03:43   
Will test all together later.
(0004143)
alex   
2011-11-08 03:50   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001024: Phrase type detection based on it's name
(0004155)
alex   
2011-11-11 05:01   
Patch "wrong_phrase_name_fix.patch" fixes mistakenly renamed "la_PhraseType_Both" phrase.
(0004170)
alex   
2011-11-23 09:01   
Patch "phrase_type_autodetect_missing_fix.patch" fixes phrase type of "la_PhraseType_Both" phrase & phrase name of "lc_Text_Valid" phrase.
(0005049)
alex   
2012-07-25 05:32   
Since 5.2.0 version was released.