|
In-Portal Issue Tracker - In-Commerce
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
1013 |
[In-Portal CMS] Data Management |
bug report |
always |
2011-03-13 04:58 |
2011-09-19 16:08 |
|
|
Reporter:
|
alex |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
closed |
Product Version:
|
5.1.2-B2 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.1.3-B1 |
|
|
Reference:
|
https://groups.google.com/d/topic/in-portal-bugs/2kp2ZNSX0oU/discussion |
|
Change Log Message:
|
Fixed duplicate order numbers being assigned |
|
Estimate Points:
|
0 |
|
|
Summary:
|
0001013: New order number generator returns duplicate numbers |
|
Description:
|
When new order is created, then new number (not id) is automatically generated and assigned to it.
Also there is a configuration variable in In-Commerce, that stores last generated order number, that doesn't work actually (tested on 5.1.2-B2).
Since special configuration variable isn't used, then last order number from database plus 1 is assigned to each new order. That doesn't pose any problems on Front-end, since every Front-end customer will use the same Orders table.
However it poses a serious problem to Admin Console. When admin opens new order creation page, then a number is generated and assigned to it. But the order record is created in a temporary table and that's why order number generator returns the SAME order number in case if 2 admins will open new order creation page in Admin Console.
Who saves his order first wins. And other admin will get "duplicate order number" message and is stuck with inability to save an order. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
| Relationships | | parent of | 0001016 | closed (5.1.3) | alex | In-Portal CMS | Method for setting configuration values (auto resets cache too) |
|
|
Attached Files:
|
 async_order_number_generation_support.patch (2,781) 2011-03-13 04:59
http://tracker.in-portal.org/file_download.php?file_id=962&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2011-09-19 16:08 |
alex |
Note Added: 0003837 |
|
|
2011-09-19 16:08 |
alex |
Status |
resolved => closed |
|
2011-06-01 03:01 |
alex |
Changeset attached |
5.1.x r14362 |
|
2011-06-01 03:01 |
alex |
Note Added: 0003517 |
|
|
2011-06-01 03:01 |
alex |
Status |
reviewed and tested => resolved |
|
2011-06-01 03:01 |
alex |
Fixed in Version |
=> 5.1.3-B1 |
|
2011-06-01 03:01 |
alex |
Resolution |
open => fixed |
|
2011-05-23 08:05 |
Dmitry |
Note Added: 0003498 |
|
|
2011-05-23 08:05 |
Dmitry |
Assigned To |
Dmitry => alex |
|
2011-05-23 08:05 |
Dmitry |
Status |
needs testing => reviewed and tested |
|
2011-05-23 02:26 |
alex |
Note Added: 0003478 |
|
|
2011-05-23 02:26 |
alex |
Assigned To |
alex => Dmitry |
|
2011-05-23 02:26 |
alex |
Status |
needs work => needs testing |
|
2011-05-23 02:25 |
alex |
Note Edited: 0003468 |
bug_revision_view_page.php?bugnote_id=0003468#r713 |
|
2011-05-22 22:23 |
Dmitry |
Note Added: 0003468 |
|
|
2011-05-22 22:23 |
Dmitry |
Assigned To |
Dmitry => alex |
|
2011-05-22 22:23 |
Dmitry |
Status |
needs testing => needs work |
|
2011-04-04 11:49 |
Dmitry |
Target Version |
Icebox => 5.1.3 |
|
2011-03-13 18:31 |
Dmitry |
Relationship added |
parent of 0001016 |
|
2011-03-13 05:47 |
alex |
Assigned To |
=> Dmitry |
|
2011-03-13 05:47 |
alex |
Developer |
=> alex |
|
2011-03-13 05:47 |
alex |
Status |
active => needs testing |
|
2011-03-13 05:25 |
alex |
Reference |
=> https://groups.google.com/d/topic/in-portal-bugs/2kp2ZNSX0oU/discussion |
|
2011-03-13 04:59 |
alex |
File Added: async_order_number_generation_support.patch |
|
|
2011-03-13 04:58 |
alex |
New Issue |
|
|
2011-03-13 04:58 |
alex |
Change Log Message |
=> Fixed duplicate order numbers being assigned |
|
Notes |
|
|
(0003468)
|
|
Dmitry
|
2011-05-22 22:23
(edited on: 2011-05-23 02:25) |
|
Looks like we are missing "SetConfigValue" method in this patch. Please review and update patch.
|
|
|
|
(0003478)
|
|
alex
|
|
2011-05-23 02:26
|
|
I specially created 2 tasks/patches instead of 1, since SetConfigValue method is a separate functionality, but it's used by this task.
To test both tasks (this and related) apply SetConfigValue patch and this patch together. |
|
|
|
(0003498)
|
|
Dmitry
|
|
2011-05-23 08:05
|
|
|
Tested good, please commit. |
|
|
|
(0003517)
|
|
alex
|
|
2011-06-01 03:01
|
|
Fix committed to 5.1.x branch. Commit Message:
Fixes 0001013: New order number generator returns duplicate numbers |
|
|
|
(0003837)
|
|
alex
|
|
2011-09-19 16:08
|
|
|
Closing, since 5.1.3 release has been released. |
|