In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
101 [In-Portal CMS] Data Management bug report always 2009-06-23 18:29 2009-10-03 07:56
Reporter: Dmitry Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 5.0.0  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.0.1  
Reference:
Change Log Message:
Estimate Points: 0
Summary: 0000101: Preventing Category "Copy/Paste" from Recursion
Description: In case if Category Copy/Paste operation is done in itself it can result lots if nested categories (until PHP runs out of memory) and will lead to loosing data integrity.

Proposing to check with JS (or other ways) for possible recursion before process takes place.
Steps To Reproduce:
Additional Information:
Relationships
Attached Files:
Issue History
Date Modified Username Field Change
2009-10-03 07:56 administrator Note Added: 0000701
2009-10-03 07:56 administrator Status resolved => closed
2009-10-03 07:41 administrator Priority critical => normal
2009-10-03 07:31 administrator Type @60@ => bug report
2009-08-05 05:26 alex Fixed in Version => 5.0.1
2009-08-05 05:25 alex Note Added: 0000247
2009-08-05 05:25 alex Status reviewed and tested => resolved
2009-08-05 05:25 alex Resolution open => fixed
2009-08-05 05:25 alex Changeset attached 5.0.x r12196
2009-08-04 19:15 Dmitry Priority normal => critical
2009-08-04 15:41 alex Note Edited: 0000235 bug_revision_view_page.php?bugnote_id=0000235#r131
2009-08-04 15:41 alex Note Edited: 0000235 bug_revision_view_page.php?bugnote_id=0000235#r130
2009-08-04 15:40 alex Note Added: 0000237
2009-08-04 12:13 Dmitry Assigned To Dmitry => alex
2009-08-04 12:13 Dmitry Status needs work => reviewed and tested
2009-08-04 12:13 Dmitry Category Admin Interfaces => Data Management
2009-08-04 12:13 Dmitry Status needs feedback => needs work
2009-08-04 12:11 Dmitry Note Added: 0000235
2009-06-24 06:18 alex Note Added: 0000106
2009-06-24 06:18 alex Assigned To => Dmitry
2009-06-24 06:18 alex Status active => needs feedback
2009-06-23 18:29 Dmitry New Issue

Notes
(0000106)
alex   
2009-06-24 06:18   
I think that it remembers contents in current category that need coping/pasting and then performs operation. If it works as I've described, then newly created categories (during pasting process) should be automatically pasted again. Please check how this works in previous release, because we haven't changed copy/paste mechanism for quite some time.
(0000235)
Dmitry   
2009-08-04 12:11   
(edited on: 2009-08-04 15:41)
I was able to repeat this in my 5.0.1. below is copy of PHP Fatal error:

 INSERT INTO Category (`CategoryId`, `Type`, `SymLinkCategoryId`, `ParentId`, `Filename`, `AutomaticFilename`, `CreatedOn`, `EditorsPick`, `Status`, `Priority`, `MetaKeywords`, `CachedDescendantCatsQty`, `CreatedById`, `ResourceId`, `ParentPath`, `TreeLeft`, `TreeRight`, `NamedParentPath`, `MetaDescription`, `HotItem`, `NewItem`, `PopItem`, `Modified`, `ModifiedById`, `CachedTemplate`, `Template`, `UseExternalUrl`, `ExternalUrl`, `UseMenuIconUrl`, `MenuIconUrl`, `MetaTitle`, `IndexTools`, `IsIndex`, `IsMenu`, `IsSystem`, `FormId`, `FormSubmittedTemplate`, `FriendlyURL`, `ThemeId`, `l1_Name`, `l1_Description`, `l1_CachedNavbar`, `l1_Title`, `l1_MenuTitle`, `l1_Translated`, `l2_Name`, `l3_Name`, `l4_Name`, `l5_Name`, `l2_Description`, `l3_Description`, `l4_Description`, `l5_Description`, `l2_CachedNavbar`, `l3_CachedNavbar`, `l4_CachedNavbar`, `l5_CachedNavbar`, `l2_Title`, `l3_Title`, `l4_Title`, `l5_Title`, `l2_MenuTitle`, `l3_MenuTitle`, `l4_MenuTitle`, `l5_MenuTitle`, `l2_Translated`, `l3_Translated`, `l4_Translated`, `l5_Translated`)
    VALUES (DEFAULT, '0', NULL, '401', 'Test', '1', '1249405692', '0', '1', '-1', NULL, '0', '-1', '502', '|1|2|137|139|140|141|142|143|144|145|146|147|148|149|150|151|152|153|154|155|156|157|158|159|160|161|162|163|164|165|166|167|168|169|170|171|172|173|174|175|176|177|178|179|180|181|182|183|184|185|186|187|188|189|190|191|192|193|194|195|196|197|198|199|200|201|202|203|204|205|206|207|208|209|210|211|212|213|214|215|216|217|218|219|220|221|222|223|224|225|226|227|228|229|230|231|232|233|234|235|236|237|238|239|240|241|242|243|244|245|246|247|248|249|250|251|252|253|254|255|256|257|258|259|260|261|262|263|264|265|266|267|268|269|270|271|272|273|274|275|276|277|278|279|280|281|282|283|284|285|286|287|288|289|290|291|292|293|294|295|296|297|298|299|300|301|302|303|304|305|306|307|308|309|310|311|312|313|314|315|316|317|318|319|320|321|322|323|324|325|326|327|328|329|330|331|332|333|334|335|336|337|338|339|340|341|342|343|344|345|346|347|348|349|350|351|352|353|354|355|356|357|358|359|360|361|362|363|364|365|366|367|368|369|370|371|372|373|374|375|376|377|378|379|380|381|382|383|384|385|386|387|388|389|390|391|392|393|394|395|396|397|398|399|400|401|', '3', '4', 'Content_n_m_s_Directory_n_m_s_Test', NULL, '2', '2', '2', '1249405544', '0', '_n_m_s_in-link_n_m_s_designs_n_m_s_section', '', '0', '', '0', '', NULL, NULL, '0', '1', '0', '0', NULL, '', '0', 'Test', NULL, 'Content&|&Directory&|&Test', 'Test', 'Test', '0', '', '', '', '', NULL, NULL, NULL, NULL, 'Content&|&Directory&|&Test', 'Content&|&Directory&|&Test', 'Content&|&Directory&|&Test', 'Content&|&Directory&|&Test', '', '', '', '', '', '', '', '', '0', '0', '0', '0') ?>
Fatal error: Allowed memory size of 52428800 bytes exhausted (tried to allocate 13659 bytes) in /home/simone/web/dev/SVN/in-portal.full.5.0.x/core/kernel/utility/debugger.php on line 664
(0000237)
alex   
2009-08-04 15:40   
Maybe we should check that full ParentPath of source category is not within target category or otherwise. Should also check for recursion on 2-nd and more level. Example:
Categories: "Directory -> Links"

1. Copy Links category, when in Directory, then go to Links category and paste to it.
2. Copy Directory category, then go to Links category and paste to it.
(0000247)
alex   
2009-08-05 05:25   
Fix committed to 5.0.x branch. Commit Message:

1. Fixes 0000101: Preventing Category "Copy/Paste" from Recursion.
2. Fixed warning in "EmailEventsEventsHandler::_getSendLanguage" method.
(0000701)
administrator   
2009-10-03 07:56   
Closing issues from 5.0.1 version, because version was already released.