In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1006 [In-Portal CMS] Optimization task always 2011-02-21 13:31 2011-03-30 09:53
Dmitry  
Dmitry  
normal  
closed 5.1.2-B2  
fixed  
 
none 5.1.2-RC1  
https://groups.google.com/d/topic/in-portal-bugs/uwfyKB34V7s/discussion
Deleted some deprecated code and tables
0
0001006: Delete Deprecated Code and Tables
Deprecated Tables and Code that needs to be DELETED (completely not used).

1. Stylesheets - no longer in use, must be deleted - DELETE
2. StylesheetSelectors - no longer in use, must be deleted - DELETE
3. SysCache - I don't know what this is - DELETE
4. TagAttributes - no longer in use, must be deleted - DELETE
5. TagLibrary - no longer in use, must be deleted - DELETE


Carefully review and delete all associated code and drop these tables.
related to 0001011closed  (5.2.0)alex Review and Rename Table Names in CORE 
patch Delete-Deprecated-Code-and-Tables.patch (26,704) 2011-02-28 17:58
http://tracker.in-portal.org/file_download.php?file_id=954&type=bug
patch Delete-Deprecated-Code-and-Tables_v2.patch (26,616) 2011-03-22 04:36
http://tracker.in-portal.org/file_download.php?file_id=974&type=bug
patch Delete-Deprecated-Code-and-Tables-In-Commerce-StyleSheets.patch (8,285) 2011-03-22 14:40
http://tracker.in-portal.org/file_download.php?file_id=975&type=bug
Issue History
2011-10-22 16:11 alex Relationship added related to 0001011
2011-03-30 09:53 Dmitry Note Added: 0003315
2011-03-30 09:53 Dmitry Status resolved => closed
2011-03-22 14:47 Dmitry Note Added: 0003310
2011-03-22 14:47 Dmitry Assigned To alex => Dmitry
2011-03-22 14:47 Dmitry Changeset attached 5.1.x r14294
2011-03-22 14:40 Dmitry File Added: Delete-Deprecated-Code-and-Tables-In-Commerce-StyleSheets.patch
2011-03-22 04:38 alex Note Added: 0003307
2011-03-22 04:38 alex Status reviewed and tested => resolved
2011-03-22 04:38 alex Fixed in Version => 5.1.2-RC1
2011-03-22 04:38 alex Resolution open => fixed
2011-03-22 04:38 alex Assigned To !COMMUNITY => alex
2011-03-22 04:38 alex Changeset attached 5.1.x r14265
2011-03-22 04:37 alex Note Added: 0003306
2011-03-22 04:37 alex Status needs testing => reviewed and tested
2011-03-22 04:36 alex File Added: Delete-Deprecated-Code-and-Tables_v2.patch
2011-02-28 18:01 Dmitry Note Added: 0003284
2011-02-28 18:01 Dmitry Assigned To => !COMMUNITY
2011-02-28 18:01 Dmitry Developer => Dmitry
2011-02-28 18:01 Dmitry Status active => needs testing
2011-02-28 18:01 Dmitry Note Deleted: 0003283
2011-02-28 18:01 Dmitry Note Edited: 0003283 bug_revision_view_page.php?bugnote_id=0003283#r693
2011-02-28 18:01 Dmitry Note Added: 0003283
2011-02-28 17:58 Dmitry File Added: Delete-Deprecated-Code-and-Tables.patch
2011-02-21 13:33 Dmitry Reference [/url] => [url]https://groups.google.com/d/topic/in-portal-bugs/uwfyKB34V7s/discussion
2011-02-21 13:31 Dmitry Change Log Message => Deleted some deprecated code and tables
2011-02-21 13:31 Dmitry New Issue
2011-02-21 13:31 Dmitry Reference => [url][/url]

Notes
(0003284)
Dmitry   
2011-02-28 18:01   
To test this task, you need to:

1. Apply the patch

2. Delete the following folder (and files inside):
- core/units/stylesheets
- core/units/selectors
- core/admin_templates/stylesheets
(0003306)
alex   
2011-03-22 04:37   
Actually your patch failed to work, since multiple tables were listed in single "DROP TABLE" statement and In-Portal can't properly insert table prefix in that case.

Also instead of multiple OR to match phrases I've used IN(...) statement.

New patch attached.
(0003307)
alex   
2011-03-22 04:38   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0001006: Delete Deprecated Code and Tables
(0003310)
Dmitry   
2011-03-22 14:47   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0001006: Delete Deprecated Code and Tables (minor fixes for installation)
(0003315)
Dmitry   
2011-03-30 09:53   
Closing, since 5.1.2 release has been released.