Notes |
|
(0004063)
|
erik
|
2011-10-17 10:40
|
|
patch attached - needs testing |
|
|
(0004076)
|
alex
|
2011-10-19 04:14
|
|
1. Not all usages of "Site_Path" configuration variable were transformed (please search through all code of all modules, that are available in "in-portal.full" checkout. There must be separate patches for
- In-Portal changes (...._core.patch)
- In-Portal module changes (...._modules.patch)
- In-Portal theme changes (...._themes.patch)
2. Please set WebsitePath into config.php at the beginning (e.g. where WriteablePath & RestrictedPath are set).
3. Please adjust DisplayOrder of all configuration variables in same sub-section where "Site_Path" configuration variable was (this can be done with a single UPDATE sql). Right now they start from 10.02 and not from 10.01 as they should.
4. Usage of WebsitePath setting in startup.php doesn't make sense, since you check if it's present then use it and it's always present. While in task description there was written, that WebsitePath should be used as BASE_PATH only, when In-Portal is invoked from command line.
5. It's also unclear to me, why you have removed rtrim(..., '/') around BASE_PATH usage in kApplication::BaseURL method, especially since both old Site_Path config variable and new WebsitePath setting have "/" at the end.
----
For parts, where I haven't get the idea about the changed code you can explain it here or revert it to original state. |
|
|
(0004081)
|
erik
|
2011-10-21 05:43
|
|
1) attached new patches, included patch for modules, in the themes variable Site_Path not found - needs testing
2) Problematically, because BASE_PATH constant is not defined on this step.
3) Done
4) Done - changed logic
5) rtrim removed, because rtrim is already used on BASE_PATH constant definition, so BASE_PATH value is always "rtrimmed".
|
|
|
(0004086)
|
alex
|
2011-10-25 08:36
|
|
Following bugs were found & fixed:
1. no upgrade script, so running cron from command line would fail after upgrade
Following optimizations were made:
1. constant BASE_PATH looks, like former "Site_Path" config variable (except of trailing "/"), so I've decided to use WariablesPath value instead of detecting BASE_PATH value on every script run
2. because of no need for auto-detection constant REL_PATH was removed from all places, except installator itself. |
|
|
(0004087)
|
alex
|
2011-10-25 08:44
|
|
Fix committed to 5.2.x branch. Commit Message:
Fixes 0001005: Incorrectly Detected BASE_PATH in Cron
Commit on behalf of Erik |
|
|
(0005074)
|
alex
|
2012-07-25 05:33
|
|
Since 5.2.0 version was released. |
|