In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/b70db1259bef45ba

Change Log Message

Lists without sorting warning fixed

Estimate Points

Attached Files

warning_when_no_list_sortings_defined.patch [^] (595 bytes) 2010-10-31 05:56 [Show Content]

Index: db_event_handler.php
===================================================================
--- db_event_handler.php	(revision 14020)
+++ db_event_handler.php	(working copy)
@@ -1001,7 +1001,7 @@
 				}
 			}
 
-			$list_sortings = $this->Application->getUnitOption($event->Prefix, 'ListSortings');
+			$list_sortings = $this->Application->getUnitOption($event->Prefix, 'ListSortings', Array ());
 			$sorting_prefix = array_key_exists($event->Special, $list_sortings) ? $event->Special : '';
 			$sorting_configs = $this->Application->getUnitOption($event->Prefix, 'ConfigMapping');

warning_when_no_list_sortings_defined_v2.patch [^] (3,246 bytes) 2010-11-01 14:30 [Show Content]

Index: kernel/db/cat_event_handler.php
===================================================================
--- kernel/db/cat_event_handler.php	(revision 14024)
+++ kernel/db/cat_event_handler.php	(working copy)
@@ -2611,7 +2611,7 @@
 		// add EditorsPick to ForcedSorting if needed
 		$config_mapping = $this->Application->getUnitOption($event->Prefix, 'ConfigMapping');
 		if (array_key_exists('ForceEditorPick', $config_mapping) && $this->Application->ConfigValue($config_mapping['ForceEditorPick'])) {
-			$list_sortings = $this->Application->getUnitOption($event->Prefix, 'ListSortings');
+			$list_sortings = $this->Application->getUnitOption($event->Prefix, 'ListSortings', Array ());
 
 			$new_forced_sorting = Array ('EditorsPick' => 'DESC');
 
Index: kernel/db/db_event_handler.php
===================================================================
--- kernel/db/db_event_handler.php	(revision 13936)
+++ kernel/db/db_event_handler.php	(working copy)
@@ -1001,7 +1001,7 @@
 				}
 			}
 
-			$list_sortings = $this->Application->getUnitOption($event->Prefix, 'ListSortings');
+			$list_sortings = $this->Application->getUnitOption($event->Prefix, 'ListSortings', Array ());
 			$sorting_prefix = array_key_exists($event->Special, $list_sortings) ? $event->Special : '';
 			$sorting_configs = $this->Application->getUnitOption($event->Prefix, 'ConfigMapping');
 
Index: kernel/db/db_tag_processor.php
===================================================================
--- kernel/db/db_tag_processor.php	(revision 13936)
+++ kernel/db/db_tag_processor.php	(working copy)
@@ -1473,7 +1473,7 @@
 	 */
 	function getUserSortIndex()
 	{
-		$list_sortings = $this->Application->getUnitOption($this->Prefix, 'ListSortings');
+		$list_sortings = $this->Application->getUnitOption($this->Prefix, 'ListSortings', Array ());
 		$sorting_prefix = getArrayValue($list_sortings, $this->Special) ? $this->Special : '';
 
 		$user_sorting_start = 0;
Index: units/categories/categories_event_handler.php
===================================================================
--- units/categories/categories_event_handler.php	(revision 13987)
+++ units/categories/categories_event_handler.php	(working copy)
@@ -1923,7 +1923,7 @@
 			}
 			else {
 				// sort by parent path on Front-End only
-				$list_sortings = $this->Application->getUnitOption($event->Prefix, 'ListSortings');
+				$list_sortings = $this->Application->getUnitOption($event->Prefix, 'ListSortings', Array ());
 				$list_sortings['']['ForcedSorting'] = Array ("CurrentSort" => 'asc');
 				$this->Application->setUnitOption($event->Prefix, 'ListSortings', $list_sortings);
 			}
Index: units/helpers/list_helper.php
===================================================================
--- units/helpers/list_helper.php	(revision 13936)
+++ units/helpers/list_helper.php	(working copy)
@@ -113,7 +113,7 @@
 		 */
 		function getUserSortIndex(&$list)
 		{
-			$list_sortings = $this->Application->getUnitOption($list->Prefix, 'ListSortings');
+			$list_sortings = $this->Application->getUnitOption($list->Prefix, 'ListSortings', Array ());
 			$sorting_prefix = getArrayValue($list_sortings, $list->Special) ? $list->Special : '';
 
 			$user_sorting_start = 0;

Relationships [ Relation Graph ] [ Dependency Graph ]

child of

0000579

closed (5.1.0)

alex

Ability to use PerPage, SortBy and Page params from URL Query

Notes
(0002933) Dmitry (manager) 2010-11-01 10:43	Current part well, but found another ListSortings notice which is NOT fixed by this patch - when Category Item is missing a ListSortings definitions. Please address.

(0002941) alex (manager) 2010-11-01 14:30	Fixed.

(0002942) Dmitry (manager) 2010-11-01 15:04	Tested good, please commit.

(0002943) alex (manager) 2010-11-01 15:13	Fix committed to 5.1.x branch. Commit Message: Fixes 0000913: Warning, when unit doesn't have ListSortings option

(0003004) Dmitry (manager) 2010-11-30 12:48	Closing released 5.1.1 task.

Related Changesets
In-Portal CMS: 5.1.x r14027 Timestamp: 2010-11-01 15:13:39 Author: alex [ Details ] [ Diff ]	Fixes 0000913: Warning, when unit doesn't have ListSortings option
	mod - /in-portal/branches/5.1.x/core/kernel/db/cat_event_handler.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/kernel/db/db_event_handler.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/kernel/db/db_tag_processor.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/units/categories/categories_event_handler.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/units/helpers/list_helper.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-11-30 12:48	Dmitry	Note Added: 0003004
2010-11-30 12:48	Dmitry	Status	resolved => closed
2010-11-01 15:13	alex	Note Added: 0002943
2010-11-01 15:13	alex	Status	reviewed and tested => resolved
2010-11-01 15:13	alex	Fixed in Version	=> 5.1.1-RC1
2010-11-01 15:13	alex	Resolution	open => fixed
2010-11-01 15:13	alex	Assigned To	!COMMUNITY => alex
2010-11-01 15:13	alex	Changeset attached	5.1.x r14027
2010-11-01 15:04	Dmitry	Note Added: 0002942
2010-11-01 15:04	Dmitry	Status	needs testing => reviewed and tested
2010-11-01 14:30	alex	Note Added: 0002941
2010-11-01 14:30	alex	Assigned To	alex => !COMMUNITY
2010-11-01 14:30	alex	Status	needs work => needs testing
2010-11-01 14:30	alex	File Added: warning_when_no_list_sortings_defined_v2.patch
2010-11-01 10:43	Dmitry	Assigned To	!COMMUNITY => alex
2010-11-01 10:43	Dmitry	Note Added: 0002933
2010-11-01 10:43	Dmitry	Status	needs testing => needs work
2010-10-31 05:58	alex	Relationship added	child of 0000579
2010-10-31 05:57	alex	Assigned To	=> !COMMUNITY
2010-10-31 05:57	alex	Developer	=> alex
2010-10-31 05:57	alex	Status	active => needs testing
2010-10-31 05:57	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/b70db1259bef45ba
2010-10-31 05:56	alex	New Issue
2010-10-31 05:56	alex	File Added: warning_when_no_list_sortings_defined.patch
2010-10-31 05:56	alex	Change Log Message	=> Lists without sorting warning fixed

Web Development by Intechnic

In-Portal Open Source CMS