In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000871 [In-Commerce] Shipping Engine task N/A 2010-09-22 13:53 2011-03-30 09:58
Reporter alex View Status public Project Name In-Commerce
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.1.1-B2
Status closed Product Version 5.1.0 Target Version 5.1.1
Time EstimateNo estimate
Summary 0000871: 3rd refactoring of Shipping Quote Engines related to USPS
Description We have method, named "MakeUSPSOrder" in OrderEventHandler class. This not good, since we have separate class for USPS interaction code.

I propose to create universal method MakeOrder in each SQE (ShippingQuoteEngine) and move MakeUSPSOrder to one of them. This way we will determine SQE by shipping type used in order and delegate all specific processing to it.
Additional Information
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/74b6305480f985db
Change Log Message
Estimate Points 0
Attached Files patch file icon usps_to_sqe_incommerce.patch [^] (21,728 bytes) 2010-09-22 13:53 [Show Content]
txt file icon usps-sql-debug.txt [^] (4,158 bytes) 2010-09-23 13:18 [Show Content]
patch file icon usps_to_sqe_incommerce_v2.patch [^] (22,567 bytes) 2010-09-26 05:55 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0002860)
alex (manager)
2010-09-22 13:55

1. usps_error(-s) variables renamed to sqe_error(-s)
2. invalid rates received from sqe are not saved to db
3. ord:MakeUSPSOrder was transformed to MakeOrder and moved to SQE class
User avatar (0002863)
Dmitry (manager)
2010-09-23 13:17

Tested and looks like we need some work.

For some reason we never got to "MakeOrder" with USPS. See part of DEBUG on occurred during Ship Order action.
User avatar (0002867)
Dmitry (manager)
2010-09-26 20:10

Reviewed and tested GOOD on 5.1.1-Beta1.

What the Intershipper part - it still should be working fine?
User avatar (0002868)
Dmitry (manager)
2010-09-26 20:12

Reminder sent to: alex

Also, I believe we should get this into 5.1.1 release to make our lives easier due to nature of the changes.
User avatar (0002870)
alex (manager)
2010-09-27 12:43

Fix committed to 5.1.x branch. Commit Message:

Fixes 0000871: 3rd refactoring of Shipping Quote Engines related to USPS
User avatar (0003389)
Dmitry (manager)
2011-03-30 09:58

Closing, since 5.1.1 release has been released.

- Related Changesets
Modules :: In-Commerce: 5.1.x r13985
Timestamp: 2010-09-27 12:43:31
Author: alex
Details ] Diff ]
Fixes 0000871: 3rd refactoring of Shipping Quote Engines related to USPS
mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/orders_edit_shipping.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/orders_toship_list.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/orders/orders_event_handler.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/orders/orders_tag_processor.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/shipping_quote_engines/shipping_quote_collector.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/shipping_quote_engines/shipping_quote_engine.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/shipping_quote_engines/usps.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2011-03-30 09:58 Dmitry Note Added: 0003389
2011-03-30 09:58 Dmitry Status resolved => closed
2010-09-27 12:43 alex Note Added: 0002870
2010-09-27 12:43 alex Status reviewed and tested => resolved
2010-09-27 12:43 alex Fixed in Version => 5.1.1-B2
2010-09-27 12:43 alex Resolution open => fixed
2010-09-27 12:43 alex Changeset attached 5.1.x r13985
2010-09-27 03:22 alex Target Version Icebox => 5.1.1
2010-09-26 20:12 Dmitry Note Added: 0002868
2010-09-26 20:10 Dmitry Note Added: 0002867
2010-09-26 20:10 Dmitry Assigned To Dmitry => alex
2010-09-26 20:10 Dmitry Status needs testing => reviewed and tested
2010-09-26 05:58 alex Assigned To alex => Dmitry
2010-09-26 05:58 alex Status needs work => needs testing
2010-09-26 05:55 alex File Added: usps_to_sqe_incommerce_v2.patch
2010-09-23 13:18 Dmitry File Added: usps-sql-debug.txt
2010-09-23 13:17 Dmitry Note Added: 0002863
2010-09-23 13:17 Dmitry Assigned To Dmitry => alex
2010-09-23 13:17 Dmitry Status needs testing => needs work
2010-09-22 13:55 alex Note Added: 0002860
2010-09-22 13:55 alex Assigned To gleb => Dmitry
2010-09-22 13:55 alex Developer => alex
2010-09-22 13:55 alex Status needs work => needs testing
2010-09-22 13:55 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/74b6305480f985db
2010-09-22 13:53 alex New Issue
2010-09-22 13:53 alex Status active => needs work
2010-09-22 13:53 alex Assigned To => gleb
2010-09-22 13:53 alex File Added: usps_to_sqe_incommerce.patch



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker