In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000701 [In-Portal CMS] Data Management bug report always 2010-04-16 17:49 2010-11-30 12:48
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.1.1-B1
Status closed Product Version 5.1.0 Target Version 5.1.1
Time EstimateNo estimate
Summary 0000701: Add "Run Now" toolbar button to Agents grid
Description Add "Run Now" button on toolbar in Agents section. It will run selected agents immediately, but only, when they are not already running. Simply passing agent event in url won't guarantee parallel execution protection.
Additional Information
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/8195138be50c2e85/f495aa3fbf42c0a4
Change Log Message
Estimate Points 0
Attached Files patch file icon run_agent_button.patch [^] (9,741 bytes) 2010-09-11 14:17 [Show Content]
patch file icon run_agent_button_v2.patch [^] (9,442 bytes) 2010-09-12 05:06 [Show Content]
patch file icon run_agent_button_modules.patch [^] (566 bytes) 2010-09-12 05:07 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0002812)
Dmitry (manager)
2010-09-11 22:13

Some issues seems to be found.

In runAgent method the following code:

if ($next_run && ($next_run > adodb_mktime())) {
   return false;
}

prevents the system from starting ANY agents manually (new button) that scheduled to run in the future which won't work for us. User should be able to start ANY event (that is not running already) at any given time.

Back to you for review.
User avatar (0002813)
alex (manager)
2010-09-12 05:08

Patch "run_agent_button_modules.patch" contains fix for "listing_payments" agent, that failed to run because of Fatal Error.
User avatar (0002816)
Dmitry (manager)
2010-09-12 11:28

Tested both patches good, please commit!
User avatar (0002817)
alex (manager)
2010-09-12 11:40

Fix committed to 5.1.x branch. Commit Message:

Fixes 0000701: Add "Run Now" toolbar button to Agents grid
User avatar (0003037)
Dmitry (manager)
2010-11-30 12:48

Closing released 5.1.1 task.

- Related Changesets
In-Portal CMS: 5.1.x r13934
Timestamp: 2010-09-12 11:40:27
Author: alex
Details ] Diff ]
Fixes 0000701: Add "Run Now" toolbar button to Agents grid
mod - /in-portal/branches/5.1.x/admin/system_presets/simple/agents_agent.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/agents/agent_list.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install/english.lang Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/event_manager.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/agents/agent_eh.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/agents/agents_config.php Diff ] File ]
Modules :: In-Commerce: 5.1.x r13933
Timestamp: 2010-09-12 11:39:08
Author: alex
Details ] Diff ]
Bug 0000701: Add "Run Now" toolbar button to Agents grid
mod - /w/in-commerce/branches/5.1.x/units/orders/orders_event_handler.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-11-30 12:48 Dmitry Note Added: 0003037
2010-11-30 12:48 Dmitry Status resolved => closed
2010-09-12 11:40 alex Note Added: 0002817
2010-09-12 11:40 alex Status reviewed and tested => resolved
2010-09-12 11:40 alex Fixed in Version => 5.1.1-B1
2010-09-12 11:40 alex Resolution open => fixed
2010-09-12 11:40 alex Changeset attached 5.1.x r13934
2010-09-12 11:39 alex Changeset attached 5.1.x r13933
2010-09-12 11:28 Dmitry Note Added: 0002816
2010-09-12 11:28 Dmitry Assigned To !COMMUNITY => alex
2010-09-12 11:28 Dmitry Status needs testing => reviewed and tested
2010-09-12 05:08 alex Note Added: 0002813
2010-09-12 05:08 alex Assigned To alex => !COMMUNITY
2010-09-12 05:08 alex Status needs work => needs testing
2010-09-12 05:07 alex File Added: run_agent_button_modules.patch
2010-09-12 05:06 alex File Added: run_agent_button_v2.patch
2010-09-11 22:13 Dmitry Status reviewed and tested => needs work
2010-09-11 22:13 Dmitry Note Added: 0002812
2010-09-11 22:13 Dmitry Assigned To !COMMUNITY => alex
2010-09-11 22:13 Dmitry Status needs testing => reviewed and tested
2010-09-11 14:17 alex Time Estimate Removed 3 =>
2010-09-11 14:17 alex Assigned To alex => !COMMUNITY
2010-09-11 14:17 alex Developer => alex
2010-09-11 14:17 alex Status needs work => needs testing
2010-09-11 14:17 alex File Added: run_agent_button.patch
2010-08-31 14:11 alex version => 5.1.0
2010-08-27 13:12 alex Time Estimate Added 3
2010-07-31 14:06 Dmitry Assigned To => alex
2010-07-31 14:06 Dmitry Status active => needs work
2010-07-31 14:06 Dmitry Target Version Icebox => 5.1.1
2010-04-17 04:50 alex Target Version 5.1.0 => Icebox
2010-04-16 17:49 Dmitry New Issue
2010-04-16 17:49 Dmitry Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/8195138be50c2e85/f495aa3fbf42c0a4



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker