In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000611

[In-Portal CMS] Data Management

bug report

always

2010-03-14 14:31

2010-06-10 13:44

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.0.4-B1

Status

closed

Product Version

5.0.2

Target Version

5.0.4

Time Estimate

No estimate

Summary

0000611: Show only first N characters of database query output in debugger

Description

I think, that we should show only first N characters of database query output in debugger. This actual for queries made by kDBConnection::GetOne method only. For example whole set of cached configs is placed in debugger each time and makes each debugger report large in size.

I've already using such approach for displaying data, that is retrieved from memcached in 5.1.0.

Additional Information

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-dev/browse_thread/thread/b37b3a09c0179861

Change Log Message

Estimate Points

0

long_sql_output_cut.patch [^] (715 bytes) 2010-03-14 14:31 [Show Content]

Index: db_connection.php
===================================================================
--- db_connection.php	(revision 13203)
+++ db_connection.php	(working copy)
@@ -498,6 +498,11 @@
 				// set 2nd checkpoint: begin
 				if ($profileSQLs) {
 					$first_cell = count($ret) == 1 && count(current($ret)) == 1 ? current(current($ret)) : null;
+					
+					if (strlen($first_cell) > 200) {
+					    $first_cell = substr($first_cell, 0, 50) . ' ...';
+					}
+
 					$debugger->profileFinish('sql_'.$queryID, null, null, $this->getAffectedRows(), $first_cell, $this->_queryCount, $this->nextQueryCachable);
 					$debugger->profilerAddTotal('sql', 'sql_'.$queryID);
 					$this->nextQueryCachable = false;

long_sql_output_cut_v2.patch [^] (788 bytes) 2010-04-06 04:08 [Show Content]

Index: kernel/db/db_connection.php
===================================================================
--- kernel/db/db_connection.php	(revision 13329)
+++ kernel/db/db_connection.php	(working copy)
@@ -489,8 +489,13 @@
 				}
 
 				// set 2nd checkpoint: begin
-				$first_cell = count($ret) == 1 && count(current($ret)) == 1 ? current(current($ret)) : null;
 				if ($profileSQLs) {
+					$first_cell = count($ret) == 1 && count(current($ret)) == 1 ? current(current($ret)) : null;
+
+					if (strlen($first_cell) > 200) {
+					    $first_cell = substr($first_cell, 0, 50) . ' ...';
+					}
+
 					$debugger->profileFinish('sql_'.$queryID, null, null, $this->getAffectedRows(), $first_cell, $this->_queryCount);
 					$debugger->profilerAddTotal('sql', 'sql_'.$queryID);
 				}

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0001788) Dmitry (manager) 2010-04-04 23:01	Patch can't be applied as is - there seems to be some changed things. Please update and reattach for testing.

(0001815) alex (manager) 2010-04-06 04:08	Patch "long_sql_output_cut_v2.patch" contains re-created version, that could be applied to 5.0.3 release.

(0001835) Dmitry (manager) 2010-04-09 00:47	Tested okay.

(0002181) alex (manager) 2010-05-11 03:47	Fix committed to 5.0.x branch. Commit Message: Fixes 0000611: Show only first N characters of database query output in debugger

(0002431) alex (manager) 2010-06-10 13:44	Closing since version 5.0.4 is released.

Related Changesets
In-Portal CMS: 5.0.x r13529 Timestamp: 2010-05-11 03:47:37 Author: alex [ Details ] [ Diff ]	Fixes 0000611: Show only first N characters of database query output in debugger
	mod - /in-portal/branches/5.0.x/core/kernel/db/db_connection.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-06-10 13:44	alex	Note Added: 0002431
2010-06-10 13:44	alex	Status	resolved => closed
2010-05-11 03:47	alex	Note Added: 0002181
2010-05-11 03:47	alex	Status	reviewed and tested => resolved
2010-05-11 03:47	alex	Fixed in Version	=> 5.0.4-B1
2010-05-11 03:47	alex	Resolution	open => fixed
2010-05-11 03:47	alex	Assigned To	!COMMUNITY => alex
2010-05-11 03:47	alex	Changeset attached	5.0.x r13529
2010-04-09 00:47	Dmitry	Note Added: 0001835
2010-04-09 00:47	Dmitry	Status	needs testing => reviewed and tested
2010-04-06 04:08	alex	Note Added: 0001815
2010-04-06 04:08	alex	Assigned To	alex => !COMMUNITY
2010-04-06 04:08	alex	Status	needs work => needs testing
2010-04-06 04:08	alex	File Added: long_sql_output_cut_v2.patch
2010-04-04 23:01	Dmitry	Note Added: 0001788
2010-04-04 23:01	Dmitry	Assigned To	!COMMUNITY => alex
2010-04-04 23:01	Dmitry	Status	needs testing => needs work
2010-03-14 14:32	alex	Assigned To	=> !COMMUNITY
2010-03-14 14:32	alex	Developer	=> alex
2010-03-14 14:32	alex	Status	active => needs testing
2010-03-14 14:31	alex	New Issue
2010-03-14 14:31	alex	File Added: long_sql_output_cut.patch
2010-03-14 14:31	alex	Reference	=> http://groups.google.com/group/in-portal-dev/browse_thread/thread/b37b3a09c0179861

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group