In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/f136669ac5953625

Change Log Message

Estimate Points

Attached Files

empty_cart_produces_sqls.patch [^] (757 bytes) 2010-02-24 02:57 [Show Content]

Index: orders_tag_processor.php
===================================================================
--- orders_tag_processor.php	(revision 13152)
+++ orders_tag_processor.php	(working copy)
@@ -166,7 +166,7 @@
 		function ItemsInCart($params)
 		{
 			$object =& $this->getObject($params);
-			if ($object->GetDBField('Status') != ORDER_STATUS_INCOMPLETE) {
+			if ($object->GetDBField('Status') != ORDER_STATUS_INCOMPLETE || $object->GetID() == FAKE_ORDER_ID) {
 				return 0;
 			}
 
@@ -180,7 +180,7 @@
 		{
 			$object =& $this->getObject($params);
 
-			if ($object->GetDBField('Status') != ORDER_STATUS_INCOMPLETE) {
+			if ($object->GetDBField('Status') != ORDER_STATUS_INCOMPLETE || $object->GetID() == FAKE_ORDER_ID) {
 				return 0;
 			}

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0001795) Dmitry (manager) 2010-04-04 23:28	Patch tested good!

(0002182) alex (manager) 2010-05-11 04:05	Fix committed to 5.0.x branch. Commit Message: Fixes 0000583: Tags ord_ItemsInCart and ord_CartNotEmpty produce sql, even with no items in cart

(0002430) alex (manager) 2010-06-10 13:44	Closing since version 5.0.4 is released.

Related Changesets
Modules :: In-Commerce: 5.0.x r13530 Timestamp: 2010-05-11 04:05:03 Author: alex [ Details ] [ Diff ]	Fixes 0000583: Tags ord_ItemsInCart and ord_CartNotEmpty produce sql, even with no items in cart
	mod - /w/in-commerce/branches/5.0.x/units/orders/orders_tag_processor.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-06-10 13:44	alex	Note Added: 0002430
2010-06-10 13:44	alex	Status	resolved => closed
2010-05-11 04:05	alex	Note Added: 0002182
2010-05-11 04:05	alex	Status	reviewed and tested => resolved
2010-05-11 04:05	alex	Fixed in Version	=> 5.0.4-B1
2010-05-11 04:05	alex	Resolution	open => fixed
2010-05-11 04:05	alex	Changeset attached	5.0.x r13530
2010-04-04 23:28	Dmitry	Note Added: 0001795
2010-04-04 23:28	Dmitry	Assigned To	Dmitry => alex
2010-04-04 23:28	Dmitry	Status	needs testing => reviewed and tested
2010-02-27 04:43	alex	Developer	=> alex
2010-02-24 02:58	alex	Assigned To	=> Dmitry
2010-02-24 02:58	alex	Status	active => needs testing
2010-02-24 02:58	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/f136669ac5953625
2010-02-24 02:58	alex	Target Version	=> 5.0.4
2010-02-24 02:57	alex	New Issue
2010-02-24 02:57	alex	File Added: empty_cart_produces_sqls.patch

Web Development by Intechnic

In-Portal Open Source CMS