In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000580 [In-Portal CMS] Data Management bug report always 2010-02-24 02:32 2010-08-30 09:44
Reporter alex View Status public Project Name In-Portal CMS
Assigned To Dmitry Developer
Priority normal Resolution fixed Fixed in Version 5.1.0
Status closed Product Version 5.0.2 Target Version 5.1.1
Time EstimateNo estimate
Summary 0000580: Issues with change log section
Description There are a few issues with change log section:

    * warning message about missing Status field
    * only first letter of each changed field value is shown
    * there no way to delete session log or change log records
    * even if you manage to delete change log record, then new change log records will be created, indicating delete from change log :)

-----------------

I've stumbled upon another issue yesterday: we have CachedRating field (in category items), that has "0.0000000000" value in database and "0.00" default value (format with 2 digits after comma). When value is submitted from form, then we have "0.0000000000" in original field and "0.00" as field value. They are compared as strings (to determine changes) and they differ resulting wrong change log record to be created.

I propose for each changed field we compare it's formatted original field and normal field values to determine if they are really different.

-----------------

When field has a really long value and it is changed, then all that value is displayed in grid makes it near to impossible to use it. I propose we add new format for "kChangesFormatter", like "auto_cut" or something similar and then it can cut each changed field value to normal size, when displayed in grid. When viewing change log record details, then no cutting should be made of course.
Additional Information Also change log records are not optimized. For example when you open product editing page and change one field, then press on "General" tab and change that field again and again, then press Save. As a result you will get 3 change log records, but you've opened editing page only once, so we could merge all change log records together.
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-bugs/browse_thread/thread/5932bd0b414248aa
Change Log Message
Estimate Points 0
Attached Files patch file icon change_log_fixes.patch [^] (35,858 bytes) 2010-02-24 07:18 [Show Content]
patch file icon change_log_fixes_part2.patch [^] (866 bytes) 2010-02-24 08:25 [Show Content]
patch file icon change_log_fixes_part3.patch [^] (648 bytes) 2010-02-24 09:26 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to 0000107closed (5.1.0)alex In-Portal CMS Implement "MemCached" functionality 
related to 0000842active (Icebox) In-Portal CMS Change Log records the changes in Temporarily tables 
parent of 0000581closed (5.0.4)alex In-Commerce Wrong calculation of HasRequiredOptions field resulting additional change log record 
related to 0000578closed (5.0.3)alex In-Portal CMS Foreign key update problem in temp handler 
related to 0000357closed (5.1.0)alex In-Portal CMS Form modification detector (it's php part) works strange 

-  Notes
User avatar (0001777)
Dmitry (manager)
2010-04-04 17:48

There are many mismatches in the 1st patch.

Please review and update so it can be safely applied to the current 5.0.x once 5.0.3 Released.

Thanks.
User avatar (0002636)
Dmitry (manager)
2010-07-31 13:48

Please test cases described by Alex.
User avatar (0002750)
Dmitry (manager)
2010-08-29 19:01

Reviewed and tested mostly okay, but some issues FOUND.

The following is still does NOT work properly:
============
Also change log records are not optimized. For example when you open product editing page and change one field, then press on "General" tab and change that field again and again, then press Save. As a result you will get 3 change log records, but you've opened editing page only once, so we could merge all change log records together.
============
User avatar (0002755)
alex (manager)
2010-08-30 05:58

That's not true, since such optimization code was never implemented. It's only a suggestion with lower priority and can be splitted into other issue.
User avatar (0002756)
Dmitry (manager)
2010-08-30 09:44

This task has been committed in 5.1.0 and tested in 5.1.1.

Separate task (bug) for Change Log saving changes in Temporarily tables has been created ( 0000842 ).

- Related Changesets
In-Portal CMS: 5.1.x r13167
Timestamp: 2010-02-24 09:24:59
Author: alex
Details ] Diff ]
1. Bug 0000580: Issues with change log section
2. Manual merge from 5.0.4 patches to 5.1.0 release, because required by memcache task.
mod - /in-portal/branches/5.1.x/core/units/categories/categories_config.php Diff ] File ]
In-Portal CMS: 5.1.x r13166
Timestamp: 2010-02-24 08:24:45
Author: alex
Details ] Diff ]
1. Bug 0000580: Issues with change log section
2. Manual merge from 5.0.4 patches to 5.1.0 release, because required by memcache task.
mod - /in-portal/branches/5.1.x/core/units/structure/structure_config.php Diff ] File ]
In-Portal CMS: 5.1.x r13161
Timestamp: 2010-02-24 07:20:11
Author: alex
Details ] Diff ]
1. Bug 0000580: Issues with change log section
2. Manual merge from 5.0.4 patches to 5.1.0 release, because required by memcache task.
mod - /in-portal/branches/5.1.x/core/admin_templates/logs/change_logs/change_log_list.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/logs/session_logs/session_log_list.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install/upgrades.sql Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/constants.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/db/db_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/db/dbitem.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/utility/temp_handler.php Diff ] File ]
add - /in-portal/branches/5.1.x/core/units/logs/change_logs/change_log_eh.php File ]
mod - /in-portal/branches/5.1.x/core/units/logs/change_logs/change_logs_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/logs/change_logs/changes_formatter.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/logs/session_logs/session_log_eh.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/logs/session_logs/session_logs_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/permissions/permissions_event_handler.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-08-30 09:44 Dmitry Note Added: 0002756
2010-08-30 09:44 Dmitry Status needs testing => closed
2010-08-30 09:44 Dmitry Resolution open => fixed
2010-08-30 09:44 Dmitry Fixed in Version => 5.1.0
2010-08-30 09:42 Dmitry Assigned To alex => Dmitry
2010-08-30 09:42 Dmitry Status needs work => needs testing
2010-08-30 09:42 Dmitry Relationship added related to 0000842
2010-08-30 05:58 alex Note Added: 0002755
2010-08-29 19:01 Dmitry Note Added: 0002750
2010-08-29 19:01 Dmitry Assigned To Dmitry => alex
2010-08-29 19:01 Dmitry Status needs testing => needs work
2010-08-29 19:00 Dmitry Developer alex => Dmitry
2010-08-29 19:00 Dmitry Status needs work => needs testing
2010-08-02 11:14 Dmitry Target Version Icebox => 5.1.1
2010-07-31 13:48 Dmitry Note Added: 0002636
2010-07-31 13:48 Dmitry Assigned To alex => Dmitry
2010-05-10 14:50 alex Target Version 5.0.4 => Icebox
2010-05-10 14:33 alex Relationship added related to 0000357
2010-04-04 17:48 Dmitry Note Added: 0001777
2010-04-04 17:48 Dmitry Assigned To !COMMUNITY => alex
2010-04-04 17:48 Dmitry Status needs testing => needs work
2010-02-26 16:38 alex Developer => alex
2010-02-24 09:26 alex File Added: change_log_fixes_part3.patch
2010-02-24 09:24 alex Changeset attached 5.1.x r13167
2010-02-24 08:25 alex File Added: change_log_fixes_part2.patch
2010-02-24 08:24 alex Changeset attached 5.1.x r13166
2010-02-24 07:29 alex Relationship added related to 0000107
2010-02-24 07:29 alex Relationship added related to 0000578
2010-02-24 07:27 alex Assigned To => !COMMUNITY
2010-02-24 07:27 alex Status active => needs testing
2010-02-24 07:20 alex Changeset attached 5.1.x r13161
2010-02-24 07:18 alex File Added: change_log_fixes.patch
2010-02-24 02:35 alex Relationship added parent of 0000581
2010-02-24 02:32 alex Target Version => 5.0.4
2010-02-24 02:32 alex New Issue
2010-02-24 02:32 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/5932bd0b414248aa



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker