In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000049 [In-Portal CMS] Optimization task always 2009-06-07 07:12 2010-07-22 15:06
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.1.0-B1
Status closed Product Version Target Version 5.1.0
Time EstimateNo estimate
Summary 0000049: Merge ConfigurationAdmin and ConfigurationValues table
Description I propose to merge ConfigurationAdmin table into ConfigurationValues table. For now all of 342 configuration variables except of 2 have 1-1 (one to one) relation in both tables. This will decrease total table count in database (always good thing) and makes easier to add new configuration variables. Resulting table could also be named ConfigurationValues (less programming required).

There are few places to change anyway:
1. query for displaying configuration values in admin;
2. install_data.sql files for all modules.

Additional Information
Tags No tags attached.
Reference
Change Log Message
Estimate Points 0
Attached Files patch file icon merge_config_tables_core.patch [^] (79,915 bytes) 2010-01-19 08:21 [Show Content]
patch file icon merge_config_tables_modules.patch [^] (157,149 bytes) 2010-01-19 08:21 [Show Content]
patch file icon merge_config_tables_core_install_data_only_v2.patch [^] (92,848 bytes) 2010-03-01 13:39 [Show Content]
patch file icon merge_config_tables_core_v2.patch [^] (81,490 bytes) 2010-03-02 14:24 [Show Content]
patch file icon bad_root_password_on_config_save.patch [^] (1,025 bytes) 2010-03-13 04:46 [Show Content]
patch file icon fix_patch_dialog_broken_on_installation.patch [^] (583 bytes) 2010-04-13 06:33 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
parent of 0000717closed (5.1.0)alex Add ability to display hint labels for configuration variables 
related to 0000454closed (5.1.0)alex Customizable URL Endings for Mod-rewrite 
related to 0000107closed (5.1.0)alex Implement "MemCached" functionality 
related to 0000566closed (5.0.3)alex Don't include tracking code during site content editing in browse modes 
related to 0001369active (Icebox) Images are deleted during link approval process (flash uploader fix) 

-  Notes
User avatar (0000033)
Dmitry (manager)
2009-06-07 16:40

This sounds very reasonable. Putting this improvement idea in 5.1.0
User avatar (0000488)
alex (manager)
2009-09-20 15:30

Also if we add nice form for adding/editing configuration variables, then it will be a real feature.
User avatar (0001430)
alex (manager)
2010-01-19 08:22

Both patches should be applied before testing.
I've also sorted configuration variables in each module install_data.sql file and deleted 29 unused configuration variables.
User avatar (0001500)
Dmitry (manager)
2010-03-01 14:55

There are several Issues here on Fresh install of 5.1.0:

1. on Post Installation step I get "Unknown column 'ca.Install' in 'where clause' (1054)"

2. Looks like NON of Category Custom fields were added and after install in Admin I am getting:

=======
Fatal Error: Unknown column 'cust.l1_cust_1' in 'field list' (1054) [ SELECT Link.* ,(IF (ISNULL(u.Login), IF (Link.CreatedById = -1, "root", IF (Link.CreatedById = -2, "Guest", "n/a")), u.Login)) AS `UserName`,(CategoryItems.CategoryId) AS `CategoryId`,(CategoryItems.Filename) AS `Filename`,(Category.NamedParentPath) AS `CategoryFilename`,(CategoryItems.PrimaryCat) AS `PrimaryCat`,(Category.ParentPath) AS `ParentPath`,(img.SameImages) AS `SameImages`,(img.LocalThumb) AS `LocalThumb`,(img.ThumbPath) AS `ThumbPath`,(img.ThumbUrl) AS `ThumbUrl`,(img.LocalImage) AS `LocalImage`,(img.LocalPath) AS `LocalPath`,(img.Url) AS `FullUrl`,(cust.l1_cust_1) AS `cust_LinkAddress`,(cust.l1_cust_2) AS `cust_LinkCity`,(cust.l1_cust_3) AS `cust_LinkZipCode`,(cust.l1_cust_4) AS `cust_LinkState`,(cust.l1_cust_5) AS `cust_LinkCountry`,(cust.l1_cust_6) AS `cust_LinkPhone`,(Link.CreatedOn) AS `CreatedOn_date`,(Link.CreatedOn) AS `CreatedOn_time`,(Link.Modified) AS `Modified_date`,(Link.Modified) AS `Modified_time`,(Link. #152796740 in /home/simone/web/dev/SVN/5.1.x/core/kernel/application.php on line 2614
=======
User avatar (0001509)
alex (manager)
2010-03-02 14:25

Patch "merge_config_tables_core_v2.patch" contains fix for "merge_config_tables_core.patch" patch.
User avatar (0001530)
Dmitry (manager)
2010-03-09 22:34

Tested fine. Please commit to 5.1.0 SVN
User avatar (0001531)
alex (manager)
2010-03-10 03:06

Fix committed to 5.1.x branch. Commit Message:

Fixes 0000049: Merge ConfigurationAdmin and ConfigurationValues table
User avatar (0001532)
alex (manager)
2010-03-10 03:07

Also I've noticed, that ConfigurationAdmin table wasn't removed from "remove_schema.sql" file. Fixed that in commit, no patch added for that.
User avatar (0001591)
alex (manager)
2010-03-13 04:47

Reminder sent to: Dmitry

Patch "bad_root_password_on_config_save.patch" fixes problem, when root password was set to empty string on each configuration save preventing further "root" login attempts for ever.
User avatar (0001877)
alex (manager)
2010-04-13 06:34

Patch "fix_patch_dialog_broken_on_installation.patch" (commited) fixes problem, that configuration variable labels are not displayed on "Fix Paths" dialog on "Installation Maintenance" mode.
User avatar (0002566)
alex (manager)
2010-07-22 15:06

Closing, since 5.1.0 release has been released.

- Related Changesets
In-Portal CMS: 5.1.x r13381
Timestamp: 2010-04-13 06:34:45
Author: alex
Details ] Diff ]
Bug 0000049: Merge ConfigurationAdmin and ConfigurationValues table
mod - /in-portal/branches/5.1.x/core/install/step_templates/fix_paths.tpl Diff ] File ]
In-Portal CMS: 5.1.x r13212
Timestamp: 2010-03-13 04:48:20
Author: alex
Details ] Diff ]
1. Bug 0000049: Merge ConfigurationAdmin and ConfigurationValues table
2. Root password was broken on configuration save
mod - /in-portal/branches/5.1.x/core/units/configuration/configuration_event_handler.php Diff ] File ]
In-Portal CMS: 5.1.x r13188
Timestamp: 2010-03-10 03:06:05
Author: alex
Details ] Diff ]
Fixes 0000049: Merge ConfigurationAdmin and ConfigurationValues table
mod - /in-portal/branches/5.1.x/core/admin_templates/incs/config_blocks.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install/install_data.sql Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install/install_schema.sql Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install/remove_schema.sql Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install/step_templates/post_config.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install/upgrades.sql Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/db/db_tag_processor.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/configuration/configuration_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/configuration/configuration_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/configuration/configuration_tag_processor.php Diff ] File ]
Modules :: In-News: 5.1.x r13187
Timestamp: 2010-03-10 02:55:52
Author: alex
Details ] Diff ]
Bug 0000049: Merge ConfigurationAdmin and ConfigurationValues table
mod - /modules/in-news/branches/5.1.x/install/install_data.sql Diff ] File ]
mod - /modules/in-news/branches/5.1.x/install/upgrades.sql Diff ] File ]
Modules :: In-Link: 5.1.x r13186
Timestamp: 2010-03-10 02:54:57
Author: alex
Details ] Diff ]
Bug 0000049: Merge ConfigurationAdmin and ConfigurationValues table
mod - /modules/in-link/branches/5.1.x/install/install_data.sql Diff ] File ]
mod - /modules/in-link/branches/5.1.x/install/upgrades.sql Diff ] File ]
Modules :: In-Commerce: 5.1.x r13185
Timestamp: 2010-03-10 02:54:16
Author: alex
Details ] Diff ]
Bug 0000049: Merge ConfigurationAdmin and ConfigurationValues table
mod - /w/in-commerce/branches/5.1.x/install/install_data.sql Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/affiliates/affiliates_event_handler.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/products/products_tag_processor.php Diff ] File ]
Modules :: In-Bulletin: 5.1.x r13184
Timestamp: 2010-03-10 02:52:29
Author: alex
Details ] Diff ]
Bug 0000049: Merge ConfigurationAdmin and ConfigurationValues table
mod - /modules/in-bulletin/branches/5.1.x/install/install_data.sql Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/install/upgrades.sql Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/units/posts/posts_config.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-07-23 08:53 alex Relationship added related to 0001369
2010-07-22 15:06 alex Note Added: 0002566
2010-07-22 15:06 alex Status resolved => closed
2010-04-27 12:07 alex Relationship added parent of 0000717
2010-04-13 06:34 alex Changeset attached 5.1.x r13381
2010-04-13 06:34 alex Note Added: 0001877
2010-04-13 06:33 alex File Added: fix_patch_dialog_broken_on_installation.patch
2010-03-15 10:26 Dmitry Relationship added related to 0000566
2010-03-13 04:48 alex Changeset attached 5.1.x r13212
2010-03-13 04:47 alex Issue Monitored: Dmitry
2010-03-13 04:47 alex Note Added: 0001591
2010-03-13 04:46 alex File Added: bad_root_password_on_config_save.patch
2010-03-10 03:07 alex Note Added: 0001532
2010-03-10 03:06 alex Note Added: 0001531
2010-03-10 03:06 alex Status reviewed and tested => resolved
2010-03-10 03:06 alex Fixed in Version => 5.1.0-B1
2010-03-10 03:06 alex Resolution open => fixed
2010-03-10 03:06 alex Assigned To !COMMUNITY => alex
2010-03-10 03:06 alex Changeset attached 5.1.x r13188
2010-03-10 02:55 alex Changeset attached 5.1.x r13187
2010-03-10 02:54 alex Changeset attached 5.1.x r13186
2010-03-10 02:54 alex Changeset attached 5.1.x r13185
2010-03-10 02:52 alex Changeset attached 5.1.x r13184
2010-03-10 02:50 alex Changeset attached 5.1.x r13183
2010-03-09 22:34 Dmitry Note Added: 0001530
2010-03-09 22:34 Dmitry Status needs testing => reviewed and tested
2010-03-02 14:25 alex Assigned To alex => !COMMUNITY
2010-03-02 14:25 alex Note Added: 0001509
2010-03-02 14:25 alex Status needs work => needs testing
2010-03-02 14:24 alex File Added: merge_config_tables_core_v2.patch
2010-03-01 14:55 Dmitry Time Estimate Removed 3 =>
2010-03-01 14:55 Dmitry Note Added: 0001500
2010-03-01 14:55 Dmitry Assigned To !COMMUNITY => alex
2010-03-01 14:55 Dmitry Status needs testing => needs work
2010-03-01 13:39 alex File Added: merge_config_tables_core_install_data_only_v2.patch
2010-03-01 13:38 alex File Deleted: merge_config_tables_core_install_data_only_v2.patch
2010-03-01 13:35 alex File Added: merge_config_tables_core_install_data_only_v2.patch
2010-02-27 04:18 alex Developer => alex
2010-02-24 11:55 alex Relationship added related to 0000107
2010-02-02 16:46 Dmitry Relationship added related to 0000454
2010-01-19 08:47 alex Time Spent Added 4 hours
2010-01-19 08:44 alex Time Estimate Added 3
2010-01-19 08:22 alex Time Estimate Removed 3 =>
2010-01-19 08:22 alex Note Added: 0001430
2010-01-19 08:22 alex Assigned To => !COMMUNITY
2010-01-19 08:22 alex Status active => needs testing
2010-01-19 08:21 alex File Added: merge_config_tables_modules.patch
2010-01-19 08:21 alex File Added: merge_config_tables_core.patch
2010-01-12 11:30 alex Time Estimate Added 3
2009-10-06 14:26 alex Type bug report => task
2009-09-20 15:30 alex Note Added: 0000488
2009-06-07 16:40 Dmitry Note Added: 0000033
2009-06-07 16:40 Dmitry Target Version => 5.1.0
2009-06-07 07:12 alex New Issue



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker