In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000440

[In-Portal CMS] Admin Interfaces

bug report

always

2009-12-06 23:04

2010-01-11 22:01

Reporter

BaSSiST

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.0.2-B1

Status

closed

Product Version

5.0.1

Target Version

5.0.2

Time Estimate

No estimate

Summary

0000440: CatEventHandler fatal error when ItemPropertyMappings not defined

Description

OnBeforeItemUpdate event in CatEventHandler class throws fatal error when
trying to access undefined variable as object. This happen because $object
is defined inside "if" construction, but after that is also used outside.
Nobody never tried making custom Category Item without ItemPropertyMappings
defined in config (this is "if" condition) until now, so we never have seen
this issue.

Attached patch fixes the bug.

Reported by Sergey G.

Additional Information

Tags

No tags attached.

Reference

Google Groups http://groups.google.com/group/in-portal-bugs/browse_thread/thread/e41b5980751c4fe0

Change Log Message

Estimate Points

0

fatal_error_if_ItemPropertyMapping_not_set.patch [^] (804 bytes) 2009-12-06 23:04 [Show Content]

Index: cat_event_handler.php
===================================================================
--- cat_event_handler.php	(revision 9)
+++ cat_event_handler.php	(working copy)
@@ -866,14 +866,14 @@
 	{
 		parent::OnBeforeItemUpdate($event);
 
+		$object =& $event->getObject();
+		/* @var $object kCatDBItem */
+		
 		// update hits field
 		$property_map = $this->Application->getUnitOption($event->Prefix, 'ItemPropertyMappings');
 		if ($property_map) {
 			$click_field = $property_map['ClickField'];
 
-			$object =& $event->getObject();
-			/* @var $object kCatDBItem */
-
 			if( $this->Application->IsAdmin() && ($this->Application->GetVar($click_field.'_original') !== false) &&
 				floor($this->Application->GetVar($click_field.'_original')) != $object->GetDBField($click_field) )
 			{

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0001179) Dmitry (manager) 2009-12-20 02:08	Code tested ok.

(0001181) alex (manager) 2009-12-20 06:22	Fix committed to 5.0.x branch. Commit Message: Fixes 0000440: CatEventHandler fatal error when ItemPropertyMappings not defined.

(0001314) Dmitry (manager) 2010-01-11 22:01	Closing completed tasks.

Related Changesets
In-Portal CMS: 5.0.x r12952 Timestamp: 2009-12-20 06:22:28 Author: alex [ Details ] [ Diff ]	Fixes 0000440: CatEventHandler fatal error when ItemPropertyMappings not defined.
	mod - /in-portal/branches/5.0.x/core/kernel/db/cat_event_handler.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-01-11 22:01	Dmitry	Note Added: 0001314
2010-01-11 22:01	Dmitry	Status	resolved => closed
2009-12-20 06:22	alex	Changeset attached	5.0.x r12952
2009-12-20 06:22	alex	Note Added: 0001181
2009-12-20 06:22	alex	Status	reviewed and tested => resolved
2009-12-20 06:22	alex	Fixed in Version	=> 5.0.2-B1
2009-12-20 06:22	alex	Resolution	open => fixed
2009-12-20 06:22	alex	Assigned To	!COMMUNITY => alex
2009-12-20 02:08	Dmitry	Note Added: 0001179
2009-12-20 02:08	Dmitry	Status	needs testing => reviewed and tested
2009-12-11 00:12	Dmitry	Reporter	Dmitry => BaSSiST
2009-12-06 23:04	Dmitry	Status	needs work => needs testing
2009-12-06 23:04	Dmitry	New Issue
2009-12-06 23:04	Dmitry	Status	active => needs work
2009-12-06 23:04	Dmitry	Assigned To	=> !COMMUNITY
2009-12-06 23:04	Dmitry	File Added: fatal_error_if_ItemPropertyMapping_not_set.patch
2009-12-06 23:04	Dmitry	Reference	=> Google Groups http://groups.google.com/group/in-portal-bugs/browse_thread/thread/e41b5980751c4fe0

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group