In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000436 [In-Portal CMS] Template System task always 2009-12-04 13:04 2010-01-11 22:01
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.0.2-B1
Status closed Product Version 5.0.1 Target Version 5.0.2
Time EstimateNo estimate
Summary 0000436: Changing behavior of "m_Comments" tag to better support internal comments
Description Currently <inp2: tags inside HTML comment tags are not processed, but there are cases, like:
<!--[if IE 6]><script type="text/javascript"
when they should work. Currently we have tag <inp2:m_Comment>...</inp2:m_Comment> that doesn't show it's contents after parsing. It's pretty useless since we can write comments in form <!--## to
 remove ##--> that will do the same without additional tags. I propose we
 make <inp2:m_Comment> tag create areas in template where <inp2: tags inside
 comments could be parsed (it will change NParser->InsideComment mark and
 then restore it's back at the end). Resulting code will be:
<inp2:m_Comment><!--[if IE 6]><script type="text/javascript"
We could also rename this tag to make sure it's named by the action it does.
Additional Information
Tags No tags attached.
Reference Google Groups
Change Log Message
Estimate Points 0
Attached Files patch file icon tags_inside_comments.patch [^] (1,365 bytes) 2009-12-04 13:04 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0001175)
Dmitry (manager)
2009-12-20 01:58

Tested Ok
User avatar (0001185)
alex (manager)
2009-12-20 06:57

Fix committed to 5.0.x branch. Commit Message:

Fixes 0000436: Changing behavior of "m_Comments" tag to better support internal comments
User avatar (0001310)
Dmitry (manager)
2010-01-11 22:01

Closing completed tasks.

- Related Changesets
In-Portal CMS: 5.0.x r12956
Timestamp: 2009-12-20 06:57:26
Author: alex
Details ] Diff ]
Fixes 0000436: Changing behavior of "m_Comments" tag to better support internal comments
mod - /in-portal/branches/5.0.x/core/kernel/nparser/nparser.php Diff ] File ]
mod - /in-portal/branches/5.0.x/core/kernel/nparser/ntags.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-01-11 22:01 Dmitry Note Added: 0001310
2010-01-11 22:01 Dmitry Status resolved => closed
2009-12-20 06:57 alex Note Added: 0001185
2009-12-20 06:57 alex Status reviewed and tested => resolved
2009-12-20 06:57 alex Fixed in Version => 5.0.2-B1
2009-12-20 06:57 alex Resolution open => fixed
2009-12-20 06:57 alex Assigned To !COMMUNITY => alex
2009-12-20 06:57 alex Changeset attached 5.0.x r12956
2009-12-20 06:57 alex Summary Changing behaviour of "m_Comments" tag to better support internal comments => Changing behavior of "m_Comments" tag to better support internal comments
2009-12-20 01:58 Dmitry Note Added: 0001175
2009-12-20 01:58 Dmitry Status needs testing => reviewed and tested
2009-12-11 00:16 Dmitry Reporter Dmitry => alex
2009-12-11 00:16 Dmitry Target Version => 5.0.2
2009-12-04 13:05 Dmitry Reference Google Groups => Google Groups
2009-12-04 13:05 Dmitry Assigned To => !COMMUNITY
2009-12-04 13:05 Dmitry Status active => needs testing
2009-12-04 13:04 Dmitry New Issue
2009-12-04 13:04 Dmitry File Added: tags_inside_comments.patch
2009-12-04 13:04 Dmitry Reference => Google Groups

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker