In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-dev/ZfCLO4FbDi0/discussion

Change Log Message

Added SSL and Login Required check-boxes for Sections

Estimate Points

Attached Files

page_login_ssl_redirect_feature_core.patch [^] (9,850 bytes) 2012-01-04 03:28 [Show Content]

Index: admin/system_presets/simple/categories_c.php
===================================================================
--- admin/system_presets/simple/categories_c.php	(revision 14975)
+++ admin/system_presets/simple/categories_c.php	(working copy)
@@ -38,12 +38,13 @@
 	// fields to hide
 	$hidden_fields = Array (
 		'CategoryId', /*'Type', 'SymLinkCategoryId', 'ParentId', 'Name', 'Filename', 'AutomaticFilename',*/
-		/*'Description',*/ 'CreatedOn', 'EditorsPick', 'Status', 'DirectLinkEnabled', /*'Priority', 'MetaKeywords', 'CachedDescendantCatsQty',
-		'CachedNavbar',*/ 'CreatedById', /*'ResourceId', 'ParentPath', 'TreeLeft', 'TreeRight', 'NamedParentPath',
-		'MetaDescription', 'HotItem',*/ 'NewItem', /*'PopItem', 'Modified', 'ModifiedById', 'CachedTemplate',*/
-		'Template', /*'UseExternalUrl', 'ExternalUrl',*/ 'UseMenuIconUrl', 'MenuIconUrl', 'Title', 'MenuTitle',
-		/*'MetaTitle', 'IndexTools', 'IsMenu',*/'PromoBlockGroupId', 'Protected', 'Type', 'FormId', 'FormSubmittedTemplate',
-		/*'FriendlyURL', 'ThemeId', 'EnablePageCache', 'OverridePageCacheKey', 'PageCacheKey', 'PageExpiration'*/
+		/*'Description',*/ 'CreatedOn', 'EditorsPick', 'Status', 'DirectLinkEnabled', 'RequireSSL', 'RequireLogin',
+		/*'Priority', 'MetaKeywords', 'CachedDescendantCatsQty', 'CachedNavbar',*/ 'CreatedById', /*'ResourceId',
+ 		'ParentPath', 'TreeLeft', 'TreeRight', 'NamedParentPath', 'MetaDescription', 'HotItem',*/ 'NewItem',
+ 		/*'PopItem', 'Modified', 'ModifiedById', 'CachedTemplate',*/ 'Template', /*'UseExternalUrl', 'ExternalUrl',*/
+		'UseMenuIconUrl', 'MenuIconUrl', 'Title', 'MenuTitle', /*'MetaTitle', 'IndexTools', 'IsMenu',*/'
+		PromoBlockGroupId', 'Protected', 'Type', 'FormId', 'FormSubmittedTemplate', /*'FriendlyURL', 'ThemeId',
+ 		'EnablePageCache', 'OverridePageCacheKey', 'PageCacheKey', 'PageExpiration'*/
 	);
 
 	// virtual fields to hide
@@ -73,9 +74,9 @@
 
 	// hide columns in grids
 	$hide_columns = Array (
-		'Default' => Array (/*'CategoryId', 'Name', 'Modified',*/ 'Template', /*'IsMenu',*/ 'Protected', /*'Type',*/ 'Priority'),
-		'DefaultShowAll' => Array (/*'CategoryId', 'Name', 'Modified',*/ 'Template', /*'IsMenu',*/ 'Protected',/*'Type', 'Priority', 'CachedNavbar'*/),
-		'Radio' => Array (/*'CategoryId', 'Name', 'Modified',*/ 'Template', /*'IsMenu',*/ 'Protected', /*'Type',*/ 'Priority'),
-		'RadioShowALl' => Array (/*'CategoryId', 'Name', 'Modified',*/ 'Template', /*'IsMenu',*/ 'Protected'/*, 'Type', 'Priority', 'CachedNavbar'*/),
-		'Structure' => Array (/*'CategoryId', 'Name', 'Modified',*/ 'Template', /*'IsMenu', 'Path',*/ 'Protected',/*'Type',*/ 'Priority'),
+		'Default' => Array (/*'CategoryId', 'Name', 'Modified',*/ 'Template', /*'IsMenu',*/ 'Protected', 'RequireSSL', 'RequireLogin', /*'Type',*/ 'Priority'),
+		'DefaultShowAll' => Array (/*'CategoryId', 'Name', 'Modified',*/ 'Template', /*'IsMenu',*/ 'Protected', 'RequireSSL', 'RequireLogin',/*'Type', 'Priority', 'CachedNavbar'*/),
+		'Radio' => Array (/*'CategoryId', 'Name', 'Modified',*/ 'Template', /*'IsMenu',*/ 'Protected', 'RequireSSL', 'RequireLogin', /*'Type',*/ 'Priority'),
+		'RadioShowALl' => Array (/*'CategoryId', 'Name', 'Modified',*/ 'Template', /*'IsMenu',*/ 'Protected', 'RequireSSL', 'RequireLogin',/*'Type', 'Priority', 'CachedNavbar'*/),
+		'Structure' => Array (/*'CategoryId', 'Name', 'Modified',*/ 'Template', /*'IsMenu', 'Path',*/ 'Protected','RequireSSL', 'RequireLogin',/*'Type',*/ 'Priority'),
 	);
\ No newline at end of file
Index: core/admin_templates/categories/categories_edit.tpl
===================================================================
--- core/admin_templates/categories/categories_edit.tpl	(revision 14975)
+++ core/admin_templates/categories/categories_edit.tpl	(working copy)
@@ -147,7 +147,7 @@
 				<inp2:m_RenderElement name="inp_label" prefix="c" field="Protected" title="la_fld_Protected"/>
 			</inp2:m_if>
 
-		<inp2:m_RenderElement name="subsection" prefix="c" fields="Status,DirectLinkEnabled,NewItem,EditorsPick,Priority,UseMenuIconUrl,MenuIconUrl,UseExternalUrl,ExternalUrl,CreatedOn,MetaKeywords,MetaDescription,IndexTools" title="la_section_Properties"/>
+		<inp2:m_RenderElement name="subsection" prefix="c" fields="Status,DirectLinkEnabled,RequireSSL,RequireLogin,NewItem,EditorsPick,Priority,UseMenuIconUrl,MenuIconUrl,UseExternalUrl,ExternalUrl,CreatedOn,MetaKeywords,MetaDescription,IndexTools" title="la_section_Properties"/>
 			<inp2:m_if check="c_PageEditable">
 				<inp2:m_RenderElement name="inp_edit_radio" prefix="c" field="Status" title="la_fld_Status"/>
 			<inp2:m_else/>
@@ -171,6 +171,9 @@
 				</inp2:m_RenderElement>
 			</inp2:m_ifnot>
 
+			<inp2:m_RenderElement name="inp_edit_checkbox" prefix="c" field="RequireSSL"/>
+			<inp2:m_RenderElement name="inp_edit_checkbox" prefix="c" field="RequireLogin"/>
+
 			<inp2:m_RenderElement name="inp_edit_radio" prefix="c" field="NewItem" title="la_fld_New"/>
 			<inp2:m_RenderElement name="inp_edit_checkbox" prefix="c" field="EditorsPick" title="la_fld_EditorsPick"/>
 
Index: core/install/english.lang
===================================================================
--- core/install/english.lang	(revision 14975)
+++ core/install/english.lang	(working copy)
@@ -581,6 +581,7 @@
 			<PHRASE Label="la_fld_ReportedOn" Module="Core" Type="1" Column="UmVwb3J0ZWQgT24=">UmVwb3J0ZWQgT24=</PHRASE>
 			<PHRASE Label="la_fld_Required" Module="Core" Type="1" Column="UmVxdWlyZWQ=">UmVxdWlyZWQ=</PHRASE>
 			<PHRASE Label="la_fld_RequireLogin" Module="Core" Type="1" Column="UmVxdWlyZSBMb2dpbg==">UmVxdWlyZSBMb2dpbg==</PHRASE>
+			<PHRASE Label="la_fld_RequireSSL" Module="Core" Type="1" Column="UmVxdWlyZSBTU0w=">UmVxdWlyZSBTU0w=</PHRASE>
 			<PHRASE Label="la_fld_ReviewText" Module="Core" Type="1" Column="Q29tbWVudA==">Q29tbWVudA==</PHRASE>
 			<PHRASE Label="la_fld_RotationDelay" Module="Core" Type="1" Column="UHJvbW8gUm90YXRpb24gRGVsYXkgKHNlY29uZHMp">UHJvbW8gUm90YXRpb24gRGVsYXkgKHNlY29uZHMp</PHRASE>
 			<PHRASE Label="la_fld_RuleType" Module="Core" Type="1" Column="UnVsZSBUeXBl">UnVsZSBUeXBl</PHRASE>
Index: core/install/install_schema.sql
===================================================================
--- core/install/install_schema.sql	(revision 14975)
+++ core/install/install_schema.sql	(working copy)
@@ -481,6 +481,8 @@
   DirectLinkEnabled tinyint(4) NOT NULL DEFAULT '1',
   DirectLinkAuthKey varchar(20) NOT NULL,
   PromoBlockGroupId int(10) unsigned NOT NULL DEFAULT '0',
+  RequireSSL tinyint(4) NOT NULL DEFAULT '0',
+  RequireLogin tinyint(4) NOT NULL DEFAULT '0',
   PRIMARY KEY (CategoryId),
   UNIQUE KEY ResourceId (ResourceId),
   KEY ParentId (ParentId),
Index: core/install/upgrades.sql
===================================================================
--- core/install/upgrades.sql	(revision 14975)
+++ core/install/upgrades.sql	(working copy)
@@ -2519,3 +2519,7 @@
 
 INSERT INTO Events (EventId, Event, ReplacementTags, Enabled, FrontEndOnly, Module, Description, Type, AllowChangingSender, AllowChangingRecipient) VALUES(DEFAULT, 'USER.EMAIL.CHANGE.VERIFY', NULL, 1, 0, 'Core', 'Changed E-mail Verification', 0, 1, 1);
 INSERT INTO Events (EventId, Event, ReplacementTags, Enabled, FrontEndOnly, Module, Description, Type, AllowChangingSender, AllowChangingRecipient) VALUES(DEFAULT, 'USER.EMAIL.CHANGE.UNDO', NULL, 1, 0, 'Core', 'Changed E-mail Rollback', 0, 1, 1);
+
+ALTER TABLE Category
+    ADD RequireSSL TINYINT NOT NULL DEFAULT '0',
+    ADD RequireLogin TINYINT NOT NULL DEFAULT '0';
Index: core/units/categories/categories_config.php
===================================================================
--- core/units/categories/categories_config.php	(revision 14975)
+++ core/units/categories/categories_config.php	(working copy)
@@ -413,6 +413,16 @@
 				'options_sql' => 'SELECT %s FROM ' . TABLE_PREFIX . 'PromoBlockGroups ORDER BY Title', 'option_title_field' => 'Title', 'option_key_field' => 'PromoBlockGroupId',
 				'not_null' => 1, 'default' => 0,
 			),
+			'RequireSSL' => Array (
+				'type' => 'int',
+				'formatter' => 'kOptionsFormatter', 'options' => Array (1 => 'la_Yes', 0 => 'la_No'), 'use_phrases' => 1,
+				'not_null' => 1, 'default' => 0
+			),
+			'RequireLogin' => Array (
+				'type' => 'int',
+				'formatter' => 'kOptionsFormatter', 'options' => Array (1 => 'la_Yes', 0 => 'la_No'), 'use_phrases' => 1,
+				'not_null' => 1, 'default' => 0
+			),
 		),
 
 		'VirtualFields' => Array (
@@ -455,7 +465,8 @@
 					'Type' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
 					'Status' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
 					'Protected' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
-
+					'RequireSSL' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
+					'RequireLogin' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
 				),
 			),
 
@@ -483,6 +494,8 @@
 					'Type' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
 					'Status' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
 					'Protected' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
+					'RequireSSL' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
+					'RequireLogin' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
 				),
 			),
 
@@ -509,6 +522,8 @@
 					'Type' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
 					'Status' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
 					'Protected' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
+					'RequireSSL' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
+					'RequireLogin' => Array ('filter_block' => 'grid_options_filter', 'width' => 100),
 				),
 			),
 		),

page_login_ssl_redirect_feature_themes.patch [^] (807 bytes) 2012-01-04 03:28 [Show Content]

Index: platform/designs/default_design.des.tpl
===================================================================
--- platform/designs/default_design.des.tpl	(revision 14975)
+++ platform/designs/default_design.des.tpl	(working copy)
@@ -1,4 +1,10 @@
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
+<inp2:m_if check="st_Field" name="RequireLogin" db="db">
+    <inp2:m_RequireLogin login_template="platform/login/register" />
+</inp2:m_if>
+<inp2:m_if check="st_Field" name="RequireSSL" db="db">
+    <inp2:m_CheckSSL mode="required"/>
+</inp2:m_if>
 <inp2:m_CheckSSL/>
 <inp2:m_include template="platform/elements/side_boxes.elm" strip_nl="1"/>
 <inp2:m_include template="platform/elements/content_boxes.elm" strip_nl="1"/>

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

0001189

closed (5.2.0)

alex

Site domain with empty "SSL Url" field is always matched as current on secure connection

Notes
(0000943) alex (manager) 2009-10-21 03:41 edited on: 2009-10-21 03:47	Code at top of each design template used: <inp2:m_if check="st_Field" name="RequireLogin" db="db"> <inp2:m_RequireLogin login_template="my_account/login_register" /> </inp2:m_if> <inp2:m_if check="st_Field" name="RequireSSL" db="db"> <inp2:m_CheckSSL mode="required"/> </inp2:m_if> <inp2:m_CheckSSL/> Database queries: ALTER TABLE Category ADD RequireSSL TINYINT NOT NULL DEFAULT '0', ADD RequireLogin TINYINT NOT NULL DEFAULT '0', ADD INDEX (RequireSSL), ADD INDEX (RequireLogin); Code on section edit template: <inp2:m_RenderElement name="inp_edit_checkbox" prefix="c" field="RequireSSL" title="la_fld_RequireSSL"/> <inp2:m_RenderElement name="inp_edit_checkbox" prefix="c" field="RequireLogin" title="la_fld_RequireLogin"/> Code in unit config (fields): 'RequireSSL' => Array ( 'type' => 'int', 'formatter' => 'kOptionsFormatter', 'options' => Array (1 => 'la_Yes', 0 => 'la_No'), 'use_phrases' => 1, 'not_null' => 1, 'default' => 0 ), 'RequireLogin' => Array ( 'type' => 'int', 'formatter' => 'kOptionsFormatter', 'options' => Array (1 => 'la_Yes', 0 => 'la_No'), 'use_phrases' => 1, 'not_null' => 1, 'default' => 0 ), Code in unit config (columns): 'RequireSSL' => Array( 'title' => 'la_col_RequireSSL','filter_block' => 'grid_options_filter'), 'RequireLogin' => Array( 'title' => 'la_col_RequireLogin','filter_block' => 'grid_options_filter'), Of course code in template include theme-specific login-required template path.

(0004055) Dmitry (manager) 2011-10-16 18:00	Moved to 5.2.0 due to popularity.

(0004358) Dmitry (manager) 2011-12-29 18:24 edited on: 2012-01-03 18:04	Please add this to 5.2.0. This functionality has been reviewed by me in Mybodymybest project (can be taken from there) and implementation can be taken from there. Projects SVN Revision 2144 NOTES: 1. NEW checkboxes to be added after "Access with Link" field on Section Edit 2. HIDE all new fields for Simple Preset.

(0004383) alex (manager) 2012-01-04 03:29	Will test all together later.

(0004384) alex (manager) 2012-01-04 03:35	Fix committed to 5.2.x branch. Commit Message: Fixes 0000399: SSL + Login Required options for Sections

(0005001) alex (manager) 2012-07-25 05:32	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r14978 Timestamp: 2012-01-04 03:35:33 Author: alex [ Details ] [ Diff ]	Fixes 0000399: SSL + Login Required options for Sections
	mod - /in-portal/branches/5.2.x/admin/system_presets/simple/categories_c.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/admin_templates/categories/categories_edit.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/install/english.lang	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/install/install_schema.sql	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/install/upgrades.sql	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/units/categories/categories_config.php	[ Diff ] [ File ]

Themes :: Advanced: 1.2.x r14977 Timestamp: 2012-01-04 03:29:39 Author: alex [ Details ] [ Diff ]	Bug 0000399: SSL + Login Required options for Sections
	mod - /themes/advanced/branches/1.2.x/platform/designs/default_design.des.tpl	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:32	alex	Note Added: 0005001
2012-07-25 05:32	alex	Status	resolved => closed
2012-01-04 03:35	alex	Note Added: 0004384
2012-01-04 03:35	alex	Status	reviewed and tested => resolved
2012-01-04 03:35	alex	Fixed in Version	=> 5.2.0-B1
2012-01-04 03:35	alex	Resolution	open => fixed
2012-01-04 03:35	alex	Assigned To	!COMMUNITY => alex
2012-01-04 03:35	alex	Changeset attached	5.2.x r14978
2012-01-04 03:29	alex	Changeset attached	1.2.x r14977
2012-01-04 03:29	alex	Note Added: 0004383
2012-01-04 03:29	alex	Status	needs testing => reviewed and tested
2012-01-04 03:29	alex	Assigned To	alex => !COMMUNITY
2012-01-04 03:29	alex	Developer	=> alex
2012-01-04 03:29	alex	Status	needs work => needs testing
2012-01-04 03:28	alex	File Added: page_login_ssl_redirect_feature_themes.patch
2012-01-04 03:28	alex	File Added: page_login_ssl_redirect_feature_core.patch
2012-01-04 03:26	alex	Relationship added	related to 0001189
2012-01-03 18:04	Dmitry	Note Edited: 0004358	View Revisions
2011-12-29 18:24	Dmitry	Note Added: 0004358
2011-12-29 18:24	Dmitry	Assigned To	Dmitry => alex
2011-10-22 05:27	alex	Estimate Points	=> 1
2011-10-16 18:00	Dmitry	Note Added: 0004055
2011-10-16 18:00	Dmitry	Assigned To	=> Dmitry
2011-10-16 18:00	Dmitry	Status	active => needs work
2011-10-16 18:00	Dmitry	Target Version	Icebox => 5.2.0
2011-09-27 13:00	Dmitry	Change Log Message	=> Added SSL and Login Required check-boxes for Sections
2011-09-27 12:59	Dmitry	Reference	=> https://groups.google.com/d/topic/in-portal-dev/ZfCLO4FbDi0/discussion
2010-08-31 14:25	alex	version	=> 5.1.0
2009-10-21 03:47	alex	Note Edited: 0000943	View Revisions
2009-10-21 03:46	alex	Note Edited: 0000943	View Revisions
2009-10-21 03:46	alex	Note Edited: 0000943	View Revisions
2009-10-21 03:41	alex	Note Added: 0000943
2009-10-18 16:14	Dmitry	Description Updated	View Revisions
2009-10-18 16:13	Dmitry	New Issue

Web Development by Intechnic

In-Portal Open Source CMS