In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000273 [In-Portal CMS] Optimization task always 2009-09-05 08:37 2010-05-11 02:59
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.0.3-B1
Status closed Product Version 5.0.0 Target Version 5.0.3
Time EstimateNo estimate
Summary 0000273: Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3
Description Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3
Additional Information
Tags No tags attached.
Reference
Change Log Message
Estimate Points 0
Attached Files patch file icon 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100211-v1-CORE.patch [^] (2,374 bytes) 2010-02-11 16:21 [Show Content]
patch file icon 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100211-v1-In-Commerce.patch [^] (5,976 bytes) 2010-02-11 19:08 [Show Content]
patch file icon 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100314-v2-CORE.patch [^] (2,618 bytes) 2010-03-14 23:00 [Show Content]
patch file icon 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100314-v2-In-Commerce.patch [^] (5,906 bytes) 2010-03-15 00:10 [Show Content]
patch file icon 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100315-v3-CORE.patch [^] (12,687 bytes) 2010-03-15 15:01 [Show Content]
patch file icon 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100315-v3-In-Commerce.patch [^] (5,977 bytes) 2010-03-15 15:12 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to 0000236closed (5.0.2)alex Don't use preg_replace for removing trailing words in strings 

-  Notes
User avatar (0000400)
alex (manager)
2009-09-05 09:13

There are still some places left with more complex regular expressions in kDateFormatter and other classes.
User avatar (0000401)
Dmitry (manager)
2009-09-05 16:31

Which Release we are doing this for? 5.0.1 or 5.1.0?
User avatar (0000406)
alex (manager)
2009-09-07 01:23

For now it's partially done for 5.0.x and what's done is merged to 5.1.x as you can see by commit log bellow.
User avatar (0000532)
alex (manager)
2009-09-23 13:18

Plan:
1. only left in order credit card and payment gateway response processing and in some places in fck editor.
User avatar (0000826)
alex (manager)
2009-10-06 13:58

Moving to 5.0.3 because of too much work. Also much of this is already done already.
User avatar (0001478)
Dmitry (manager)
2010-02-11 19:12

Patches attached - please review and test.

There might be some changes needed to regex - let me know.
User avatar (0001550)
alex (manager)
2010-03-11 05:13
edited on: 2010-03-11 05:48

Core patch for fck doesn't work, since you missed "(" and ")" while moving file extension regexp to constant. You should remove "$" from regexp and use it like (contant)$ where that contant is used. Verify, that you see proper file icons in fck file manager, since I'm seeing default icon for all files now.

In-commerce patch uses "str_ireplace" function which is for PHP5 only and in-commerce payment gateways will stop working on PHP4. Also why are you using case insensitive replace function, when you are replacing "." and ",", since they don't have case at all.

Also why you using "i" and "g" preg_* modifiers with regular expressions that doesn't have case sensitive characters in them. And there is not "g" modifier (see http://lv.php.net/manual/en/reference.pcre.pattern.modifiers.php).

Also you have lost part of regex during conversion to preg function in PhoneClean method.

Also there is special php function file extension detection and we should use regex or additional constants for that.

User avatar (0001567)
Dmitry (manager)
2010-03-11 23:46

Reminder sent to: alex

DID you mean:

Also there is special php function file extension detection and we should NOT use regex or additional constants for that?

instead of:

Also there is special php function file extension detection and we should use regex or additional constants for that.
User avatar (0001576)
alex (manager)
2010-03-12 02:57

That's probably what I meant to say: use special function instead of regex here.
User avatar (0001611)
Dmitry (manager)
2010-03-15 15:14

Redone both patches - please test v3 of the patches.

NOTES: in CORE patch there is a very minor fix for Images path in core/admin_templates/browser/frmresourceslist.tpl template
User avatar (0001679)
alex (manager)
2010-03-17 12:52

ok
User avatar (0001680)
alex (manager)
2010-03-17 12:54

Fix committed to 5.0.x branch. Commit Message:

1. Fixes 0000273: Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3
2. Commit on behalf of Dmitry.
User avatar (0002124)
alex (manager)
2010-05-11 02:59

Closing all tasks from released versions.

- Related Changesets
In-Portal CMS: 5.0.x r13263
Timestamp: 2010-03-17 12:54:16
Author: alex
Details ] Diff ]
1. Fixes 0000273: Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3
2. Commit on behalf of Dmitry.
mod - /in-portal/branches/5.0.x/core/admin_templates/browser/frmresourceslist.tpl Diff ] File ]
mod - /in-portal/branches/5.0.x/core/units/fck/fck_tp.php Diff ] File ]
mod - /in-portal/branches/5.0.x/core/units/helpers/fck_helper.php Diff ] File ]
Modules :: In-Commerce: 5.0.x r13262
Timestamp: 2010-03-17 12:53:25
Author: alex
Details ] Diff ]
1. Bug 0000273: Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3
2. Commit on behalf of Dmitry.
mod - /w/in-commerce/branches/5.0.x/units/gateways/gw_classes/atosorigin.php Diff ] File ]
mod - /w/in-commerce/branches/5.0.x/units/gateways/gw_classes/ideal_nl.php Diff ] File ]
mod - /w/in-commerce/branches/5.0.x/units/gateways/gw_classes/paybox.php Diff ] File ]
mod - /w/in-commerce/branches/5.0.x/units/orders/orders_item.php Diff ] File ]
mod - /w/in-commerce/branches/5.0.x/units/products/products_event_handler.php Diff ] File ]
mod - /w/in-commerce/branches/5.0.x/units/shipping_quote_engines/usps.php Diff ] File ]
In-Portal CMS: 5.0.x r12510
Timestamp: 2009-09-15 12:21:08
Author: alex
Details ] Diff ]
Bug 0000273: Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3
mod - /in-portal/branches/5.0.x/core/kernel/utility/formatters/date_formatter.php Diff ] File ]
Modules :: In-Commerce: 5.1.x r12456
Timestamp: 2009-09-05 09:12:22
Author: alex
Details ] Diff ]
1. Bug 0000273: Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3
2. Merging from 5.0.x to 5.1.x.
mod - /in-commerce/branches/5.1.x/in-commerce/units Diff ] File ]
mod - /in-commerce/branches/5.1.x/in-commerce/units/orders/orders_event_handler.php Diff ] File ]
mod - /in-commerce/branches/5.1.x/in-commerce/units/shipping_quote_engines/usps.php Diff ] File ]
Modules :: Custom: 1.1.x r12454
Timestamp: 2009-09-05 09:11:59
Author: alex
Details ] Diff ]
1. Bug 0000273: Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3
2. Merging from 5.0.x to 5.1.x.
mod - /custom/branches/1.1.x/custom/units/sections/custom_eh.php Diff ] File ]
In-Portal CMS: 5.1.x r12453
Timestamp: 2009-09-05 09:11:39
Author: alex
Details ] Diff ]
1. Bug 0000273: Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3
2. Merging from 5.0.x to 5.1.x.
mod - /in-portal/branches/5.1.x/core/install Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install/install_toolkit.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/globals.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/languages/phrases_cache.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/nparser/nparser.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/session/session.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/utility/debugger.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/admin/admin_events_handler.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/admin/admin_tag_processor.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/general Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/users/users_tag_processor.php Diff ] File ]
Modules :: In-Commerce: 5.0.x r12451
Timestamp: 2009-09-05 08:57:08
Author: alex
Details ] Diff ]
Bug 0000273: Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3
mod - /in-commerce/branches/5.0.x/in-commerce/units/orders/orders_event_handler.php Diff ] File ]
mod - /in-commerce/branches/5.0.x/in-commerce/units/shipping_quote_engines/usps.php Diff ] File ]
In-Portal CMS: 5.0.x r12450
Timestamp: 2009-09-05 08:39:05
Author: alex
Details ] Diff ]
1. Bug 0000273: Get rid of ereg* functions usage, because they are slow and are deprecated since PHP 5.3.
2. Debugger compatibility with PHP 5.3.
mod - /in-portal/branches/5.0.x/core/install/install_toolkit.php Diff ] File ]
mod - /in-portal/branches/5.0.x/core/kernel/globals.php Diff ] File ]
mod - /in-portal/branches/5.0.x/core/kernel/languages/phrases_cache.php Diff ] File ]
mod - /in-portal/branches/5.0.x/core/kernel/nparser/nparser.php Diff ] File ]
mod - /in-portal/branches/5.0.x/core/kernel/session/session.php Diff ] File ]
mod - /in-portal/branches/5.0.x/core/kernel/utility/debugger.php Diff ] File ]
mod - /in-portal/branches/5.0.x/core/units/admin/admin_events_handler.php Diff ] File ]
mod - /in-portal/branches/5.0.x/core/units/admin/admin_tag_processor.php Diff ] File ]
mod - /in-portal/branches/5.0.x/core/units/users/users_tag_processor.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-05-11 02:59 alex Note Added: 0002124
2010-05-11 02:59 alex Status resolved => closed
2010-03-17 12:54 alex Note Added: 0001680
2010-03-17 12:54 alex Status reviewed and tested => resolved
2010-03-17 12:54 alex Fixed in Version => 5.0.3-B1
2010-03-17 12:54 alex Resolution open => fixed
2010-03-17 12:54 alex Assigned To !COMMUNITY => alex
2010-03-17 12:54 alex Changeset attached 5.0.x r13263
2010-03-17 12:53 alex Changeset attached 5.0.x r13262
2010-03-17 12:52 alex Note Added: 0001679
2010-03-17 12:52 alex Status needs testing => reviewed and tested
2010-03-15 15:14 Dmitry Note Added: 0001611
2010-03-15 15:14 Dmitry Status needs work => needs testing
2010-03-15 15:12 Dmitry File Added: 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100315-v3-In-Commerce.patch
2010-03-15 15:01 Dmitry File Added: 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100315-v3-CORE.patch
2010-03-15 00:10 Dmitry File Added: 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100314-v2-In-Commerce.patch
2010-03-14 23:00 Dmitry File Added: 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100314-v2-CORE.patch
2010-03-12 02:57 alex Note Added: 0001576
2010-03-11 23:46 Dmitry Note Added: 0001567
2010-03-11 05:48 alex Note Edited: 0001550 View Revisions
2010-03-11 05:13 alex Note Added: 0001550
2010-03-11 05:13 alex Assigned To alex => !COMMUNITY
2010-03-11 05:13 alex Status needs testing => needs work
2010-02-26 16:53 Dmitry Developer => Dmitry
2010-02-11 19:12 Dmitry Time Estimate Removed 2 =>
2010-02-11 19:12 Dmitry Note Added: 0001478
2010-02-11 19:12 Dmitry Status active => needs testing
2010-02-11 19:08 Dmitry File Added: 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100211-v1-In-Commerce.patch
2010-02-11 19:08 Dmitry File Deleted: 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100211-v1-In-Commerce.patch
2010-02-11 19:06 Dmitry File Added: 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100211-v1-In-Commerce.patch
2010-02-11 16:21 Dmitry File Added: 273-Get_rid_of_ereg_functions_usage_because_slow_and_deprecated-Dmitry-20100211-v1-CORE.patch
2009-10-06 14:23 alex Type bug report => task
2009-10-06 13:58 alex Note Added: 0000826
2009-10-06 13:58 alex Target Version 5.0.2 => 5.0.3
2009-10-03 07:54 administrator Status needs work => active
2009-09-23 13:18 alex Time Estimate Added 2
2009-09-23 13:18 alex Note Added: 0000532
2009-09-20 15:11 alex Target Version 5.1.0 => 5.0.2
2009-09-15 12:21 alex Changeset attached 5.0.x r12510
2009-09-14 15:39 alex Relationship added related to 0000236
2009-09-07 01:23 alex Note Added: 0000406
2009-09-07 01:23 alex Status needs feedback => needs work
2009-09-05 18:54 Dmitry Target Version => 5.1.0
2009-09-05 16:31 Dmitry Note Added: 0000401
2009-09-05 16:31 Dmitry Assigned To => alex
2009-09-05 16:31 Dmitry Status active => needs feedback
2009-09-05 09:13 alex Note Added: 0000400
2009-09-05 09:12 alex Changeset attached 5.1.x r12456
2009-09-05 09:12 alex Changeset attached 5.1.x r12455
2009-09-05 09:12 alex Changeset attached 1.1.x r12454
2009-09-05 09:11 alex Changeset attached 5.1.x r12453
2009-09-05 08:59 alex Changeset attached 5.0.x r12452
2009-09-05 08:57 alex Changeset attached 5.0.x r12451
2009-09-05 08:39 alex Changeset attached 5.0.x r12450
2009-09-05 08:37 alex New Issue



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker