In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Type

Reproducibility

Date Submitted

Last Update

0001389

[In-Portal CMS] Front End

bug report

always

2012-09-04 09:41

2012-09-04 09:43

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.1-B1

Status

resolved

Product Version

5.0.0

Target Version

5.2.1

Time Estimate

No estimate

Summary

0001389: Tag c_ContentPageLink builds broken link

Description

When you're printing a sitemap with links to all sections (pages) from a website on it you need to have solid tag to build a link to each page.
Right now there is tag <inp2:CategoryLink template='__default__'/> that does that.

Tag CategoryLink threats a section as a category and populates category_id in a link, but uses keeps template empty (if template parameter is set to "__default__") at the end.
Resulting link is valid because category url itself is a virtual template.

However if developer wants to rewrite some urls on the website and matches template name to an url he sees then nothing would happen, because as I've mentioned template name is empty.
Fortunately we have ContentPageLink that does the job. But over time (since nobody uses it) it broke. Both tags build same url at the end, however with ContentPageLink tag 't' parameter in rewrite listeners isn't empty.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-dev/C-ohuxNHFfc/discussion

Change Log Message

Fixes bug in c_ContentPageLink tag

Estimate Points

Attached Files

contentpagelink_tag_fix.patch [^] (698 bytes) 2012-09-04 09:41 [Show Content]

Index: categories_tag_processor.php
===================================================================
--- categories_tag_processor.php	(revision 15437)
+++ categories_tag_processor.php	(working copy)
@@ -1885,7 +1885,7 @@
 	}
 
 	/**
-	 * Builds link to cms page (used?)
+	 * Builds link to category as a cms page
 	 *
 	 * @param Array $params
 	 * @return string
@@ -1895,7 +1895,7 @@
 		$object = $this->getObject($params);
 		/* @var $object kDBItem */
 
-		$params['t'] = $object->GetDBField('NamedParentPath');
+		$params['t'] = mb_strtolower($object->GetDBField('NamedParentPath'));
 		$params['m_cat_id'] = 0;
 
 		return $this->Application->ProcessParsedTag('m', 'Link', $params);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0005166) alex (manager) 2012-09-04 09:43	Will test all together later.

(0005167) alex (manager) 2012-09-04 09:43	Fix committed to 5.2.x branch. Commit Message: Fixes 0001389: Tag c_ContentPageLink builds broken link

Related Changesets
In-Portal CMS: 5.2.x r15531 Timestamp: 2012-09-04 09:43:32 Author: alex [ Details ] [ Diff ]	Fixes 0001389: Tag c_ContentPageLink builds broken link
	mod - /in-portal/branches/5.2.x/core/units/categories/categories_tag_processor.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-09-04 09:43	alex	Changeset attached	5.2.x r15531
2012-09-04 09:43	alex	Note Added: 0005167
2012-09-04 09:43	alex	Status	reviewed and tested => resolved
2012-09-04 09:43	alex	Fixed in Version	=> 5.2.1-B1
2012-09-04 09:43	alex	Resolution	open => fixed
2012-09-04 09:43	alex	Assigned To	!COMMUNITY => alex
2012-09-04 09:43	alex	Note Added: 0005166
2012-09-04 09:43	alex	Status	needs testing => reviewed and tested
2012-09-04 09:43	alex	Assigned To	=> !COMMUNITY
2012-09-04 09:43	alex	Developer	=> alex
2012-09-04 09:43	alex	Status	active => needs testing
2012-09-04 09:42	alex	Reference	=> https://groups.google.com/d/topic/in-portal-dev/C-ohuxNHFfc/discussion
2012-09-04 09:41	alex	New Issue
2012-09-04 09:41	alex	File Added: contentpagelink_tag_fix.patch
2012-09-04 09:41	alex	Change Log Message	=> Fixes bug in c_ContentPageLink tag
2012-09-04 09:41	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS