In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001277 [In-Portal CMS] Admin Interfaces bug report always 2012-05-15 15:33 2012-07-25 05:30
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.2.0-RC1
Status closed Product Version 4.3.9 Target Version 5.2.0
Time EstimateNo estimate
Summary 0001277: "TypeError" Javascript error cased by getFrame in Admin
Description In-Portal uses getFrame method to reach it's main window (when working with Admin Console) by intellectually traversing through all opened windows and frames (see "getFrame" javascript method).

However this "getFrame" method can return a reference outside Admin Console frameset at all. For example to a window/tab, that had a link to an Admin Console.

There are 2 ways to prevent this:
don't check for window.opener when we're already in frameset main window
check if found window.location.hostname of found window is the same as one we're started traversing with (basically same domain+base_path)

Without this if you're opening in-portal windows using links on other websites and not by directly typing url you might see problem described above.
Additional Information
Tags No tags attached.
Change Log Message Fixed "TypeError" javascript error in Admin
Estimate Points 1
Attached Files patch file icon type_error_on_modal_window_open.patch [^] (1,140 bytes) 2012-05-29 10:05 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0004684)
alex (manager)
2012-05-30 04:16

Tested by Dmitry, but forgot to indicate it here.
User avatar (0004685)
alex (manager)
2012-05-30 04:17

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001277: "TypeError" Javascript error cased by getFrame in Admin
User avatar (0004879)
alex (manager)
2012-07-25 05:30

Since 5.2.0/1.2.0 versions was released.

- Related Changesets
In-Portal CMS: 5.2.x r15372
Timestamp: 2012-05-30 04:17:19
Author: alex
Details ] Diff ]
Fixes 0001277: "TypeError" Javascript error cased by getFrame in Admin
mod - /in-portal/branches/5.2.x/core/admin_templates/js/script.js Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:30 alex Note Added: 0004879
2012-07-25 05:30 alex Status resolved => closed
2012-05-30 04:17 alex Changeset attached 5.2.x r15372
2012-05-30 04:17 alex Note Added: 0004685
2012-05-30 04:17 alex Status reviewed and tested => resolved
2012-05-30 04:17 alex Fixed in Version => 5.2.0-RC1
2012-05-30 04:17 alex Resolution open => fixed
2012-05-30 04:17 alex Assigned To !COMMUNITY => alex
2012-05-30 04:16 alex Note Added: 0004684
2012-05-30 04:16 alex Assigned To Dmitry => !COMMUNITY
2012-05-30 04:16 alex Status needs testing => reviewed and tested
2012-05-29 10:05 alex Assigned To => Dmitry
2012-05-29 10:05 alex Developer => alex
2012-05-29 10:05 alex Status active => needs testing
2012-05-29 10:05 alex Estimate Points 0 => 1
2012-05-29 10:05 alex File Added: type_error_on_modal_window_open.patch
2012-05-15 15:33 Dmitry New Issue
2012-05-15 15:33 Dmitry Reference =>
2012-05-15 15:33 Dmitry Change Log Message => Fixed "TypeError" javascript error in Admin
2012-05-15 15:33 Dmitry Estimate Points => 0

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker