In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001151

[In-Portal CMS] Caching System

bug report

always

2011-10-26 21:25

2012-07-25 05:32

Reporter

Dmitry

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.0-B1

Status

closed

Product Version

5.1.0

Target Version

5.2.0

Time Estimate

No estimate

Summary

0001151: Caching Issue with 404 Page Not Found URLs

Description

There is an issue with Caching "404 Page Not Found" URLs.

If user visits url of a page, that doesn't exist yet, then it will be marked as "Not Found" in CachedUrls table.

If administrator will create such page later, then it will be shown as "Not Found" at Front-end.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/WLrSF2CbQN4/discussion

Change Log Message

Fixed caching issue for 404 urls

Estimate Points

1

no_404_url_caching.patch [^] (722 bytes) 2011-11-07 05:24 [Show Content]

Index: kernel/managers/rewrite_url_processor.php
===================================================================
--- kernel/managers/rewrite_url_processor.php	(revision 14733)
+++ kernel/managers/rewrite_url_processor.php	(working copy)
@@ -139,7 +139,10 @@
 			$passed = $vars['pass']; // also used in bottom of this method
 			unset($vars['pass']);
 
-			$this->_setCachedUrl($url, Array ('vars' => $vars, 'passed' => $passed));
+			if ( !$this->_partsToParse ) {
+				// don't cache 404 Not Found
+				$this->_setCachedUrl($url, Array ('vars' => $vars, 'passed' => $passed));
+			}
 
 			if ( $this->Application->GetVarDirect('t', 'Post') ) {
 				// template from POST overrides template from URL.

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0004116) Dmitry (manager) 2011-11-01 23:05	Please go ahead and implement this fix in 5.2.0.

(0004138) alex (manager) 2011-11-07 05:25	Will test all together later.

(0004139) alex (manager) 2011-11-07 05:26	Fix committed to 5.2.x branch. Commit Message: Fixes 0001151: Caching Issue with 404 Page Not Found URLs

(0005060) alex (manager) 2012-07-25 05:32	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r14737 Timestamp: 2011-11-07 05:26:25 Author: alex [ Details ] [ Diff ]	Fixes 0001151: Caching Issue with 404 Page Not Found URLs
	mod - /in-portal/branches/5.2.x/core/kernel/managers/rewrite_url_processor.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:32	alex	Note Added: 0005060
2012-07-25 05:32	alex	Status	resolved => closed
2011-11-07 05:26	alex	Note Added: 0004139
2011-11-07 05:26	alex	Status	reviewed and tested => resolved
2011-11-07 05:26	alex	Fixed in Version	=> 5.2.0-B1
2011-11-07 05:26	alex	Resolution	open => fixed
2011-11-07 05:26	alex	Assigned To	!COMMUNITY => alex
2011-11-07 05:26	alex	Changeset attached	5.2.x r14737
2011-11-07 05:25	alex	Note Added: 0004138
2011-11-07 05:25	alex	Status	needs testing => reviewed and tested
2011-11-07 05:25	alex	Assigned To	alex => !COMMUNITY
2011-11-07 05:25	alex	Developer	=> alex
2011-11-07 05:25	alex	Status	needs work => needs testing
2011-11-07 05:24	alex	File Added: no_404_url_caching.patch
2011-11-01 23:05	Dmitry	Assigned To	=> alex
2011-11-01 23:05	Dmitry	Status	active => needs work
2011-11-01 23:05	Dmitry	Note Added: 0004116
2011-10-26 21:25	Dmitry	Estimate Points	0 => 1
2011-10-26 21:25	Dmitry	New Issue
2011-10-26 21:25	Dmitry	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/WLrSF2CbQN4/discussion
2011-10-26 21:25	Dmitry	Change Log Message	=> Fixed caching issue for 404 urls
2011-10-26 21:25	Dmitry	Estimate Points	=> 0

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group