In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001128 [In-Portal CMS] Front End feature request always 2011-09-27 06:48 2012-07-25 05:30
Reporter erik View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.2.0-B1
Status closed Product Version Target Version 5.2.0
Time EstimateNo estimate
Summary 0001128: Implement "Promo Blocks" functionality as on Intechnic.com
Description Implement Banner System as on Intechnic.com (all changes made in Admin Console only).

1. each promo block will have:
a) Title
b) Text (CMS) block -- nado pomimo karitnok davayt vomzshnost srazu vvodit rich text na promob blocke (pervh backgrounda)
c) Image
d) Status
e) Order
f) Link
g) Schedule (from to) - show promo blocks on front-end only, when they are enabled and current date is within promo block schedule interval

2. new promo blocks are added at the end of the list and later on could be moved up/down via "Move Up" and "Move Down" grid toolbar buttons

3. implement counters (copy from Intechnic.com):
Number of Clicks, Number of Views, CTR (Click Through Ratio: % clicks ot views) with ability to reset counters for individual promo blocks via "Reset Counters" toolbar button

4. Configuration sub-section under "Website -> Configuration -> Advanced" with 3 configuration variables:
a) Transition Effect (ya bi postavil bi vozmoshnost' vibora animatsii)
b) Transition Delay (in seconds)
c) Transition Controls (Enabled/Disabled)- pokazivat intefaci perehoda: [1][2][[3] ili net.
Additional Information We need to Improve currently implemented and committed functionality by introducing the ability to have multiple Promo Blocks grouped into a single Promo Block Group which later can be assigned to a specific Catalog Section (when adding/editing) to auto-print associated Promo Block on that section on the Front end.


Below is the plan of action for implementing changes to "Promo Blocks":


1. Change currently implemented Promo Blocks section to work the same way as Forms:

a. ability to Add/Edit a "Promo Block Group". Need to add a new table (ie. PromoBlockGroups) which will group promo groups together, plus hold their settings (that are now located under "Promo Blocks" configuration section).

b. same as Forms make sure Promo Blocks section is hidden in Simple preset, however it can be visible with DEBUG ON while in Simple preset. The ability to Add Promo Block Groups in Simple preset should be controlled with similar to Forms 'Show "Forms Editor" in DEBUG mode only' setting when Admin can see a toolbar and Add Promo Block Group in Simple preset ONLY if "Show "Promo Blocks Editor" in DEBUG mode only" is set to ON.


2. Each "Promo Block Group" should have these fields:

General:
- ID
- Title (Varchar 255, which will be used in Main Admin Menu once added)
- CreatedOn
- Status (Active, Disabled)
- AssignedToSections (lists sections that have this Group assigned to separated by comma; read-only)

Move current "Promo Settings" from Website -> Configuration -> Advanced under each "Promo Block Group".

Settings:
PromoRotationDelay - Promo Rotation Delay (seconds):
PromoTransitionTime - Transition Delay (seconds):
PromoTransitionControls - Promo Transition Controls:
PromoTransitionEffect - Promo Transition Effect: (Fade, Slide, Custom - NEW option with value -1 )
PromoTransitionEffectCustom - Promo Transition Custom Effect: (textarea which will be shown is Custom option is selected above so Developer can put there some custom value - whatever he wants)

NOTE: in the future we night need to add more of these settings


3. Implement Toolbar for managing "Promo Block Groups"

Buttons with standard functionality - Add, Edit, Delete, Enable, Disable, View


4. Add new field called "PromoBlockGroupId" to Category & PromoBlocks tables.

On new field to Add/Edit Section interface after "Menu Status" field as a Drop-down with all Promo Block Groups listed and sorted by Title ASC


5. Adjust Front-end implementation so it lists Promo Block from corresponding Promo Block Group on the section.

a. We might need to create a new Tag for this which will check and use PromoBlockGroupId
b. Teach the tag to accept PromoBlockGroupId as a parameter so we can actually call this tag ANYWHERE we need and feed it an ID (by hand) so it will do the trick for us even if it has not been assigned to that Section/template. Will make things easier to customize if needed.


NOTE:

a. We need to reset and refresh Admin Menu when we Add/Edit a Promo Block Group.
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-dev/huW9qzBVQiI/discussion
Change Log Message Implemented new "Promo Blocks" functionality
Estimate Points 1
Attached Files patch file icon promo.patch [^] (40,260 bytes) 2011-09-27 12:03 [Show Content]
patch file icon promo_theme.patch [^] (10,959 bytes) 2011-09-27 12:03 [Show Content]
patch file icon promo_blocks_core_v2.patch [^] (60,181 bytes) 2011-12-08 08:39 [Show Content]
patch file icon promo_blocks_themes_v2.patch [^] (18,571 bytes) 2011-12-08 08:42 [Show Content]
patch file icon promo_blocks_core_v2-MissingDropSchema.patch [^] (311 bytes) 2011-12-19 18:10 [Show Content]
patch file icon promo_blocks_core_v3_1128.patch [^] (75,325 bytes) 2011-12-27 09:54 [Show Content]
patch file icon promo_blocks_themes_v3_1128.patch [^] (3,914 bytes) 2011-12-27 09:54 [Show Content]
patch file icon promo_block_groups_core_v4.patch [^] (60,592 bytes) 2011-12-28 07:59 [Show Content]
patch file icon promo_block_groups_themes_v4.patch [^] (2,449 bytes) 2011-12-28 07:59 [Show Content]
patch file icon promo_block_group_php_syntax_fix.patch [^] (1,086 bytes) 2012-01-06 05:59 [Show Content]
patch file icon promo_block_images_deleted_fix.patch [^] (709 bytes) 2012-01-10 08:40 [Show Content]
zip file icon PromoBlocks-513.zip [^] (449,372 bytes) 2012-02-24 10:34

- Relationships Relation Graph ] Dependency Graph ]
parent of 0001290closed (5.2.0)alex Minor Improvements to Promo Blocks 

-  Notes
User avatar (0004221)
Dmitry (manager)
2011-12-07 18:10

Please have this committed into 5.2.0 + create Modern-Store theme patch too + commit there.
User avatar (0004230)
alex (manager)
2011-12-08 08:43

Will test all together later.
User avatar (0004231)
alex (manager)
2011-12-08 08:45

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001128: Implement "Promo Blocks" functionality as on Intechnic.com
User avatar (0004271)
Dmitry (manager)
2011-12-18 21:16

We need to Improve currently implemented and committed functionality by introducing the ability to have multiple Promo Blocks grouped into a single Promo Block Group which later can be assigned to a specific Catalog Section (when adding/editing) to auto-print associated Promo Block on that section on the Front end.

Please see updated "Additional Information" section.
User avatar (0004273)
Dmitry (manager)
2011-12-18 23:44

Reminder sent to: alex

Alex, please review updated description and submit any issues + estimated time for implementation.
User avatar (0004281)
alex (manager)
2011-12-20 03:58

3h quote for additions required.
User avatar (0004296)
alex (manager)
2011-12-22 03:16

This is plan for not so obvious moments from tasks's Additional Information field:


1. create PromoBlockGroups table & associated section

2. transform existing promo block configuration settings into a columns in a newly created PromoBlockGroups table; delete unused "la_config_*" phrases from deleted configuration section

3. make current "Promo Blocks" item in tree display a list of promo block groups (+move section declaration to new unit config)

4. make clicking on new "Promo Blocks" section expand and show a subsection for each promo block group created (the way it's done in "Structure & Data" section via ajax query)

5. on add/remove/edit of a promo block reload promo-block related tree part (via ajax query, like in "Structure & Data" section)

6. add "group_id" parameter into promo-block:SetCustomQuery method; when passed then display promo blocks, associated with given group; when not passed then show promo blocks from group, that is specified in current section

7. add new configuration variable (under existing "DebugOnlyFormConfigurator"), that when enabled (will be enabled by default) will make clicking on "Promo Blocks" section display promo blocks from first group and not promo block group manager (see how it's done with DebugOnlyFormConfigurator config variable)

8. create "Settings" toolbar button on promo block list, that would open current group editing page (this way we allow for admin to change promo block settings, without ability to add new promo block groups)

9. create first empty promo block group after clean install/upgrade.
User avatar (0004327)
erik (manager)
2011-12-27 09:55

v3 patches attached - needs testing
User avatar (0004334)
alex (manager)
2011-12-28 07:59

1. all new functionality must be hidden by default in "simple" interface preset (inluding new category fields)
2. remove schema was missing for PromoBlockGroups table
3. sql error in PromoBlockGroups table insert statement
4. custom transition effect is shown (when opening promo block group), even when transition effect isn't set to "custom"
5. custom transition effect & promo block group heading phrases were not translated
6. 2 of new phrases not sorted properly
7. pressing Cancel button on promo block editing page resulted in Fatal Error due missing "group_id" in url
8. no icon in the grid of promo block groups to correspond promo block group status
9. no need to define element for a custom form control, that is used only once, since now we have "form_row" design
10. in 5.2.0 many things can be done without involving session at all, e.g. passing flags to parent window after redirect, etc.
11. theme patch attached wasn't from "modern-store" theme
12. current category id was used instead of promo block group id specified in current section
13. section "in-portal:promo_blocks" was still used instead of newly created "in-portal:promo_block_groups" section
14. setting non-empty default values for promo blog group fields, that has free input control resulted in default value used when none was specified
User avatar (0004335)
alex (manager)
2011-12-28 08:01

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001128: Implement "Promo Blocks" functionality as on Intechnic.com
1. added promo block group feature, that groups promo blocks together
User avatar (0004392)
alex (manager)
2012-01-06 05:59

Patch "promo_block_group_php_syntax_fix.patch" fixes php syntax error in simple interface preset, that resulted in SQL error during installation.
User avatar (0004403)
alex (manager)
2012-01-10 08:41

Patch "promo_block_images_deleted_fix.patch" fixes issue, when promo block images were deleted by scheduled task, that deletes unused images under /system/images folder.
User avatar (0004479)
Dmitry (manager)
2012-02-24 10:34

Attached PromoBlocks-513.zip file which includes necessary patches for In-Portal 5.1.3.
User avatar (0004898)
alex (manager)
2012-07-25 05:30

Since 5.2.0/1.2.0 versions was released.

- Related Changesets
In-Portal CMS: 5.2.x r15040
Timestamp: 2012-01-13 09:21:07
Author: alex
Details ] Diff ]
Bug 0001128: Implement "Promo Blocks" functionality as on Intechnic.com
1. adding icons
add - /in-portal/branches/5.2.x/core/admin_templates/img/icons/icon24_promo_block_groups.png File ]
add - /in-portal/branches/5.2.x/core/admin_templates/img/icons/icon24_promo_blocks.png File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/promo_block_groups/tree_section_xml.tpl Diff ] File ]
In-Portal CMS: 5.2.x r15034
Timestamp: 2012-01-10 08:42:11
Author: alex
Details ] Diff ]
Bug 0001128: Implement "Promo Blocks" functionality as on Intechnic.com
1. fixes issue, when promo block images were deleted by scheduled task, that deletes unused images under /system/images folder
mod - /in-portal/branches/5.2.x/core/units/promo_blocks/promo_block_eh.php Diff ] File ]
In-Portal CMS: 5.2.x r14997
Timestamp: 2012-01-06 06:00:10
Author: alex
Details ] Diff ]
Bug 0001128: Implement "Promo Blocks" functionality as on Intechnic.com
1. php syntax error in simple interface preset, that resulted in SQL error during installation
mod - /in-portal/branches/5.2.x/admin/system_presets/simple/categories_c.php Diff ] File ]
In-Portal CMS: 5.2.x r14929
Timestamp: 2011-12-28 08:01:17
Author: alex
Details ] Diff ]
Fixes 0001128: Implement "Promo Blocks" functionality as on Intechnic.com
1. added promo block group feature, that groups promo blocks together
mod - /in-portal/branches/5.2.x/admin/system_presets/simple/categories_c.php Diff ] File ]
add - /in-portal/branches/5.2.x/admin/system_presets/simple/promo_block_groups_promo-block-group.php File ]
mod - /in-portal/branches/5.2.x/admin/system_presets/simple/sections_core-sections.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/categories/categories_edit.tpl Diff ] File ]
add - /in-portal/branches/5.2.x/core/admin_templates/promo_block_groups File ]
add - /in-portal/branches/5.2.x/core/admin_templates/promo_block_groups/promo_block_group_edit.tpl File ]
add - /in-portal/branches/5.2.x/core/admin_templates/promo_block_groups/promo_block_group_list.tpl File ]
add - /in-portal/branches/5.2.x/core/admin_templates/promo_block_groups/section_reload.tpl File ]
add - /in-portal/branches/5.2.x/core/admin_templates/promo_block_groups/tree_section_xml.tpl File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/promo_blocks/promo_block_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/promo_blocks/promo_block_list.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/tree.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/english.lang Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/install_data.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/install_schema.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/remove_schema.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/upgrades.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/categories/categories_config.php Diff ] File ]
add - /in-portal/branches/5.2.x/core/units/promo_block_groups File ]
add - /in-portal/branches/5.2.x/core/units/promo_block_groups/promo_block_group_eh.php File ]
add - /in-portal/branches/5.2.x/core/units/promo_block_groups/promo_block_group_tp.php File ]
add - /in-portal/branches/5.2.x/core/units/promo_block_groups/promo_block_groups_config.php File ]
mod - /in-portal/branches/5.2.x/core/units/promo_blocks/promo_block_eh.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/promo_blocks/promo_block_tp.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/promo_blocks/promo_blocks_config.php Diff ] File ]
Themes :: Modern-Store: 1.0.x r14928
Timestamp: 2011-12-28 08:00:42
Author: alex
Details ] Diff ]
Bug 0001128: Implement "Promo Blocks" functionality as on Intechnic.com
1. added promo block group feature, that groups promo blocks together
mod - /themes/modern-store/branches/1.0.x/elements/promo.elm.tpl Diff ] File ]
mod - /themes/modern-store/branches/1.0.x/index.tpl Diff ] File ]
In-Portal CMS: 5.2.x r14886
Timestamp: 2011-12-19 18:12:18
Author: Dmitry
Details ] Diff ]
Bug 0001128: Implement "Promo Blocks" functionality as on Intechnic.com
1. DROP was missing for PromoBlocks table in remove_schema.sql
mod - /in-portal/branches/5.2.x/core/install/remove_schema.sql Diff ] File ]
In-Portal CMS: 5.2.x r14853
Timestamp: 2011-12-08 08:45:37
Author: alex
Details ] Diff ]
Fixes 0001128: Implement "Promo Blocks" functionality as on Intechnic.com
add - /in-portal/branches/5.2.x/admin/system_presets/simple/promo_blocks_promo-block.php File ]
mod - /in-portal/branches/5.2.x/admin/system_presets/simple/sections_core-sections.php Diff ] File ]
add - /in-portal/branches/5.2.x/core/admin_templates/promo_blocks File ]
add - /in-portal/branches/5.2.x/core/admin_templates/promo_blocks/promo_block_edit.tpl File ]
add - /in-portal/branches/5.2.x/core/admin_templates/promo_blocks/promo_block_list.tpl File ]
mod - /in-portal/branches/5.2.x/core/install/english.lang Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/install_data.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/install_schema.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/upgrades.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/upgrades.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/constants.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/logs/change_logs/change_logs_config.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/priorites/priorites_config.php Diff ] File ]
add - /in-portal/branches/5.2.x/core/units/promo_blocks File ]
add - /in-portal/branches/5.2.x/core/units/promo_blocks/promo_block_eh.php File ]
add - /in-portal/branches/5.2.x/core/units/promo_blocks/promo_block_tp.php File ]
add - /in-portal/branches/5.2.x/core/units/promo_blocks/promo_blocks_config.php File ]
Themes :: Modern-Store: 1.0.x r14852
Timestamp: 2011-12-08 08:44:37
Author: alex
Details ] Diff ]
Bug 0001128: Implement "Promo Blocks" functionality as on Intechnic.com
1. all works, but navigation controls jumped up because of upgrade to FlexSlider 1.8 (from FlexSlider 1.0)
mod - /themes/modern-store/branches/1.0.x/elements/promo.elm.tpl Diff ] File ]
mod - /themes/modern-store/branches/1.0.x/inc/js/jquery.flexslider-min.js Diff ] File ]
mod - /themes/modern-store/branches/1.0.x/index.tpl Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:30 alex Note Added: 0004898
2012-07-25 05:30 alex Status resolved => closed
2012-05-17 17:59 Dmitry Relationship added parent of 0001290
2012-05-17 17:57 Dmitry Reference => https://groups.google.com/d/topic/in-portal-dev/huW9qzBVQiI/discussion
2012-05-17 17:57 Dmitry Change Log Message => Implemented new "Promo Blocks" functionality
2012-03-22 11:54 Dmitry Relationship deleted related to 0000066
2012-03-22 11:54 Dmitry Relationship added related to 0000066
2012-02-24 10:34 Dmitry Note Added: 0004479
2012-02-24 10:34 Dmitry File Added: PromoBlocks-513.zip
2012-01-13 09:21 alex Changeset attached 5.2.x r15040
2012-01-10 08:42 alex Changeset attached 5.2.x r15034
2012-01-10 08:41 alex Note Added: 0004403
2012-01-10 08:40 alex File Added: promo_block_images_deleted_fix.patch
2012-01-06 06:00 alex Changeset attached 5.2.x r14997
2012-01-06 05:59 alex Note Added: 0004392
2012-01-06 05:59 alex File Added: promo_block_group_php_syntax_fix.patch
2011-12-28 08:01 alex Note Added: 0004335
2011-12-28 08:01 alex Status reviewed and tested => resolved
2011-12-28 08:01 alex Assigned To !COMMUNITY => alex
2011-12-28 08:01 alex Changeset attached 5.2.x r14929
2011-12-28 08:00 alex Changeset attached 1.0.x r14928
2011-12-28 07:59 alex Note Added: 0004334
2011-12-28 07:59 alex Assigned To alex => !COMMUNITY
2011-12-28 07:59 alex Status needs testing => reviewed and tested
2011-12-28 07:59 alex File Added: promo_block_groups_themes_v4.patch
2011-12-28 07:59 alex File Added: promo_block_groups_core_v4.patch
2011-12-27 09:55 erik Note Added: 0004327
2011-12-27 09:55 erik Assigned To erik => alex
2011-12-27 09:55 erik Developer Dmitry => erik
2011-12-27 09:55 erik Status needs work => needs testing
2011-12-27 09:54 erik File Added: promo_blocks_themes_v3_1128.patch
2011-12-27 09:54 erik File Added: promo_blocks_core_v3_1128.patch
2011-12-22 06:29 erik Status needs feedback => needs work
2011-12-22 06:29 erik Assigned To alex => erik
2011-12-22 03:17 alex Additional Information Updated View Revisions
2011-12-22 03:16 alex Note Added: 0004296
2011-12-22 03:08 alex Additional Information Updated View Revisions
2011-12-20 03:58 alex Note Added: 0004281
2011-12-20 03:57 alex Additional Information Updated View Revisions
2011-12-19 18:12 Dmitry Changeset attached 5.2.x r14886
2011-12-19 18:10 Dmitry File Added: promo_blocks_core_v2-MissingDropSchema.patch
2011-12-18 23:44 Dmitry Type bug report => feature request
2011-12-18 23:44 Dmitry Additional Information Updated View Revisions
2011-12-18 23:44 Dmitry Note Added: 0004273
2011-12-18 21:16 Dmitry Note Added: 0004271
2011-12-18 21:16 Dmitry Status resolved => needs feedback
2011-12-18 21:16 Dmitry Additional Information Updated View Revisions
2011-12-08 08:45 alex Changeset attached 5.2.x r14853
2011-12-08 08:45 alex Note Added: 0004231
2011-12-08 08:45 alex Status reviewed and tested => resolved
2011-12-08 08:45 alex Fixed in Version => 5.2.0-B1
2011-12-08 08:45 alex Resolution open => fixed
2011-12-08 08:45 alex Assigned To !COMMUNITY => alex
2011-12-08 08:44 alex Changeset attached 1.0.x r14852
2011-12-08 08:43 alex Note Added: 0004230
2011-12-08 08:43 alex Assigned To alex => !COMMUNITY
2011-12-08 08:43 alex Status needs testing => reviewed and tested
2011-12-08 08:43 alex Project In-Commerce => In-Portal CMS
2011-12-08 08:42 alex File Added: promo_blocks_themes_v2.patch
2011-12-08 08:42 alex File Deleted: promo_blocks_themes_v2.patch
2011-12-08 08:39 alex File Added: promo_blocks_themes_v2.patch
2011-12-08 08:39 alex File Added: promo_blocks_core_v2.patch
2011-12-07 18:10 Dmitry Note Added: 0004221
2011-10-22 05:28 alex Estimate Points => 1
2011-10-07 10:05 Dmitry Category Payment Gateways => Front End
2011-10-06 12:59 Dmitry Category General => Payment Gateways
2011-10-06 12:59 Dmitry Target Version 1.0.0 => 5.2.0
2011-10-06 12:57 Dmitry Project Modern-Store => In-Commerce
2011-10-04 07:29 Dmitry Assigned To !COMMUNITY => alex
2011-09-27 12:31 Dmitry Assigned To => !COMMUNITY
2011-09-27 12:31 Dmitry Developer => Dmitry
2011-09-27 12:31 Dmitry Status active => needs testing
2011-09-27 12:03 Dmitry File Added: promo_theme.patch
2011-09-27 12:03 Dmitry File Deleted: promo_theme.patch
2011-09-27 12:03 Dmitry File Added: promo.patch
2011-09-27 12:03 Dmitry File Deleted: promo.patch
2011-09-27 12:01 Dmitry File Added: promo_theme.patch
2011-09-27 12:00 Dmitry File Added: promo.patch
2011-09-27 06:48 alex Reporter alex => erik
2011-09-27 06:48 alex New Issue



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker