In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001098

[In-Portal CMS] Data Management

bug report

always

2011-08-17 03:54

2011-09-19 16:08

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.3

Status

closed

Product Version

5.1.3-RC2

Target Version

5.1.3

Time Estimate

No estimate

Summary

0001098: Parameters "editing_mode" and "admin" are passed to page editing form by mistake

Description

In-Portal uses two parameters in url to identify:

* currently used site browse mode (browse/content/design) - "editing_mode" parameter
* regular user or administrator is viewing the site - "admin" parameter

When administrator uses "Section Properties" button to edit currently viewed page in one of a browse modes, then these parameters are passed along to it.
As a result all link built on that "editing page" will have "editing_mode" and "admin" parameters present.

This has even more dramatic effect, when 0001050 (in 5.2.0) is applied, since they are added to generated direct link too and admin will see different link.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/_WQy9S6_5H8/discussion

Change Log Message

Fixes useless parameter being passed to page editing page

Estimate Points

0

keep_section_properties_link_clean.patch [^] (576 bytes) 2011-08-17 03:54 [Show Content]

Index: categories_event_handler.php
===================================================================
--- categories_event_handler.php	(revision 14472)
+++ categories_event_handler.php	(working copy)
@@ -228,6 +228,11 @@
 			$this->Application->StoreVar('IsRootCategory_'.$this->Application->GetVar('m_wid'), ($category_id === '0') || ($category_id == $home_category));
 
 			parent::OnEdit($event);
+
+			if ($event->status == erSUCCESS) {
+				// keep "Section Properties" link (in browse modes) clean
+				$this->Application->DeleteVar('admin');
+			}
 		}
 
 		/**

Relationships [ Relation Graph ] [ Dependency Graph ]

child of

closed (5.2.0)

Ability to access Disabled Section with Direct Link

Notes
(0003671) Dmitry (manager) 2011-08-20 15:54	Reviewed and tested okay, please commit!

(0003696) alex (manager) 2011-08-24 02:55	Fix committed to 5.1.x branch. Commit Message: Fixes 0001098: Parameters "editing_mode" and "admin" are passed to page editing form by mistake

(0003790) alex (manager) 2011-09-19 16:08	Closing, since 5.1.3 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14511 Timestamp: 2011-08-24 02:55:31 Author: alex [ Details ] [ Diff ]	Fixes 0001098: Parameters "editing_mode" and "admin" are passed to page editing form by mistake
	mod - /in-portal/branches/5.1.x/core/units/categories/categories_event_handler.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-09-19 16:08	alex	Note Added: 0003790
2011-09-19 16:08	alex	Status	resolved => closed
2011-08-24 02:55	alex	Changeset attached	5.1.x r14511
2011-08-24 02:55	alex	Note Added: 0003696
2011-08-24 02:55	alex	Status	reviewed and tested => resolved
2011-08-24 02:55	alex	Fixed in Version	=> 5.1.3
2011-08-24 02:55	alex	Resolution	open => fixed
2011-08-24 02:55	alex	Assigned To	!COMMUNITY => alex
2011-08-20 15:54	Dmitry	Note Added: 0003671
2011-08-20 15:54	Dmitry	Status	needs testing => reviewed and tested
2011-08-17 03:56	alex	Assigned To	=> !COMMUNITY
2011-08-17 03:56	alex	Developer	=> alex
2011-08-17 03:56	alex	Status	active => needs testing
2011-08-17 03:56	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/_WQy9S6_5H8/discussion
2011-08-17 03:55	alex	Relationship added	child of 0001050
2011-08-17 03:54	alex	New Issue
2011-08-17 03:54	alex	File Added: keep_section_properties_link_clean.patch
2011-08-17 03:54	alex	Change Log Message	=> Fixes useless parameter being passed to page editing page

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group