In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000983

[In-Portal CMS] Data Management

bug report

always

2011-01-27 22:24

2012-10-22 10:12

Reporter

Dmitry

View Status

public

Project Name

In-Portal CMS

Assigned To

Dmitry

Developer

Priority

normal

Resolution

unable to reproduce

Platform

Status

closed

OS

OS Version

ETA

none

Fixed in Version

Product Version

5.1.2-B1

Target Version

Icebox

Product Build

Time Estimate

No estimate

Summary

0000983: Captcha check won't work when Cookies are disabled

Description

Captcha security image check won't work when Browser Cookies are disabled. Current code validation doesn't seem to properly since we are not set Error Status in the called Event rather just call SetError method of the object.

To replicate please disable the Cookies via Firebug and try posting to the form with Captcha, but make sure there is NO SID in your URL query.

Steps To Reproduce

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/2OC67KzvAdA/discussion

Change Log Message

Fixes Captcha security check when cookies disabled

Estimate Points

0

Captcha-check-wont-work-when-Cookies-disabled.patch [^] (614 bytes) 2011-01-27 22:24 [Show Content]

Index: units/helpers/captcha_helper.php
===================================================================
--- units/helpers/captcha_helper.php	(revision 14184)
+++ units/helpers/captcha_helper.php	(working copy)
@@ -172,7 +172,8 @@
 		if (!$object->GetDBField('Captcha') || ($object->GetDBField('Captcha') != $valid_code)) {
 			// empty code OR codes doesn't match
 			$object->SetError('Captcha', 'captcha_error', 'lu_captcha_error');
-
+			$event->status = erFAIL;
+				
 			$this->Application->StoreVar($event->getPrefixSpecial() . '_captcha_code', $this->GenerateCaptchaCode());
 			return false;
 		}

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0003398) Dmitry (manager) 2011-04-03 20:13	Needs additional review

(0003424) Dmitry (manager) 2011-05-18 13:24	Need more review and solid test case (ie. CURL)

(0003555) Dmitry (manager) 2011-06-26 23:26	For some reason can't replicate. Let's move this one back a little (future) since not critical.

(0005243) alex (manager) 2012-10-22 10:12	Closing due no way to reproduce it.

Issue History
Date Modified	Username	Field	Change
2012-10-22 10:12	alex	Note Added: 0005243
2012-10-22 10:12	alex	Status	needs work => closed
2012-10-22 10:12	alex	Time Estimate Removed	1 =>
2012-10-22 10:12	alex	Resolution	open => unable to reproduce
2011-06-26 23:26	Dmitry	Target Version	5.1.3 => Icebox
2011-06-26 23:26	Dmitry	Note Added: 0003555
2011-05-18 13:24	Dmitry	Time Estimate Added	1
2011-05-18 13:24	Dmitry	Note Added: 0003424
2011-04-04 11:50	Dmitry	Target Version	Icebox => 5.1.3
2011-04-03 20:13	Dmitry	Note Added: 0003398
2011-04-03 20:13	Dmitry	Assigned To	!COMMUNITY => Dmitry
2011-04-03 20:13	Dmitry	Status	needs testing => needs work
2011-01-27 22:29	Dmitry	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/2OC67KzvAdA/discussion
2011-01-27 22:25	Dmitry	Assigned To	=> !COMMUNITY
2011-01-27 22:25	Dmitry	Developer	=> Dmitry
2011-01-27 22:25	Dmitry	Status	active => needs testing
2011-01-27 22:24	Dmitry	New Issue
2011-01-27 22:24	Dmitry	File Added: Captcha-check-wont-work-when-Cookies-disabled.patch
2011-01-27 22:24	Dmitry	Change Log Message	=> Fixes Captcha security check when cookies disabled

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group