In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details Jump to Notes ] Wiki ] View Simple ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000846 [In-Portal CMS] Install / Upgrages bug report always 2010-08-31 13:24 2011-03-30 09:53
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Platform
Status closed   OS
  OS Version
ETA none Fixed in Version 5.1.2-B1 Product Version 5.1.0
  Target Version 5.1.2 Product Build
Time EstimateNo estimate
Summary 0000846: Several notices about undefined constants during installation
Description In-Portal installation is divided into several steps. Because of In-Portal is module-based, then each of the modules can have it's own specific installation php code. Each of In-Portal modules can have it's "constants.php", where module developers can define module-specific constants to be used throughout the module.

While In-Portal isn't completely installed, then unit config files of all modules are included, but not module "constants.php" files. This isn't a bad thing to to, but isn't a good one either. One side effect of this is that, when we are using module-specific constants in it's unit config files, then we will get php notices about each used constant, while module is being installed.

Unit config files of all not-yet installed modules are included because they can be used in module-specific "install.php" file. Since we don't know are they used or not, then we include them in any case.

File "constants.php" of each module are only included for installed modules and this raises such a problem. Because of such file contains a constant definition, then we can't include same file twice, so I propose, that we also include "constants.php" files from all modules during installation.

This is hard piece of knowledge to understand, since developers usually don't care about how installation system of In-Portal works until their module suddenly stops installing correctly :)
Steps To Reproduce
Additional Information This doesn't break anything for now. This is just not good to have notices/warnings if we could prevent them from happening.
Tags No tags attached.
Change Log Message
Estimate Points 0
Attached Files patch file icon notices-about-undefined-constants-during-installation.patch [^] (985 bytes) 2010-12-05 20:16 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0003109)
Dmitry (manager)
2010-12-05 20:16

Please review and test.
User avatar (0003165)
Dmitry (manager)
2011-01-05 12:07

Reminder sent to: alex

This needs to be reviewed. Please note that I did NOT want to make changes to Application class so it's not conflicting to the refactoring of Application done 5.2.0 release. I believe it's a better solution at the moment.
User avatar (0003172)
alex (manager)
2011-01-05 14:08

I will see, what I can change to get nice code + less merging issues in 5.2.0.
User avatar (0003204)
alex (manager)
2011-01-11 05:03


I've applied some minor changes to code (moved to new method).
User avatar (0003205)
alex (manager)
2011-01-11 05:03

Fix committed to 5.1.x branch. Commit Message:

1. Fixes 0000846: Several notices about undefined constants during installation
2. Commit on behalf of Dmitry
User avatar (0003337)
Dmitry (manager)
2011-03-30 09:53

Closing, since 5.1.2 release has been released.

- Related Changesets
In-Portal CMS: 5.1.x r14162
Timestamp: 2011-01-11 05:03:53
Author: alex
Details ] Diff ]
1. Fixes 0000846: Several notices about undefined constants during installation
2. Commit on behalf of Dmitry
mod - /in-portal/branches/5.1.x/core/install.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2011-03-30 09:53 Dmitry Note Added: 0003337
2011-03-30 09:53 Dmitry Status resolved => closed
2011-01-11 05:03 alex Changeset attached 5.1.x r14162
2011-01-11 05:03 alex Note Added: 0003205
2011-01-11 05:03 alex Status reviewed and tested => resolved
2011-01-11 05:03 alex Fixed in Version => 5.1.2-B1
2011-01-11 05:03 alex Resolution open => fixed
2011-01-11 05:03 alex Assigned To !COMMUNITY => alex
2011-01-11 05:03 alex Note Added: 0003204
2011-01-11 05:03 alex Status needs testing => reviewed and tested
2011-01-05 14:08 alex Note Added: 0003172
2011-01-05 12:07 Dmitry Note Added: 0003165
2010-12-05 20:16 Dmitry Note Added: 0003109
2010-12-05 20:16 Dmitry Assigned To Dmitry => !COMMUNITY
2010-12-05 20:16 Dmitry Status needs work => needs testing
2010-12-05 20:16 Dmitry File Added: notices-about-undefined-constants-during-installation.patch
2010-09-28 14:04 Dmitry Assigned To => Dmitry
2010-09-28 14:04 Dmitry Status active => needs work
2010-09-28 12:03 Dmitry Developer => Dmitry
2010-09-28 12:03 Dmitry Target Version Icebox => 5.1.2
2010-08-31 13:24 alex New Issue
2010-08-31 13:24 alex Reference =>

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker