In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details Jump to Notes ] Wiki ] View Simple ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000769 [In-Portal CMS] Admin Interfaces feature request N/A 2010-06-10 13:56 2012-07-25 05:33
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Platform
Status closed   OS
  OS Version
ETA none Fixed in Version 5.2.0-B1 Product Version 5.0.4
  Target Version 5.2.0 Product Build
Time EstimateNo estimate
Summary 0000769: Display notice on change log list, when change log feature is disabled
Description I propose we display notice (red, like "search filter in effect") above change log list, when change log is not enabled via configuration. We could also tell, that user must enable "la-la-la" variable in configuration to start change log tracking.

Message text could be:

1. Change log is currently disabled. Turn on "Track database changes to change log" setting to enabled it.

2. Also make "Track database changes to change log" text into a link. Once clicked it will ask use "Enable tracking database changes to change log?" with "OK"/"Cancel" buttons.

3. If "OK" is clicked, then we can create event, that would use kApplication::SetConfigValue method to change related config setting right away without a need for a user to search for location of particular config setting.
Steps To Reproduce
Additional Information Plan:
1. nothing special, just place new phrases to install/english.lang file
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/fa77543c429d5606
Change Log Message
Estimate Points 1
Attached Files patch file icon 769.patch [^] (3,921 bytes) 2011-09-28 04:52 [Show Content]
patch file icon change_log_off_notice_769.2.patch [^] (5,791 bytes) 2011-10-04 05:21 [Show Content]
patch file icon change_log_off_notice_v3.patch [^] (8,005 bytes) 2011-10-05 09:16 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0003895)
alex (manager)
2011-09-24 05:26

We can also make "Track database changes to change log" text into a link. Once clicked it will ask use "Enable tracking database changes to change log?" with "OK"/"Cancel" buttons.

If "OK" is clicked, then we can create event, that would use kApplication::SetConfigValue method to change related config setting right away without a need for a user to search for location of particular config setting.
User avatar (0003898)
Dmitry (manager)
2011-09-24 13:43

Agreed to suggestion
User avatar (0003932)
erik (manager)
2011-09-28 04:53

Patch uploaded - needs testing
User avatar (0003983)
alex (manager)
2011-10-03 12:57

1. Function "confirm" should be used instead of deprecated "inpConfirm" function.

2. Tag m_ConfigEquals is deprecated, so please use just <inp2:m_if check="m_GetConfig" name="UseChangeLog"> ... </inp2:m_if>

3. It appears, that "la_msg_TrackDatabaseChangesToChangeLog" phrase have same translation as related configuration variable. Please use phrase from corresponding configuration variable instead.

4. Instead of creating 3 phrases:
- la_msg_ChangeLogIsCurrentlyDisabled
- la_msg_TurnOn
- la_msg_SettingToEnableIt
Just create 1 phrase, with %s in places where tricky HTML should be inserted.
Then create tag in ChangeLogTagProcessor that will translate phrase and replace %s (via sprintf function call) with proper JS/HTML. Such approach will simplify language pack translation to a different language.

5. There is no need to check for Admin Console or Front-end, since "change log view" permission isn't given to Member user group.

6. Why "event_used_in_order" session variable is deleted in "change_log_list.tpl" template. I can't find any place in attached patch, where this session variable was set.
User avatar (0003993)
erik (manager)
2011-10-04 05:22

change_log_off_notice_769.2.patch attached - needs testing
User avatar (0004022)
alex (manager)
2011-10-05 09:16

Tested, but few things that were fixed:
1. double quotes in change log message's TPL moved into phrase translation
2. word "Use" replaced with "Enable" in tags/tpls so all code will use the same term
3. function enable_log in js was declared even, when it wasn't used
4. link to enable change log was in red color and there was no indication (during initial page show), that it can be clicked (until hover effect made him blue).
5. Phrase la_msg_EnableTrackingDatabaseChangesToChangeLog was deleted instead of la_msg_TrackDatabaseChangesToChangeLog in 2nd patch.


Additionaly done:
1. license was missing in ChangeLogEventHandler class
User avatar (0004023)
alex (manager)
2011-10-05 09:17

Fix committed to 5.2.x branch. Commit Message:

Fixes 0000769: Display notice on change log list, when change log feature is disabled
Commit on behalf of Erik
User avatar (0005106)
alex (manager)
2012-07-25 05:33

Since 5.2.0 version was released.

- Related Changesets
In-Portal CMS: 5.2.x r14639
Timestamp: 2011-10-05 09:17:02
Author: alex
Details ] Diff ]
Fixes 0000769: Display notice on change log list, when change log feature is disabled
Commit on behalf of Erik
mod - /in-portal/branches/5.2.x/core/admin_templates/logs/change_logs/change_log_list.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/english.lang Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/logs/change_logs/change_log_eh.php Diff ] File ]
add - /in-portal/branches/5.2.x/core/units/logs/change_logs/change_log_tp.php File ]
mod - /in-portal/branches/5.2.x/core/units/logs/change_logs/change_logs_config.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:33 alex Note Added: 0005106
2012-07-25 05:33 alex Status resolved => closed
2011-10-22 05:30 alex Estimate Points => 1
2011-10-05 09:17 alex Note Added: 0004023
2011-10-05 09:17 alex Status reviewed and tested => resolved
2011-10-05 09:17 alex Fixed in Version => 5.2.0-B1
2011-10-05 09:17 alex Resolution open => fixed
2011-10-05 09:17 alex Assigned To !COMMUNITY => alex
2011-10-05 09:17 alex Changeset attached 5.2.x r14639
2011-10-05 09:16 alex Note Added: 0004022
2011-10-05 09:16 alex Assigned To alex => !COMMUNITY
2011-10-05 09:16 alex Status needs testing => reviewed and tested
2011-10-05 09:16 alex File Added: change_log_off_notice_v3.patch
2011-10-04 05:22 erik Note Added: 0003993
2011-10-04 05:22 erik Assigned To erik => alex
2011-10-04 05:22 erik Status needs work => needs testing
2011-10-04 05:21 erik File Added: change_log_off_notice_769.2.patch
2011-10-04 05:19 erik File Deleted: change_log_off_notice_769.2
2011-10-04 05:18 erik File Added: change_log_off_notice_769.2
2011-10-03 12:57 alex Note Added: 0003983
2011-10-03 12:57 alex Assigned To alex => erik
2011-10-03 12:57 alex Status needs testing => needs work
2011-09-28 04:53 erik Time Estimate Removed 1 =>
2011-09-28 04:53 erik Developer => erik
2011-09-28 04:53 erik Status needs work => needs testing
2011-09-28 04:53 erik Assigned To erik => alex
2011-09-28 04:53 erik Note Added: 0003932
2011-09-28 04:52 erik File Added: 769.patch
2011-09-27 04:14 alex Time Estimate Added 1
2011-09-26 04:20 alex Additional Information Updated View Revisions
2011-09-24 13:44 Dmitry Description Updated View Revisions
2011-09-24 13:43 Dmitry Note Added: 0003898
2011-09-24 05:26 alex Note Added: 0003895
2011-09-23 21:46 Dmitry Assigned To => erik
2011-09-23 21:46 Dmitry Status active => needs work
2011-09-23 21:46 Dmitry Target Version Icebox => 5.2.0
2010-06-10 13:56 alex New Issue
2010-06-10 13:56 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/fa77543c429d5606



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker