In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details Jump to Notes ] Wiki ]  Related Changesets ] View Simple ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000746 [In-Portal CMS] Admin Interfaces task N/A 2010-05-23 11:14 2010-11-30 12:48
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Platform
Status closed   OS
  OS Version
ETA none Fixed in Version 5.1.1-B1 Product Version 5.0.3
  Target Version 5.1.1 Product Build
Time EstimateNo estimate
Summary 0000746: Remove useless filters from "View Menu"
Description Since 5.x versions each grid column have it's own filter. Because of it "View -> View" menu became useless, since it only duplicates existing code.

I propose to remove it in all places, when necessary.
Steps To Reproduce
Additional Information Need to search for "FilterMenu" in all "*_config.php" files to find all View menus.

We also could remove "Select" and "Sort" submenus completely (delete related code at all).
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/1d11a3fc2f8773ef
Change Log Message
Estimate Points 0
Attached Files patch file icon View-Menu-Cleanup-CORE.patch [^] (31,554 bytes) 2010-09-10 17:05 [Show Content]
patch file icon View-Menu-Cleanup-MODULES.patch [^] (51,345 bytes) 2010-09-10 17:06 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0002760)
alex (manager)
2010-09-01 03:32

Removing is not adding, so it's pretty fast to do -> Moving to 5.1.1
User avatar (0002762)
Dmitry (manager)
2010-09-01 16:23

I'll take this task.
User avatar (0002807)
Dmitry (manager)
2010-09-10 17:07

Please review and test.

NOTE: some very minor code clean-up has been done in some of Unit Configs on the way.
User avatar (0002826)
alex (manager)
2010-09-14 04:10

Tested, however some minor issues were found and fixed by me manually:

1. discounts grid:
- filter by Status was not deleted
- filter by Type field still present in unit config, however it duplicated Type column, that was already displayed before
2. coupons grid:
- filter by Status was deleted, but Status column were not added to the grid to compensate that
3. downloadable product files grid:
- filter by Status was deleted, but Status column were not added to the grid to compensate that
4. listings grid:
- filter by Status was deleted, but Status column were not added to the grid to compensate that
5. categories grid:
- filter by Status was deleted, but Status column were not added to the grid to compensate that
6. users/admins grid:
- filter by Status was deleted, but Status column were not added to the grid to compensate that
User avatar (0002827)
alex (manager)
2010-09-14 04:16

Fix committed to 5.1.x branch. Commit Message:

1. Fixes 0000746: Remove useless filters from "View Menu"
2. Commit on behalf of Dmitry
User avatar (0003034)
Dmitry (manager)
2010-11-30 12:48

Closing released 5.1.1 task.

- Related Changesets
In-Portal CMS: 5.1.x r13941
Timestamp: 2010-09-14 04:16:10
Author: alex
Details ] Diff ]
1. Fixes 0000746: Remove useless filters from "View Menu"
2. Commit on behalf of Dmitry
mod - /in-portal/branches/5.1.x/core/admin_templates/categories/categories_edit_images.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/categories/categories_edit_related_searches.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/categories/categories_edit_relations.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/incs/menu_blocks.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/languages/language_list.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/modules/modules_list.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/regional/languages_edit_email_events.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/regional/languages_list.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/reviews/reviews_tab.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/stylesheets/stylesheets_list.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/themes/themes_list.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/user_selector.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/users/admins_list.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/users/user_edit_images.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/users/user_selector.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/users/users_list.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/categories/categories_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/email_events/email_events_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/files/files_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/images/images_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/languages/languages_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/modules/modules_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/phrases/phrases_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/related_searches/related_searches_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/relationship/relationship_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/reviews/reviews_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/stylesheets/stylesheets_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/themes/themes_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/users/users_config.php Diff ] File ]
Modules :: In-News: 5.1.x r13940
Timestamp: 2010-09-14 04:15:10
Author: alex
Details ] Diff ]
1. Bug 0000746: Remove useless filters from "View Menu"
2. Commit on behalf of Dmitry
mod - /modules/in-news/branches/5.1.x/admin_templates/articles/articles_files.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/articles/articles_images.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/articles/articles_relations.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/articles/articles_reviews.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/units/articles/articles_config.php Diff ] File ]
Modules :: In-Link: 5.1.x r13939
Timestamp: 2010-09-14 04:14:25
Author: alex
Details ] Diff ]
1. Bug 0000746: Remove useless filters from "View Menu"
2. Commit on behalf of Dmitry
mod - /modules/in-link/branches/5.1.x/admin_templates/link_validation/link_validation_list.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/links/links_files.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/links/links_images.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/links/links_relations.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/links/links_reviews.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/paid_listings/paid_listings_list.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/units/link_validation/link_validation_config.php Diff ] File ]
mod - /modules/in-link/branches/5.1.x/units/links/links_config.php Diff ] File ]
mod - /modules/in-link/branches/5.1.x/units/listings/listings_config.php Diff ] File ]
Modules :: In-Commerce: 5.1.x r13938
Timestamp: 2010-09-14 04:12:39
Author: alex
Details ] Diff ]
1. Bug 0000746: Remove useless filters from "View Menu"
2. Commit on behalf of Dmitry
mod - /w/in-commerce/branches/5.1.x/admin_templates/discounts/coupon_selector.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/discounts/coupons_list.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/discounts/discounts_list.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/discounts/gift_certificate_list.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/orders_search_list.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/payment_type/payment_type_list.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/option_combinations.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/products_images.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/products_packagecontent.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/products_relations.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/products_reviews.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/shipping/shipping_custom_list.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/shipping/shipping_list.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/coupons/coupons_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/discounts/discounts_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/files/files_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gift_certificates/gift_certificates_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/orders/orders_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/payment_type/payment_type_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/products/products_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/reports/reports_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/shipping/shipping_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/shipping_quote_engines/shipping_quote_engines_config.php Diff ] File ]
Modules :: In-Bulletin: 5.1.x r13937
Timestamp: 2010-09-14 04:11:00
Author: alex
Details ] Diff ]
1. Bug 0000746: Remove useless filters from "View Menu"
2. Commit on behalf of Dmitry
mod - /modules/in-bulletin/branches/5.1.x/admin_templates/topics/topics_images.tpl Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/admin_templates/topics/topics_relations.tpl Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/admin_templates/topics/topics_reviews.tpl Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/units/topics/topics_config.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-11-30 12:48 Dmitry Note Added: 0003034
2010-11-30 12:48 Dmitry Status resolved => closed
2010-09-14 04:16 alex Note Added: 0002827
2010-09-14 04:16 alex Status reviewed and tested => resolved
2010-09-14 04:16 alex Fixed in Version => 5.1.1-B1
2010-09-14 04:16 alex Resolution open => fixed
2010-09-14 04:16 alex Assigned To !COMMUNITY => alex
2010-09-14 04:16 alex Changeset attached 5.1.x r13941
2010-09-14 04:15 alex Changeset attached 5.1.x r13940
2010-09-14 04:14 alex Changeset attached 5.1.x r13939
2010-09-14 04:12 alex Changeset attached 5.1.x r13938
2010-09-14 04:11 alex Changeset attached 5.1.x r13937
2010-09-14 04:10 alex Note Added: 0002826
2010-09-14 04:10 alex Assigned To alex => !COMMUNITY
2010-09-14 04:10 alex Status needs testing => reviewed and tested
2010-09-10 17:07 Dmitry Note Added: 0002807
2010-09-10 17:07 Dmitry Assigned To Dmitry => alex
2010-09-10 17:07 Dmitry Developer => Dmitry
2010-09-10 17:07 Dmitry Status needs work => needs testing
2010-09-10 17:06 Dmitry File Added: View-Menu-Cleanup-MODULES.patch
2010-09-10 17:05 Dmitry File Added: View-Menu-Cleanup-CORE.patch
2010-09-01 16:23 Dmitry Note Added: 0002762
2010-09-01 16:23 Dmitry Assigned To => Dmitry
2010-09-01 16:23 Dmitry Status active => needs work
2010-09-01 15:51 alex Additional Information Updated View Revisions
2010-09-01 03:32 alex Note Added: 0002760
2010-09-01 03:32 alex Target Version Icebox => 5.1.1
2010-09-01 03:31 alex Additional Information Updated View Revisions
2010-05-23 11:14 alex New Issue
2010-05-23 11:14 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/1d11a3fc2f8773ef



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker