In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details Jump to Notes ] Wiki ]  Related Changesets ] View Simple ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000735 [In-Portal CMS] Optimization task N/A 2010-05-18 07:28 2010-07-22 15:06
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Platform
Status closed   OS
  OS Version
ETA none Fixed in Version 5.1.0-B1 Product Version 5.0.3
  Target Version 5.1.0 Product Build
Time EstimateNo estimate
Summary 0000735: Addressing (in code) users "root" and "Guest" using named constants
Description System users "root" (id = -1) and "Guest" (id = -2) are using in In-Portal since it's first version. Despite their popularity we always use their IDs in code and not thinking about creating named constants.

I say enough to mystic numbers and propose to create constants:

    * USER_ROOT - for "-1" value
    * USER_GUEST - for "-2" value

I've already did that and replaced all places, where I've found that magic numbers with proposed constants.
Steps To Reproduce
Additional Information
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/82a907b35b0d9285
Change Log Message
Estimate Points 0
Attached Files patch file icon user_constants_core.patch [^] (31,830 bytes) 2010-05-18 07:28 [Show Content]
patch file icon user_constants_modules.patch [^] (36,982 bytes) 2010-05-18 07:29 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to 0000704closed (5.1.0)alex Improvements to "E-mail Template" editing 

-  Notes
User avatar (0002245)
Dmitry (manager)
2010-05-18 22:29

Tested good.
User avatar (0002246)
alex (manager)
2010-05-19 02:33

Fix committed to 5.1.x branch. Commit Message:

Fixes 0000735: Addressing (in code) users "root" and "Guest" using named constants
User avatar (0002527)
alex (manager)
2010-07-22 15:06

Closing, since 5.1.0 release has been released.

- Related Changesets
In-Portal CMS: 5.1.x r13581
Timestamp: 2010-05-19 02:33:23
Author: alex
Details ] Diff ]
Fixes 0000735: Addressing (in code) users "root" and "Guest" using named constants
mod - /in-portal/branches/5.1.x/core/install.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/application.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/constants.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/db/cat_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/db/cat_tag_processor.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/db/db_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/event_handler.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/event_manager.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/session/inp_session.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/session/session.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/startup.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/utility/temp_handler.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/categories/categories_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/categories/categories_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/categories/categories_tag_processor.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/files/files_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/helpers/permissions_helper.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/helpers/spam_helper.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/helpers/user_helper.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/languages/languages_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/logs/change_logs/change_logs_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/logs/session_logs/session_logs_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/mailing_lists/mailing_lists_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/modules/modules_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/modules/modules_tag_processor.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/reviews/reviews_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/structure/structure_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/users/users_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/users/users_tag_processor.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/visits/visits_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/visits/visits_tag_processor.php Diff ] File ]
Modules :: In-News: 5.1.x r13580
Timestamp: 2010-05-19 02:27:16
Author: alex
Details ] Diff ]
Bug 0000735: Addressing (in code) users "root" and "Guest" using named constants
mod - /modules/in-news/branches/5.1.x/install.php Diff ] File ]
mod - /modules/in-news/branches/5.1.x/units/articles/articles_config.php Diff ] File ]
mod - /modules/in-news/branches/5.1.x/units/articles/articles_event_handler.php Diff ] File ]
Modules :: In-Link: 5.1.x r13579
Timestamp: 2010-05-19 02:26:53
Author: alex
Details ] Diff ]
Bug 0000735: Addressing (in code) users "root" and "Guest" using named constants
mod - /modules/in-link/branches/5.1.x/install.php Diff ] File ]
mod - /modules/in-link/branches/5.1.x/units/links/links_config.php Diff ] File ]
mod - /modules/in-link/branches/5.1.x/units/listings/listings_config.php Diff ] File ]
Modules :: In-Commerce: 5.1.x r13578
Timestamp: 2010-05-19 02:25:51
Author: alex
Details ] Diff ]
Bug 0000735: Addressing (in code) users "root" and "Guest" using named constants
mod - /w/in-commerce/branches/5.1.x/install.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/affiliates/affiliates_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/coupons/coupons_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/authorizenet.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/orders/orders_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/orders/orders_event_handler.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/orders/orders_tag_processor.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/products/products_event_handler.php Diff ] File ]
Modules :: In-Bulletin: 5.1.x r13577
Timestamp: 2010-05-19 02:24:12
Author: alex
Details ] Diff ]
Bug 0000735: Addressing (in code) users "root" and "Guest" using named constants
mod - /modules/in-bulletin/branches/5.1.x/install.php Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/units/poll_comments/poll_comment_eh.php Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/units/poll_comments/poll_comments_config.php Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/units/polls/poll_eh.php Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/units/polls/polls_config.php Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/units/posts/posts_config.php Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/units/private_messages/private_messages_config.php Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/units/topics/topics_config.php Diff ] File ]
Modules :: Custom: 1.1.x r13575
Timestamp: 2010-05-19 02:21:51
Author: alex
Details ] Diff ]
Bug 0000735: Addressing (in code) users "root" and "Guest" using named constants
mod - /modules/custom/branches/1.1.x/install.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-07-22 15:06 alex Note Added: 0002527
2010-07-22 15:06 alex Status resolved => closed
2010-05-19 02:33 alex Changeset attached 5.1.x r13581
2010-05-19 02:33 alex Note Added: 0002246
2010-05-19 02:33 alex Status reviewed and tested => resolved
2010-05-19 02:33 alex Fixed in Version => 5.1.0-B1
2010-05-19 02:33 alex Resolution open => fixed
2010-05-19 02:33 alex Assigned To !COMMUNITY => alex
2010-05-19 02:27 alex Changeset attached 5.1.x r13580
2010-05-19 02:26 alex Changeset attached 5.1.x r13579
2010-05-19 02:25 alex Changeset attached 5.1.x r13578
2010-05-19 02:24 alex Changeset attached 5.1.x r13577
2010-05-19 02:22 alex Changeset attached 5.1.x r13576
2010-05-19 02:21 alex Changeset attached 1.1.x r13575
2010-05-19 02:21 alex Summary Addressing (in code) users "root" and "Guest" using named contants => Addressing (in code) users "root" and "Guest" using named constants
2010-05-19 02:19 alex Reproducibility always => N/A
2010-05-18 22:29 Dmitry Note Added: 0002245
2010-05-18 22:29 Dmitry Status needs testing => reviewed and tested
2010-05-18 07:31 alex Assigned To => !COMMUNITY
2010-05-18 07:31 alex Developer => alex
2010-05-18 07:31 alex Status active => needs testing
2010-05-18 07:31 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/82a907b35b0d9285
2010-05-18 07:29 alex Relationship added related to 0000704
2010-05-18 07:29 alex File Added: user_constants_modules.patch
2010-05-18 07:28 alex New Issue
2010-05-18 07:28 alex File Added: user_constants_core.patch



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker