In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details Jump to Notes ] Wiki ]  Related Changesets ] View Simple ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000695 [In-Portal CMS] Optimization bug report always 2010-04-13 10:43 2010-11-30 12:48
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Platform
Status closed   OS
  OS Version
ETA none Fixed in Version 5.1.1-B1 Product Version 5.0.3-B2
  Target Version 5.1.1 Product Build
Time EstimateNo estimate
Summary 0000695: Remove endless "!" inside admin templates
Description In earlier template parser versions, used in In-Portal we had problems
distinguishing simple text and labels, that should be translated. At that
times we invented ability to escape text with "!" in form "!label_here!" so
it will be translated.

For quite some time this is no longer a problem and that ! in admin template
actually do nothing and are stripped at the end. Example code:
*<inp2:m_RenderElement name="inp_edit_options" prefix="formflds"
field="ElementType" title="!la_prompt_InputType!"/>*

As you can notice title parameter value displays the problem I've described.
We will remove all such occurrences of "!" in one release and will remove
code, that strips ! in next version, so all users will be forced to to
change their code as well.
Steps To Reproduce
Additional Information
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/1565976435f1f2ab
Change Log Message
Estimate Points 0
Attached Files patch file icon Remove-ExplainationMarks-from-Phrases-Core.patch [^] (84,977 bytes) 2010-08-29 18:51 [Show Content]
patch file icon Remove-ExplainationMarks-from-Phrases-Modules.patch [^] (229,284 bytes) 2010-08-29 18:51 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0002749)
Dmitry (manager)
2010-08-29 18:53
edited on: 2010-08-29 19:03

Please review and commit if works as expected.

NOTE: need to remove the code below from "phrases_cache.php" (line 264) in the next release:

// cut exclamation marks - depricated form of passing phrase name from templates
$label = preg_replace('/^!(.*)!$/', '\\1', $label);


To find and replace all !la_! used - REGEX "!la_(.*)!" and replace with "la_$1"

User avatar (0002830)
alex (manager)
2010-09-14 04:53

ok
User avatar (0002831)
alex (manager)
2010-09-14 04:58

Fix committed to 5.1.x branch. Commit Message:

1. Fixes 0000695: Remove endless "!" inside admin templates
2. Commit on behalf of Dmitry
User avatar (0003031)
Dmitry (manager)
2010-11-30 12:48

Closing released 5.1.1 task.

- Related Changesets
In-Portal CMS: 5.1.x r13949
Timestamp: 2010-09-14 04:58:00
Author: alex
Details ] Diff ]
1. Fixes 0000695: Remove endless "!" inside admin templates
2. Commit on behalf of Dmitry
mod - /in-portal/branches/5.1.x/core/admin_templates/ban_rules/ban_rule_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/categories/categories_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/categories/images_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/categories/related_searches_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/categories/relations_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/config/config_search_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/custom_fields/custom_fields_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/forms/form_field_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/forms/forms_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/groups/groups_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/import/import_start.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/incs/image_blocks.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/languages/email_message_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/languages/email_message_settings.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/languages/phrase_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/logs/change_logs/change_log_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/popups/translator.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/regional/email_messages_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/regional/languages_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/regional/languages_export.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/regional/languages_export_step2.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/regional/languages_import.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/regional/phrases_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/reviews/review_direct_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/skins/skin_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/stylesheets/base_style_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/stylesheets/block_style_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/stylesheets/style_editor.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/stylesheets/stylesheets_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/themes/file_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/themes/themes_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/users/admins_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/users/image_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/users/user_edit_items.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/users/user_edit_password.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/admin_templates/users/users_edit.tpl Diff ] File ]
Modules :: In-News: 5.1.x r13948
Timestamp: 2010-09-14 04:57:23
Author: alex
Details ] Diff ]
1. Bug 0000695: Remove endless "!" inside admin templates
2. Commit on behalf of Dmitry
mod - /modules/in-news/branches/5.1.x/admin_templates/articles/articles_categories.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/articles/articles_edit.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/articles/file_edit.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/articles/images_edit.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/articles/relations_edit.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/articles/review_edit.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/category_properties.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/export.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/export_finish.tpl Diff ] File ]
mod - /modules/in-news/branches/5.1.x/admin_templates/import.tpl Diff ] File ]
Modules :: In-Link: 5.1.x r13947
Timestamp: 2010-09-14 04:57:12
Author: alex
Details ] Diff ]
1. Bug 0000695: Remove endless "!" inside admin templates
2. Commit on behalf of Dmitry
mod - /modules/in-link/branches/5.1.x/admin_templates/export.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/export_finish.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/import.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/links/file_edit.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/links/images_edit.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/links/links_categories.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/links/links_edit.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/links/relations_edit.tpl Diff ] File ]
mod - /modules/in-link/branches/5.1.x/admin_templates/links/review_edit.tpl Diff ] File ]
Modules :: In-Commerce: 5.1.x r13946
Timestamp: 2010-09-14 04:56:55
Author: alex
Details ] Diff ]
1. Bug 0000695: Remove endless "!" inside admin templates
2. Commit on behalf of Dmitry
mod - /w/in-commerce/branches/5.1.x/admin_templates/affiliate_plans/affiliate_payment_types_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/affiliate_plans/affiliate_plans_brackets.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/affiliate_plans/affiliate_plans_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/affiliate_plans/affiliates_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/affiliate_plans/affiliates_payout.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/currencies/currencies_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/discounts/coupon_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/discounts/discount_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/discounts/gift_certificate_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/export.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/export_finish.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/import.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/manufacturers/manufacturers_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/export/export.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/export/export_finish.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/order_product_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/orders_blocks.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/orders_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/orders_edit_billing.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/orders_edit_preview.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/orders_edit_shipping.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/payment_type/payment_type_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/payment_type/payment_type_gateway.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/payment_type/payment_type_groups.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/access_pricing_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/file_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/images_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/option_combinations.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/option_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/pricing_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/products_access.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/products_categories.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/products_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/products_files.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/products_inventory.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/products_options.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/products_pricing_grid.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/relations_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/review_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/products/shipping_options.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/reports/reports.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/shipping/shipping_brackets.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/shipping/shipping_costs.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/shipping/shipping_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/shipping/shipping_quote_engine_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/shipping/shipping_type_groups.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/shipping/zone_edit.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/taxes/taxes_edit.tpl Diff ] File ]
Modules :: In-Bulletin: 5.1.x r13945
Timestamp: 2010-09-14 04:56:26
Author: alex
Details ] Diff ]
1. Bug 0000695: Remove endless "!" inside admin templates
2. Commit on behalf of Dmitry
mod - /modules/in-bulletin/branches/5.1.x/admin_templates/polls/answer_edit.tpl Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/admin_templates/polls/comment_edit.tpl Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/admin_templates/polls/poll_edit.tpl Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/admin_templates/topics/images_edit.tpl Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/admin_templates/topics/relations_edit.tpl Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/admin_templates/topics/review_edit.tpl Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/admin_templates/topics/topics_categories.tpl Diff ] File ]
mod - /modules/in-bulletin/branches/5.1.x/admin_templates/topics/topics_edit.tpl Diff ] File ]
Modules :: Custom: 1.1.x r13943
Timestamp: 2010-09-14 04:53:41
Author: alex
Details ] Diff ]
1. Bug 0000695: Remove endless "!" inside admin templates
2. Commit on behalf of Dmitry
mod - /modules/custom/branches/1.1.x/admin_templates/widgets/widget_edit.tpl Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-11-30 12:48 Dmitry Note Added: 0003031
2010-11-30 12:48 Dmitry Status resolved => closed
2010-09-14 04:58 alex Note Added: 0002831
2010-09-14 04:58 alex Status reviewed and tested => resolved
2010-09-14 04:58 alex Fixed in Version => 5.1.1-B1
2010-09-14 04:58 alex Resolution open => fixed
2010-09-14 04:58 alex Assigned To !COMMUNITY => alex
2010-09-14 04:58 alex Changeset attached 5.1.x r13949
2010-09-14 04:57 alex Changeset attached 5.1.x r13948
2010-09-14 04:57 alex Changeset attached 5.1.x r13947
2010-09-14 04:56 alex Changeset attached 5.1.x r13946
2010-09-14 04:56 alex Changeset attached 5.1.x r13945
2010-09-14 04:55 alex Changeset attached 5.1.x r13944
2010-09-14 04:53 alex Changeset attached 1.1.x r13943
2010-09-14 04:53 alex Note Added: 0002830
2010-09-14 04:53 alex Assigned To alex => !COMMUNITY
2010-09-14 04:53 alex Status needs testing => reviewed and tested
2010-08-29 19:03 Dmitry Note Edited: 0002749 View Revisions
2010-08-29 18:53 Dmitry Time Estimate Removed 3 =>
2010-08-29 18:53 Dmitry Note Added: 0002749
2010-08-29 18:53 Dmitry Assigned To Dmitry => alex
2010-08-29 18:53 Dmitry Developer => Dmitry
2010-08-29 18:53 Dmitry Status needs work => needs testing
2010-08-29 18:51 Dmitry File Added: Remove-ExplainationMarks-from-Phrases-Modules.patch
2010-08-29 18:51 Dmitry File Added: Remove-ExplainationMarks-from-Phrases-Core.patch
2010-08-27 13:14 Dmitry Time Estimate Added 3
2010-07-31 13:35 Dmitry Assigned To => Dmitry
2010-07-31 13:35 Dmitry Status active => needs work
2010-07-31 13:35 Dmitry Target Version Icebox => 5.1.1
2010-05-10 14:50 alex Target Version 5.0.4 => Icebox
2010-04-13 10:43 Dmitry New Issue
2010-04-13 10:43 Dmitry Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/1565976435f1f2ab



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker