In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Type

Reproducibility

Date Submitted

Last Update

0000677

[In-Portal CMS] Admin Interfaces

bug report

always

2010-03-30 07:33

2010-05-11 02:59

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Platform

Status

closed

OS Version

ETA

none

Fixed in Version

5.0.3-B2

Product Version

5.0.3-B1

Target Version

5.0.3

Product Build

Time Estimate

No estimate

Summary

0000677: Category tree (via ajax) in administrative console is not complete, when symlinks are set

Description

Category tree (via ajax) in administrative console is not complete, when symlinks are set. When ajax request is made to get category children it gets children from symlinked category instead.

It seems, that using SymLinkCategoryId field inside administrative console for link building is globally a bad idea, since there is no way to get to need category from tree to change that symlink for example.

What symlinks are (field "Points To Section" on section editing page)? They makes you go to other (symlinked) category, when you click to enter original category, where you have set "Points To Section" field. The only useful purpose is to make menus, where top level menu item upon clicking will lead to one of their sub-menus.

We by mistake assumed, that such behavior should also be applied in administrative console and especially in catalog tree (for category url building and sub-category via ajax). Here is the example (see a picture).

When you don't use symlinks, then you see sections that are in black. When A section points to D section and E section points to M section, then you see only sections that have red circles around them and don't see any structure in between.

Steps To Reproduce

Additional Information

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/b4916a923dc26f5f

Change Log Message

Estimate Points

Attached Files

dont_use_symlinks_for_category_tree_load_v2.patch [^] (2,318 bytes) 2010-03-30 07:33 [Show Content]

Index: admin_templates/categories/xml/tree_categories.tpl
===================================================================
--- admin_templates/categories/xml/tree_categories.tpl	(revision 13311)
+++ admin_templates/categories/xml/tree_categories.tpl	(working copy)
@@ -5,14 +5,14 @@
 			name="<inp2:Field name='Name'/>"
 			href="<inp2:CategoryLink template='catalog/catalog' pass='m' m_opener='r'/>"
 			icon="<inp2:c_ModulePath module='core'/>img/icons/icon24_section<inp2:m_if check='FieldEquals' name='CreatedBySystem' value='1'>_system</inp2:m_if>.png"
-			onclick="checkCatalog(<inp2:m_if check="Field" name="SymLinkCategoryId" db="db"><inp2:Field name="SymLinkCategoryId" db="db"/><inp2:m_else/><inp2:Field name='CategoryId' db="db"/></inp2:m_if>, '<inp2:GetModulePrefix/>')"
-			load_url="<inp2:CategoryLink pass='m'/>">
+			onclick="checkCatalog(<inp2:Field name='CategoryId' db="db"/>, '<inp2:GetModulePrefix/>')"
+			load_url="<inp2:CategoryLink direct_link="1" pass='m'/>">
 		</folder>
 	<inp2:m_else/>
 		<item
 			href="<inp2:CategoryLink template='catalog/catalog' pass='m' m_opener='r'/>"
 			icon="<inp2:c_ModulePath module='core'/>img/icons/icon24_section<inp2:m_if check='FieldEquals' name='CreatedBySystem' value='1'>_system</inp2:m_if>.png"
-			onclick="checkCatalog(<inp2:m_if check="Field" name="SymLinkCategoryId" db="db"><inp2:Field name="SymLinkCategoryId" db="db"/><inp2:m_else/><inp2:Field name='CategoryId' db="db"/></inp2:m_if>, '<inp2:GetModulePrefix/>')"><inp2:Field name="Name"/></item>
+			onclick="checkCatalog(<inp2:Field name='CategoryId' db="db"/>, '<inp2:GetModulePrefix/>')"><inp2:Field name="Name"/></item>
 	</inp2:m_if>
 </inp2:m_DefineElement>
 <tree>
Index: units/categories/categories_tag_processor.php
===================================================================
--- units/categories/categories_tag_processor.php	(revision 13311)
+++ units/categories/categories_tag_processor.php	(working copy)
@@ -256,7 +256,9 @@
 			$category_id = $this->Application->GetVar('m_cat_id');
 		}
 
-		$category_id = $this->getCategorySymLink( (int)$category_id );
+		if (!array_key_exists('direct_link', $params) || !$params['direct_link']) {
+			$category_id = $this->getCategorySymLink( (int)$category_id );
+		}
 
 		unset($params['cat_id'], $params['module']);

symlink_section_tree_proble.jpg [^] (39,514 bytes) 2010-03-30 07:34

Relationships [ Relation Graph ] [ Dependency Graph ]

parent of

0000797

closed (5.1.1)

alex

Incorrect section content is displayed for symlinked sections

Notes
(0001766) Dmitry (manager) 2010-04-03 22:00	Patch tested good!

(0001810) alex (manager) 2010-04-06 03:16	Fix committed to 5.0.x branch. Commit Message: Fixes 0000677: Category tree (via ajax) in administrative console is not complete, when symlinks are set

(0002096) alex (manager) 2010-05-11 02:59	Closing all tasks from released versions.

Related Changesets
In-Portal CMS: 5.0.x r13341 Timestamp: 2010-04-06 03:16:22 Author: alex [ Details ] [ Diff ]	Fixes 0000677: Category tree (via ajax) in administrative console is not complete, when symlinks are set
	mod - /in-portal/branches/5.0.x/core/admin_templates/categories/xml/tree_categories.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/units/categories/categories_tag_processor.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-08-29 05:31	alex	Relationship added	parent of 0000797
2010-05-11 02:59	alex	Note Added: 0002096
2010-05-11 02:59	alex	Status	resolved => closed
2010-04-06 03:16	alex	Note Added: 0001810
2010-04-06 03:16	alex	Status	reviewed and tested => resolved
2010-04-06 03:16	alex	Fixed in Version	=> 5.0.3-B2
2010-04-06 03:16	alex	Resolution	open => fixed
2010-04-06 03:16	alex	Assigned To	!COMMUNITY => alex
2010-04-06 03:16	alex	Changeset attached	5.0.x r13341
2010-04-03 22:00	Dmitry	Note Added: 0001766
2010-04-03 22:00	Dmitry	Status	needs testing => reviewed and tested
2010-03-30 07:34	alex	Assigned To	=> !COMMUNITY
2010-03-30 07:34	alex	Developer	=> alex
2010-03-30 07:34	alex	Status	active => needs testing
2010-03-30 07:34	alex	File Added: symlink_section_tree_proble.jpg
2010-03-30 07:33	alex	New Issue
2010-03-30 07:33	alex	File Added: dont_use_symlinks_for_category_tree_load_v2.patch
2010-03-30 07:33	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/b4916a923dc26f5f

Web Development by Intechnic

In-Portal Open Source CMS