In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000667

[In-Portal CMS] Data Management

bug report

always

2010-03-27 17:52

2010-06-10 13:44

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Platform

Status

closed

OS

OS Version

ETA

none

Fixed in Version

5.0.4-B1

Product Version

5.0.3-B1

Target Version

5.0.4

Product Build

Time Estimate

No estimate

Summary

0000667: Phrase labels are not validated leading to errors

Description

We should add restriction to "Labels" so ONLY "alpha-number" symbols can be used. In some case I saw users putting "spaces" and other non-latin letters which actually messes up during the Import. Also validate, that phrase starts with "lu_" or "la_".

I propose we tell admin (during phrase adding/editing), what other phrases in language pack have same translation as it's phrase. In most cases duplicate translation will mean nothing, but sometimes it will help to prevent duplicate translations. Validate by CRC32 of translation.

Steps To Reproduce

Additional Information

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-dev/browse_thread/thread/78a99ec279bd9f1e

Change Log Message

Estimate Points

0

phrase_validation.patch [^] (883 bytes) 2010-05-19 08:51 [Show Content]

Index: units/phrases/phrases_config.php
===================================================================
--- units/phrases/phrases_config.php	(revision 13571)
+++ units/phrases/phrases_config.php	(working copy)
@@ -132,8 +132,8 @@
 		'Fields' => Array (
             'Phrase' => Array (
             	'type' => 'string',
-            	'required' => 1, 'unique' => Array ('LanguageId'),
-            	'not_null' => 1, 'default' => '',
+            	'formatter' => 'kFormatter', 'regexp' => '/^(la|lu)_[A-Z\d:_\-\.]+$/i', 'unique' => Array ('LanguageId'),
+            	'not_null' => 1, 'required' => 1, 'default' => '',
             ),
 			'PhraseKey' => Array ('type' => 'string', 'max_len' => 255, 'not_null' => 1, 'default' => ''),
             'Translation' => Array ('type' => 'string', 'formatter' => 'kFormatter', 'required' => 1, 'using_fck' => 1, 'default' => NULL),

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0002254) alex (manager) 2010-05-19 08:53	I didn't implemented 2nd task part about phrase suggestion, since I don't know how to do it in not annoying way. For example we have phrases "la_col_Id" and "la_fld_Id" which have same translation (mostly all column and field phrases have same translations) and I don't want to see warning every time I edit that phrase.

(0002255) Dmitry (manager) 2010-05-19 11:58	Tested good. Let's commit and resolve this task for now.

(0002263) alex (manager) 2010-05-19 12:52	Fix committed to 5.0.x branch. Commit Message: Fixes 0000667: Phrase labels are not validated leading to errors

(0002412) alex (manager) 2010-06-10 13:44	Closing since version 5.0.4 is released.

Related Changesets
In-Portal CMS: 5.0.x r13591 Timestamp: 2010-05-19 12:52:27 Author: alex [ Details ] [ Diff ]	Fixes 0000667: Phrase labels are not validated leading to errors
	mod - /in-portal/branches/5.0.x/core/units/phrases/phrases_config.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-06-10 13:44	alex	Note Added: 0002412
2010-06-10 13:44	alex	Status	resolved => closed
2010-05-19 12:52	alex	Note Added: 0002263
2010-05-19 12:52	alex	Status	reviewed and tested => resolved
2010-05-19 12:52	alex	Fixed in Version	=> 5.0.4-B1
2010-05-19 12:52	alex	Resolution	open => fixed
2010-05-19 12:52	alex	Assigned To	!COMMUNITY => alex
2010-05-19 12:52	alex	Changeset attached	5.0.x r13591
2010-05-19 11:58	Dmitry	Note Added: 0002255
2010-05-19 11:58	Dmitry	Status	needs testing => reviewed and tested
2010-05-19 08:53	alex	Note Added: 0002254
2010-05-19 08:53	alex	Assigned To	=> !COMMUNITY
2010-05-19 08:53	alex	Developer	=> alex
2010-05-19 08:53	alex	Status	active => needs testing
2010-05-19 08:51	alex	File Added: phrase_validation.patch
2010-05-19 08:35	alex	Description Updated	View Revisions
2010-03-27 17:52	alex	New Issue
2010-03-27 17:52	alex	Reference	=> http://groups.google.com/group/in-portal-dev/browse_thread/thread/78a99ec279bd9f1e

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group