In-Portal Issue Tracker

Index: admin_templates/js/script.js
===================================================================
--- admin_templates/js/script.js	(revision 13658)
+++ admin_templates/js/script.js	(working copy)
@@ -1825,4 +1825,22 @@
     	$selected_category.attr('selected', '');
     	$("option[value='" + $allowed_categories[0] + '"]', $categories).attr('selected', 'selected');
     }
+}
+
+function crc32(str) {
+	var table = '00000000 77073096 EE0E612C 990951BA 076DC419 706AF48F E963A535 9E6495A3 0EDB8832 79DCB8A4 E0D5E91E 97D2D988 09B64C2B 7EB17CBD E7B82D07 90BF1D91 1DB71064 6AB020F2 F3B97148 84BE41DE 1ADAD47D 6DDDE4EB F4D4B551 83D385C7 136C9856 646BA8C0 FD62F97A 8A65C9EC 14015C4F 63066CD9 FA0F3D63 8D080DF5 3B6E20C8 4C69105E D56041E4 A2677172 3C03E4D1 4B04D447 D20D85FD A50AB56B 35B5A8FA 42B2986C DBBBC9D6 ACBCF940 32D86CE3 45DF5C75 DCD60DCF ABD13D59 26D930AC 51DE003A C8D75180 BFD06116 21B4F4B5 56B3C423 CFBA9599 B8BDA50F 2802B89E 5F058808 C60CD9B2 B10BE924 2F6F7C87 58684C11 C1611DAB B6662D3D 76DC4190 01DB7106 98D220BC EFD5102A 71B18589 06B6B51F 9FBFE4A5 E8B8D433 7807C9A2 0F00F934 9609A88E E10E9818 7F6A0DBB 086D3D2D 91646C97 E6635C01 6B6B51F4 1C6C6162 856530D8 F262004E 6C0695ED 1B01A57B 8208F4C1 F50FC457 65B0D9C6 12B7E950 8BBEB8EA FCB9887C 62DD1DDF 15DA2D49 8CD37CF3 FBD44C65 4DB26158 3AB551CE A3BC0074 D4BB30E2 4ADFA541 3DD895D7 A4D1C46D D3D6F4FB 4369E96A 346ED9FC AD678846 DA60B8D0 44042D73 33031DE5 AA0A4C5F DD0D7CC9 5005713C 270241AA BE0B1010 C90C2086 5768B525 206F85B3 B966D409 CE61E49F 5EDEF90E 29D9C998 B0D09822 C7D7A8B4 59B33D17 2EB40D81 B7BD5C3B C0BA6CAD EDB88320 9ABFB3B6 03B6E20C 74B1D29A EAD54739 9DD277AF 04DB2615 73DC1683 E3630B12 94643B84 0D6D6A3E 7A6A5AA8 E40ECF0B 9309FF9D 0A00AE27 7D079EB1 F00F9344 8708A3D2 1E01F268 6906C2FE F762575D 806567CB 196C3671 6E6B06E7 FED41B76 89D32BE0 10DA7A5A 67DD4ACC F9B9DF6F 8EBEEFF9 17B7BE43 60B08ED5 D6D6A3E8 A1D1937E 38D8C2C4 4FDFF252 D1BB67F1 A6BC5767 3FB506DD 48B2364B D80D2BDA AF0A1B4C 36034AF6 41047A60 DF60EFC3 A867DF55 316E8EEF 4669BE79 CB61B38C BC66831A 256FD2A0 5268E236 CC0C7795 BB0B4703 220216B9 5505262F C5BA3BBE B2BD0B28 2BB45A92 5CB36A04 C2D7FFA7 B5D0CF31 2CD99E8B 5BDEAE1D 9B64C2B0 EC63F226 756AA39C 026D930A 9C0906A9 EB0E363F 72076785 05005713 95BF4A82 E2B87A14 7BB12BAE 0CB61B38 92D28E9B E5D5BE0D 7CDCEFB7 0BDBDF21 86D3D2D4 F1D4E242 68DDB3F8 1FDA836E 81BE16CD F6B9265B 6FB077E1 18B74777 88085AE6 FF0F6A70 66063BCA 11010B5C 8F659EFF F862AE69 616BFFD3 166CCF45 A00AE278 D70DD2EE 4E048354 3903B3C2 A7672661 D06016F7 4969474D 3E6E77DB AED16A4A D9D65ADC 40DF0B66 37D83BF0 A9BCAE53 DEBB9EC5 47B2CF7F 30B5FFE9 BDBDF21C CABAC28A 53B39330 24B4A3A6 BAD03605 CDD70693 54DE5729 23D967BF B3667A2E C4614AB8 5D681B02 2A6F2B94 B40BBE37 C30C8EA1 5A05DF1B 2D02EF8D';
+
+	var crc = 0;
+	var x = 0;
+	var y = 0;
+
+	crc = crc ^ (-1);
+
+	for (var i = 0, iTop = str.length; i < iTop; i++) {
+		y = ( crc ^ str.charCodeAt( i ) ) & 0xFF;
+		x = "0x" + table.substr( y * 9, 8 );
+		crc = ( crc >>> 8 ) ^ x;
+	}
+
+	return crc ^ (-1);
 }
\ No newline at end of file
Index: admin_templates/js/uploader/upload_manager.js
===================================================================
--- admin_templates/js/uploader/upload_manager.js	(revision 13659)
+++ admin_templates/js/uploader/upload_manager.js	(working copy)
@@ -118,7 +118,7 @@
 	var $uploader = this._Uploaders[uploader_id];
 
 	Request.makeRequest(
-		$uploader.deleteURL.replace('#FILE#', fname).replace('#FIELD#', $uploader.params.field),
+		$uploader.deleteURL.replace('#FILE#', encodeURIComponent(fname)).replace('#FIELD#', $uploader.params.field),
 		false, '',
 		function(req, fname, $uploader) {
 			$uploader.removeFile({id:fname})
Index: admin_templates/js/uploader/uploader.js
===================================================================
--- admin_templates/js/uploader/uploader.js	(revision 13659)
+++ admin_templates/js/uploader/uploader.js	(working copy)
@@ -182,7 +182,7 @@
 
 		for (var i = 0; i < urls.length; i++) {
 			var a_file = {
-				id : names[i],
+				id : 'uploaded_' + crc32(names[i]),
 				name : names[i],
 				url : urls[i],
 				size: sizes[i],
@@ -483,7 +483,7 @@
 		this.files[$file_index].uploaded = 1;
 		this.files[$file_index].progress = 100;
 		this.files[$file_index].temp = 1;
-		this.files[$file_index].url = this.params.tmp_url.replace('#ID#', file.id).replace('#FILE#', file.name).replace('#FIELD#', this.params.field);
+		this.files[$file_index].url = this.params.tmp_url.replace('#ID#', file.id).replace('#FILE#', encodeURIComponent(file.name)).replace('#FIELD#', this.params.field);
 	}
 
 	this.updateInfo($file_index);
Index: kernel/db/db_event_handler.php
===================================================================
--- kernel/db/db_event_handler.php	(revision 13659)
+++ kernel/db/db_event_handler.php	(working copy)
@@ -2736,47 +2736,45 @@
 			$field = $this->Application->GetVar('field');
 			$options = $object->GetFieldOptions($field);
 
+			// set current uploaded file
 			if ($this->Application->GetVar('tmp')) {
-				$path = WRITEABLE . '/tmp/' . $this->Application->GetVar('id') . '_' . $file;
+				$options['upload_dir'] = WRITEBALE_BASE . '/tmp/';
+				unset($options['include_path']);
+				$object->SetFieldOptions($field, $options);
+
+				$object->SetDBField($field, $this->Application->GetVar('id') . '_' . $file);
 			}
 			else {
-				$upload_dir = $options['upload_dir'];
+				$object->SetDBField($field, $file);
+			}
 
-				if (array_key_exists('include_path', $options) && $options['include_path']) {
-					// relative path is already included in field
-					$upload_dir = '';
-				}
-
-				$path = FULL_PATH . $upload_dir . $file;
+			// get url to uploaded file
+			if ($this->Application->GetVar('thumb')) {
+				$url = $object->GetField($field, $options['thumb_format']);
 			}
+			else {
+				$url = $object->GetField($field, 'full_url'); // don't use "file_urls" format to prevent recursion
+			}
 
-			$path = str_replace('/', DIRECTORY_SEPARATOR, $path);
+			$file_helper =& $this->Application->recallObject('FileHelper');
+			/* @var $file_helper FileHelper */
 
+			$path = $file_helper->urlToPath($url);
+
 			if (!file_exists($path)) {
 				exit;
 			}
 
-			if ($this->Application->GetVar('thumb')) {
-				$image_helper =& $this->Application->recallObject('ImageHelper');
-				/* @var $image_helper ImageHelper */
-
-				$path = $image_helper->ResizeImage($path, $options['thumb_format']);
-
-				$base_url = rtrim($this->Application->BaseURL(), '/');
-				$path = preg_replace('/^' . preg_quote($base_url, '/') . '(.*)/', FULL_PATH . '\\1', $path);
-				$path = str_replace('/', DIRECTORY_SEPARATOR, $path);
-			}
-
 			$type = mime_content_type($path);
 
 			header('Content-Length: ' . filesize($path));
 			header('Content-Type: ' . $type);
 			header('Content-Disposition: inline; filename="' . $file . '"');
 
-			safeDefine('DBG_SKIP_REPORTING',1);
+			safeDefine('DBG_SKIP_REPORTING', 1);
 
 			readfile($path);
-			exit();
+			exit;
 		}
 
 		/**
Index: kernel/utility/formatters/upload_formatter.php
===================================================================
--- kernel/utility/formatters/upload_formatter.php	(revision 13569)
+++ kernel/utility/formatters/upload_formatter.php	(working copy)
@@ -266,14 +266,15 @@
 		switch ($format) {
 			case 'full_url':
 				if (isset($options['direct_links']) && $options['direct_links']) {
-					return rtrim($this->Application->BaseURL(), '/') . str_replace(DIRECTORY_SEPARATOR, '/', $upload_dir) . $value;
+					return $this->fileHelper->pathToUrl(FULL_PATH . $upload_dir . $value);
 				}
 				else {
 					$url_params = Array (
 						'no_amp' => 1, 'pass' => 'm,'.$object->Prefix,
-						$object->Prefix.'_event' => 'OnViewFile',
-						'file' => $value, 'field' => $field_name
+						$object->Prefix . '_event' => 'OnViewFile',
+						'file' => rawurlencode($value), 'field' => $field_name
 					);
+
 					return $this->Application->HREF('', '', $url_params);
 				}
 				break;
Index: units/helpers/file_helper.php
===================================================================
--- units/helpers/file_helper.php	(revision 13569)
+++ units/helpers/file_helper.php	(working copy)
@@ -270,4 +270,32 @@
 
 			return $result;
 		}
+
+		/**
+		 * Transforms given path to file into it's url, where each each component is encoded (excluding domain and protocol)
+		 *
+		 * @param string $url
+		 * @return string
+		 */
+		function pathToUrl($url)
+		{
+			$url = str_replace(DIRECTORY_SEPARATOR, '/', preg_replace('/^' . preg_quote(FULL_PATH, '/') . '(.*)/', '\\1', $url, 1));
+			$url = implode('/', array_map('rawurlencode', explode('/', $url)));
+
+			return rtrim($this->Application->BaseURL(), '/') . $url;
+		}
+
+		/**
+		 * Transforms given url to path to it
+		 *
+		 * @param string $url
+		 * @return string
+		 */
+		function urlToPath($url)
+		{
+			$base_url = rtrim($this->Application->BaseURL(), '/');
+			$path = preg_replace('/^' . preg_quote($base_url, '/') . '(.*)/', FULL_PATH . '\\1', $url);
+
+			return str_replace('/', DIRECTORY_SEPARATOR, rawurldecode($path));
+		}
 	}
\ No newline at end of file
Index: units/helpers/image_helper.php
===================================================================
--- units/helpers/image_helper.php	(revision 13569)
+++ units/helpers/image_helper.php	(working copy)
@@ -139,8 +139,7 @@
 				return $image_info ? $image_info[3] : '';
 			}
 
-			$base_url = rtrim($this->Application->BaseURL(), '/');
-			return str_replace(DIRECTORY_SEPARATOR, '/', preg_replace('/^'.preg_quote(FULL_PATH, '/').'(.*)/', $base_url.'\\1', $src_image));
+			return $this->fileHelper->pathToUrl($src_image);
 		}
 
 		/**