In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000654

[In-Portal CMS] Admin Interfaces

bug report

always

2010-03-27 16:55

2010-05-11 02:59

Reporter

phil

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Platform

Status

closed

OS

OS Version

ETA

none

Fixed in Version

5.0.3-B2

Product Version

5.0.3-B1

Target Version

5.0.3

Product Build

Time Estimate

No estimate

Summary

0000654: Incorrent "radio" type custom field display

Description

I've tried Custom Fields for different modules and In-Portal itself, and I've found that when I choose "radio button", in-portal will display (while editing
an item) a blank radio button, followed by the radio button I've have created.

Steps To Reproduce

Additional Information

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/4f12d26a1266bf5f

Change Log Message

Estimate Points

0

Custom-Field-Result.png [^] (2,565 bytes) 2010-03-27 16:55

empty_option_for_radio_custom_fields.patch [^] (1,251 bytes) 2010-03-30 04:36 [Show Content]

Index: install/upgrades.sql
===================================================================
--- install/upgrades.sql	(revision 13311)
+++ install/upgrades.sql	(working copy)
@@ -1630,4 +1630,7 @@
 
 UPDATE Phrase
 SET Module = 'Core'
-WHERE Phrase IN ('la_fld_Image', 'la_fld_Qty');
\ No newline at end of file
+WHERE Phrase IN ('la_fld_Image', 'la_fld_Qty');
+
+# ===== v 5.0.3-B2 =====
+UPDATE CustomField SET ValueList = REPLACE(ValueList, '=+||', '') WHERE ElementType = 'radio';
\ No newline at end of file
Index: units/custom_fields/custom_fields_event_handler.php
===================================================================
--- units/custom_fields/custom_fields_event_handler.php	(revision 13311)
+++ units/custom_fields/custom_fields_event_handler.php	(working copy)
@@ -284,7 +284,7 @@
 			$minput_helper =& $this->Application->recallObject('MInputHelper');
 			/* @var $minput_helper MInputHelper */
 
-			$ret = $object->GetDBField('ElementType') == 'multiselect' ? Array () : Array ('' => '=+');
+			$ret = $object->GetDBField('ElementType') == 'select' ? Array ('' => '=+') : Array ();
 			$records = $minput_helper->parseMInputXML($object->GetDBField('Options'));
 
 			if ($object->GetDBField('SortValues')) {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0001760) alex (manager) 2010-03-30 04:37	Also apply last sql from upgrades.sql to fix already created custom fields. Patch prevents such strange custom fields to be created in future.

(0001768) Dmitry (manager) 2010-04-03 22:02	Patch reviewed and tested Good, please commit

(0001808) alex (manager) 2010-04-06 03:13	Fix committed to 5.0.x branch. Commit Message: Fixes 0000654: Incorrent "radio" type custom field display

(0002098) alex (manager) 2010-05-11 02:59	Closing all tasks from released versions.

Related Changesets
In-Portal CMS: 5.0.x r13339 Timestamp: 2010-04-06 03:13:38 Author: alex [ Details ] [ Diff ]	Fixes 0000654: Incorrent "radio" type custom field display
	mod - /in-portal/branches/5.0.x/core/install/upgrades.sql		[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/units/custom_fields/custom_fields_event_handler.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-05-11 02:59	alex	Note Added: 0002098
2010-05-11 02:59	alex	Status	resolved => closed
2010-04-06 03:13	alex	Note Added: 0001808
2010-04-06 03:13	alex	Status	reviewed and tested => resolved
2010-04-06 03:13	alex	Fixed in Version	=> 5.0.3-B2
2010-04-06 03:13	alex	Resolution	open => fixed
2010-04-06 03:13	alex	Assigned To	!COMMUNITY => alex
2010-04-06 03:13	alex	Changeset attached	5.0.x r13339
2010-04-03 22:02	Dmitry	Note Added: 0001768
2010-04-03 22:02	Dmitry	Status	needs testing => reviewed and tested
2010-03-30 04:37	alex	Note Added: 0001760
2010-03-30 04:37	alex	Assigned To	=> !COMMUNITY
2010-03-30 04:37	alex	Developer	=> alex
2010-03-30 04:37	alex	Status	active => needs testing
2010-03-30 04:36	alex	File Added: empty_option_for_radio_custom_fields.patch
2010-03-27 16:55	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/4f12d26a1266bf5f
2010-03-27 16:55	alex	Reporter	alex => phil
2010-03-27 16:55	alex	New Issue
2010-03-27 16:55	alex	File Added: Custom-Field-Result.png

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group