Anonymous | Login | Signup for a new account | 2023-12-05 03:07 CST | ![]() |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ] | [ View Simple ] [ Issue History ] [ Print ] | ||||||
ID | Category | Type | Reproducibility | Date Submitted | Last Update | ||
0000365 | [In-Portal CMS] Front End | bug report | always | 2009-10-09 04:36 | 2011-03-14 02:10 | ||
Reporter | alex | View Status | public | Project Name | In-Portal CMS | ||
Assigned To | alex | Developer | |||||
Priority | normal | Resolution | fixed | Platform | |||
Status | closed | OS | |||||
OS Version | |||||||
ETA | none | Fixed in Version | 5.0.2-B1 | Product Version | 5.0.1 | ||
Target Version | 5.0.2 | Product Build | |||||
Time Estimate | No estimate | ||||||
Summary | 0000365: Mod-rewrite erases page number given in "env" request parameter | ||||||
Description |
Let's say we have two rewrite listeners: 1. UserRewriteListener - handles template name transformations 2. PrivateMessageRewriteListener - handles private message pagination and ids When UserRewriteListener is pretty sure, that there nothing to give to other rewrite listeners it returns false and PrivateMessageRewriteListener is not called. I'm building url, that contains such prefixes "m,u,private-message" and private-message prefix event is OnDelete - this is url to delete individual private message. Both rewrite listeners are written the way, that when event is present, then they don't rewrite prefix data. This way url will be: http://www.site.com/username/messages/outbox.html?env=private\-message-16-2-10-OnDelete- As you can see, it contains private message ID - 16, current page in private message list - 2 and per page in private message list - 10. And I'm assuming that such values (16, 2, 10) will be available in OnDelete event, when I visit mentioned above url. But this doesn't happen (see call trace below): 1. "env" variable is parsed and given variables are extracted from it (we have page number here). 2. page numbers from all rewrite listeners are set to "1" (setting to all rewrite listeners, because we don't know what of that will be represented in event/template; setting to "1" to override page number stored in session) - this is where we loose our page number. 3. when url ends with number, like "http://www.site.com/..../5.html) set this number as current page for all rewrite listeners. Problem happens in 2nd step, because it's setting first page to all rewrite listeners no matter will they be called or not. I propose we apply 2nd and 3rd steps individually before each rewrite listener is called. This way wrong page number won't be set for rewrite listener, that's not even is called. |
||||||
Steps To Reproduce | |||||||
Additional Information | |||||||
Tags | No tags attached. | ||||||
Reference | |||||||
Change Log Message | |||||||
Estimate Points | 0 | ||||||
Attached Files |
![]() |
||||||
|
![]() |
||||||
|
![]() |
|
![]() Dmitry (manager) 2009-10-18 02:37 |
Reviewed the code - ok, but have no test case to check this. |
![]() alex (manager) 2009-10-25 15:24 |
Moving to 5.0.2 release as community input during 5.0.2-B1 version testing. |
![]() alex (manager) 2009-10-25 15:29 |
Fix committed to 5.0.x branch. Commit Message: Fixes 0000365: Mod-rewrite erases page number given in "env" request parameter |
![]() Dmitry (manager) 2010-01-11 22:05 |
Closing completed tasks. |
![]() |
|||
In-Portal CMS: 5.0.x r12784 Timestamp: 2009-10-25 15:29:54 Author: alex [ Details ] [ Diff ] |
Fixes 0000365: Mod-rewrite erases page number given in "env" request parameter | ||
mod - /in-portal/branches/5.0.x/core/units/helpers/mod_rewrite_helper.php | [ Diff ] [ File ] | ||
![]() |
|||
Date Modified | Username | Field | Change |
2011-03-14 02:10 | alex | Relationship added | child of 0000098 |
2010-01-11 22:05 | Dmitry | Note Added: 0001359 | |
2010-01-11 22:05 | Dmitry | Status | resolved => closed |
2009-10-25 15:29 | alex | Note Added: 0000968 | |
2009-10-25 15:29 | alex | Status | reviewed and tested => resolved |
2009-10-25 15:29 | alex | Fixed in Version | => 5.0.2-B1 |
2009-10-25 15:29 | alex | Resolution | open => fixed |
2009-10-25 15:29 | alex | Changeset attached | 5.0.x r12784 |
2009-10-25 15:24 | alex | Note Added: 0000967 | |
2009-10-25 15:24 | alex | Target Version | Icebox => 5.0.2 |
2009-10-18 02:37 | Dmitry | Note Added: 0000921 | |
2009-10-18 02:37 | Dmitry | Assigned To | !COMMUNITY => alex |
2009-10-18 02:37 | Dmitry | Status | needs testing => reviewed and tested |
2009-10-09 05:02 | alex | Assigned To | => !COMMUNITY |
2009-10-09 05:02 | alex | Status | active => needs testing |
2009-10-09 05:02 | alex | File Added: mod rewrite page override.patch | |
2009-10-09 04:40 | alex | Target Version | => Icebox |
2009-10-09 04:36 | alex | New Issue |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Web Development by Intechnic![]() In-Portal Open Source CMS |