In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details Jump to Notes ] Wiki ] View Simple ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000026 [In-Portal CMS] Optimization task always 2009-05-21 07:26 2010-01-11 22:05
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Platform
Status closed   OS
  OS Version
ETA none Fixed in Version 5.0.2 Product Version 4.3.9
  Target Version 5.0.2 Product Build
Time EstimateNo estimate
Summary 0000026: Rename "kUploadFormatter::ValidateFileName" method
Description Method ValidateFileName of class kUploadFormatter doesn't validate anything, but it actually generates new filename for uploaded file in case, when given filename is already used by other file in same directory.

There are 2 possible solutions:
1. make this method validate filename (returns true/false) and move current method body to new method _generateFileName
2. rename method to _generateFileName, because for now it does only that.
Steps To Reproduce
Additional Information
Tags No tags attached.
Reference
Change Log Message
Estimate Points 0
Attached Files patch file icon upload formatter method naming fix.patch [^] (2,524 bytes) 2009-10-04 08:22 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0000837)
Dmitry (manager)
2009-10-08 12:12

Please describe how to test.
User avatar (0000843)
alex (manager)
2009-10-08 14:30

Task was to rename method, you can check changed code and verify, that method was renamed.
User avatar (0000854)
Dmitry (manager)
2009-10-08 18:16

Reviewed and tested OK!
User avatar (0000867)
alex (manager)
2009-10-10 06:36

Fix committed to 5.0.x branch. Commit Message:

Fixes 0000026: Rename "kUploadFormatter::ValidateFileName" method
User avatar (0001383)
Dmitry (manager)
2010-01-11 22:05

Closing completed tasks.

- Related Changesets
In-Portal CMS: 5.0.x r12679
Timestamp: 2009-10-10 06:36:46
Author: alex
Details ] Diff ]
Fixes 0000026: Rename "kUploadFormatter::ValidateFileName" method
mod - /in-portal/branches/5.0.x/core/kernel/utility/formatters/upload_formatter.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-01-11 22:05 Dmitry Note Added: 0001383
2010-01-11 22:05 Dmitry Status resolved => closed
2009-10-10 06:36 alex Note Added: 0000867
2009-10-10 06:36 alex Status reviewed and tested => resolved
2009-10-10 06:36 alex Fixed in Version => 5.0.2
2009-10-10 06:36 alex Resolution open => fixed
2009-10-10 06:36 alex Changeset attached 5.0.x r12679
2009-10-08 18:16 Dmitry Note Added: 0000854
2009-10-08 18:16 Dmitry Assigned To Dmitry => alex
2009-10-08 18:16 Dmitry Status needs feedback => reviewed and tested
2009-10-08 14:30 alex Note Added: 0000843
2009-10-08 14:30 alex Assigned To alex => Dmitry
2009-10-08 12:12 Dmitry Note Added: 0000837
2009-10-08 12:12 Dmitry Assigned To !COMMUNITY => alex
2009-10-08 12:12 Dmitry Status needs testing => needs feedback
2009-10-06 14:25 alex Type bug report => task
2009-10-04 08:23 alex Time Estimate Removed 1 =>
2009-10-04 08:23 alex Assigned To alex => !COMMUNITY
2009-10-04 08:23 alex Status active => needs testing
2009-10-04 08:22 alex File Added: upload formatter method naming fix.patch
2009-10-03 08:01 alex Assigned To => alex
2009-09-23 13:31 alex Time Estimate Added 1
2009-09-20 15:19 alex Target Version 5.1.0 => 5.0.2
2009-06-07 06:48 alex Reproducibility @70@ => always
2009-05-25 21:34 Dmitry version 5.0.0 => 4.3.9
2009-05-25 21:34 Dmitry Target Version => 5.1.0
2009-05-21 07:26 alex New Issue



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker